From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C23C42E8F; Sun, 16 Jul 2023 20:17:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16D094114A; Sun, 16 Jul 2023 20:17:30 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id B11004113F for ; Sun, 16 Jul 2023 20:17:28 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b8bd586086so30382455ad.2 for ; Sun, 16 Jul 2023 11:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689531448; x=1692123448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EfVPx8IxOOWki/fiothYt5aS1pbLN9WWCQJpPqGc1Zs=; b=B2XbzhqLvH312jKa8/4nXWHCgdkIvUmmyfMjBxK086gah87XVb0zlgTf42G8BJzXum 6a/yISDYwLLhmnIGywWbDJm8+ROn/qdAMZ1kTtBWdfiC3OYBRY+AhwAnGbjbijSoq09D VNiFaISR2LJDJMI/k9m7ooa44/ATecLsXKd7qnASCOW70AZ26b1juXDZM6khteeIKbxA uA20PUbfm5IZz/QVUIzZ0yYUvG+h1aHMShv8ilWBa6JNaRvIGtjt+QByAAET7VSOYfyU GafFXv0Xw1uAmB/TVzVtaABlZnWb0+KEbKkNmVhcKDPngK9jn50PXrqfW0y6HaZxH0Um K2bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689531448; x=1692123448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EfVPx8IxOOWki/fiothYt5aS1pbLN9WWCQJpPqGc1Zs=; b=Mqlfz5HMod94HD1GFrOb1TEo6JjnyDD/RRH31M2tgGuMNuzXDBctm9Ax2m/5/Ifim2 SQPYxT+m77iqp0qYoNb9/9On4RvC90BiOB08NyoINj/52NNJvlY9SELwxCOtbIf839Eq VkLU1xjBZdJ0ZBpAzqlmqIu24rg/ocynGZciVw8xYpEvKLzev0tOigZSbKxQepV2xHOP r0NEZ0LA0AOPaK+ljazfqoYKi/zwRPMVhwDeME59whxR3MSa7ENa3LVWCuO7odjxV+Qz pVZ+N8/kHQaaGt23k3XNJ7mg2FJnGewM5Dm6/mfUDeFpTt3TPtEJKcrdGCyRGAXGegc9 zJXA== X-Gm-Message-State: ABy/qLYR8wmH4rQH8jGc4Qso5PkX0uRd2Rjel/DKzFR6zPPcvE6zMdtZ dpN3w5gx44E7Kycwganiej4VOA== X-Google-Smtp-Source: APBJJlE4lqx7qekgEINlb6/UuGC+lNjC0sHWj43PRYgp5uQuq/JKhfdaBmhPXq2jSwbRCfJW9GDLBA== X-Received: by 2002:a17:902:c949:b0:1b8:b5f8:c485 with SMTP id i9-20020a170902c94900b001b8b5f8c485mr13144336pla.50.1689531447902; Sun, 16 Jul 2023 11:17:27 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id u4-20020a17090add4400b00262e9fbd5fbsm3807672pjv.32.2023.07.16.11.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jul 2023 11:17:27 -0700 (PDT) Date: Sun, 16 Jul 2023 11:17:25 -0700 From: Stephen Hemminger To: Lichao Liu Cc: dev@dpdk.org Subject: Re: [PATCH] bus/pci: 'RTE_PMD_REGISTER_PCI' support expand 'nm' Message-ID: <20230716111725.540b2ed0@hermes.local> In-Reply-To: <20220802084839.30118-1-liulichao.09679@bytedance.com> References: <20220802084839.30118-1-liulichao.09679@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Aug 2022 16:48:39 +0800 Lichao Liu wrote: > Before, 'RTE_PMD_REGISTER_PCI' can not expand nm. So, it can not > work in this situation: > #define TEST(a, b) a##_##b > RTE_PMD_REGISTER_PCI(TEST(a, b), test_pmd_driver) > > Signed-off-by: Lichao Liu It is not clear what the problem is. All the existing drivers work fine. Did you follow the coding conventions and patterns of existing drivers or try and do something different. Recommend not accepting this patch. If you have a more verbose example of why this won't work for you please resubmit the patch.