From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B215142EBA; Wed, 19 Jul 2023 18:12:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F87740E03; Wed, 19 Jul 2023 18:12:53 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id A1BC640DFD for ; Wed, 19 Jul 2023 18:12:52 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1b8bbcfd89aso42421675ad.1 for ; Wed, 19 Jul 2023 09:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689783172; x=1690387972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=j/fWzyHeXSDux3TPtjVcUjpC2t6Cp/6OZ361AMHt+Zs=; b=DTZtZIicweGEk1xbeuL3uvqsvQYImBuwAPcDWDsmgbh/I0XZxuioFdhtBCCaByRxpF OOg9HV49qTLs2YnNWKVLJiVdrSDa0Yikw4QrllfOzuT7vib9KP50lJt40QxCEFOc2KxI gY4ouPEIcmjJj4RHEseA1MHU0LYIJRv4m50ZucL9rMT6skvk9fiXOkqHuwt7auF6BzUr k09V6cZNcknb3KT8t7g7dti3F3AUHZ4R4dVuXf14+6+SzmcdoGKfELxqDkxw37XXTb39 3pv6BqX2VfmWraYP06f2VQqgtk24qe/BHsdUChuf6IinxOeAXRDXYpeylIa/lye1QIfR uTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689783172; x=1690387972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/fWzyHeXSDux3TPtjVcUjpC2t6Cp/6OZ361AMHt+Zs=; b=coDa1sZPCfws41k2riCHAUa/swMRRiTLdEWS1NwF9SnNDBJQZWffKLhKwxwfvTSkYw oYJgDkaBBtyadfE8aZnzb8klRVNqjiXiWjsPJrPKVlqUniSqZprv+lLekHxdlm51foJr msK9zd/Pqh6aANSUjFwXRVLxnYlJZ5zx5kY434D0IkfZIqeaVIMkCF+QO3A3LnlnoBtx ERNAx8BiGzr6LckWusNIahZnayAdY2X3NEMqZkkcdbDtE8FyZkqXcn6f1UdOHEDT2wG0 vqmTOVJH5bZ6TsS1f66lqfReUcTtShA6OkGSOOCH2cAzUBpYBoVtXaU0viPIBv3O19tb f9/w== X-Gm-Message-State: ABy/qLZk6jTKNNfQDZyPnXNSPb2LZFCa6XVihBlcWzsrvrfRuyxPo2yW OEeGFYfMHkf4BBpQ/+RB88KFHg== X-Google-Smtp-Source: APBJJlHKsASWaBpEyHrNMRoMhowPoZDPKAkLUFVFlJbbWVlKjjmqDTemJJLhiiIe5hrEHX8LCuE0bg== X-Received: by 2002:a17:902:9f96:b0:1b6:72af:623d with SMTP id g22-20020a1709029f9600b001b672af623dmr14213291plq.55.1689783171696; Wed, 19 Jul 2023 09:12:51 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id jk14-20020a170903330e00b001b9cd9d7ce4sm4176889plb.219.2023.07.19.09.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 09:12:51 -0700 (PDT) Date: Wed, 19 Jul 2023 09:12:49 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Ophir Munk , dev@dpdk.org, Thomas Monjalon , Aaron Conole , dpdklab , David Marchand Subject: Re: [PATCH] tap: fix build of tap_bpf_program Message-ID: <20230719091249.0ea91a4e@hermes.local> In-Reply-To: <75eef8f8-c0c0-1950-6149-756bd624e9d6@amd.com> References: <20230717191548.16429-1-stephen@networkplumber.org> <3d8938a4-acb8-45d0-291b-133ba0157976@amd.com> <75eef8f8-c0c0-1950-6149-756bd624e9d6@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 19 Jul 2023 11:03:36 +0100 Ferruh Yigit wrote: > On 7/19/2023 11:00 AM, Ferruh Yigit wrote: > > On 7/17/2023 8:15 PM, Stephen Hemminger wrote: =20 > >> The tap_bpf_program.c is not built as part of normal DPDK > >> EAL environment. It is intended to be built standalone > >> and does not use rte_common.h. > >> > >> This reverts the related change from > >> commit ef5baf3486e0 ("replace packed attributes") > >> > >> Note: this patch will cause expected warnings from checkpatch > >> because the code involved is not used directly in DPDK environment. > >> > >> Signed-off-by: Stephen Hemminger > >> =20 > >=20 > > Agree, this seems done by mistake as part of batch update, > >=20 > > Acked-by: Ferruh Yigit > >=20 > >=20 > > But I can't update the bpf file at all, if I am not missing something I= =20 >=20 > * I can't *compile* the bpf file ... >=20 > > am not sure if we should get just this update or have a patch/patchset > > that fixes the build. > >=20 > > @Ophir, how the bpf file is compiled? And did you test it recently? > >=20 > > I am using command from the documentation: > > `clang -O2 -emit-llvm -c tap_bpf_program.c -o - | llc -march=3Dbpf > > -filetype=3Dobj -o tap_bpf_program.o` It looks like this won't work because it was expecting to be able to find header files from older version of iproute2. These are not distributed, and the change to support libbpf in iproute2 makes the current versions not work. As a stopgap, will look back in history and see what version of header files will at least get a working build. =46rom there, need to replace how the conversion of .o to array works. Would prefer to use dlopen() to read the ELF file rather than expecting developers to hack together their own tools. Not sure how much effort is really needed here. This is only being used for the case of rte_flow with multiq RSS. Probably, no one ever used it.