From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C880B42EE1;
Sun, 23 Jul 2023 04:21:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A52AA40151;
Sun, 23 Jul 2023 04:21:56 +0200 (CEST)
Received: from mail-il1-f173.google.com (mail-il1-f173.google.com
[209.85.166.173])
by mails.dpdk.org (Postfix) with ESMTP id 96446400EF
for <dev@dpdk.org>; Sun, 23 Jul 2023 04:21:54 +0200 (CEST)
Received: by mail-il1-f173.google.com with SMTP id
e9e14a558f8ab-3476c902f2aso15448345ab.3
for <dev@dpdk.org>; Sat, 22 Jul 2023 19:21:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1690078913;
x=1690683713;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:from:to:cc:subject:date:message-id
:reply-to; bh=MpGfasnB9lODXBoTnmj2mnhvoKMn4cmUW/xsJ9z96Vg=;
b=Y3/ZeQzsAiG8ZTBfrdhvkc0OAhxDw8SIBjCOx0kicJmRgZmB5IzB8HFw4EaTxkmsXj
JzX/Vbb20pjmuFIFgx1PjT44mAU8ZOnSqY8rJ28LLVbAjNPg/FnE9J4l21qrzUGDrKK7
LBtRz1gWFlUrfXv/eX76RdwX4tQ4mUGbZbzhk88PzRGoahLGJTyVaB+NFQ3qKVQW/ex0
4srpUmsTvhlO2IOTkoQJQjGRRTrojXYZXGDUXap52rN9kwp1iBRF3CbFBaSa0V5I1gY3
uGZbLUYmS6jl0SHWICxecF4aWl/jZi3pcDiEMr0pILcDlWVH9hOFOFruLcDATC45KK9z
QaHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1690078913; x=1690683713;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=MpGfasnB9lODXBoTnmj2mnhvoKMn4cmUW/xsJ9z96Vg=;
b=f1iZj7r6yLTSrewyNJjy8WfeJE3VIRsiAcg/JRWMCCNDMH3hZE0NJ/XGDnvLXnpNv2
rZc0wlcy2xHcA77AhEUMaILq5hOfyq6ZalLfnlWL+OPSVr7qZ03/Xl4n/KbV43EGOL2l
9UKl5hMb6mUaBq9TH6NUwCyLnD289cX0U5T3tMigMtIn3XFaUKi7OQLWYKTWKKWmQY6M
vUM7m6K0E7jjOtFQLYx9ptuEioX6LzSADnLKO6VEKaO4lw/jmExUhTJvJba2awtTpf/6
JtSMUvyHuLO2FJsLQWFRfrZkJRUt7J9885VHtmpslgsFuxw7NPg8fp9KOBycBb/DJgJ8
wewQ==
X-Gm-Message-State: ABy/qLZhEj7OfP/mzM04MZ6WsDCTw2oVaf+7Xyw5KaJcj9kUKhsw2i1p
1AfOAzIQLff1ZpvRaECmeQdiaI8ZfxnoeMSFPXH8Iw==
X-Google-Smtp-Source: APBJJlGN2B5DcNnLG+xFZGuOLg2zf0VY6YkwdJgGZLFjG9YK5fxAwigD3onAaJkHWGGLA7ieyP155A==
X-Received: by 2002:a05:6e02:20ee:b0:345:d977:5057 with SMTP id
q14-20020a056e0220ee00b00345d9775057mr4826844ilv.4.1690078913493;
Sat, 22 Jul 2023 19:21:53 -0700 (PDT)
Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])
by smtp.gmail.com with ESMTPSA id
e4-20020a170902744400b001b8903d6773sm6004252plt.85.2023.07.22.19.21.52
for <dev@dpdk.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 22 Jul 2023 19:21:53 -0700 (PDT)
Date: Sat, 22 Jul 2023 19:21:51 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [PATCH v3] tap: fix build of TAP BPF program
Message-ID: <20230722192151.3e0781ca@hermes.local>
In-Reply-To: <20230720232549.63619-1-stephen@networkplumber.org>
References: <20230716212544.5625-1-stephen@networkplumber.org>
<20230720232549.63619-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, 20 Jul 2023 16:25:49 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Move the BPF program related code into a subdirectory.
> And add a Makefile for building it.
>
> The code was depending on old versions of headers from iproute2.
> Include those headers here so that build works.
>
> The standalone build was also broken because by
> commit ef5baf3486e0 ("replace packed attributes")
> which introduced __rte_packed into this code.
>
> Add a python program to extract the resulting BPF into
> a format that can be consumed by the TAP driver.
>
> Update the documentation.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Note: there are a couple of bogus checkpatch warnings from this.
The tap_bpf_program is not a regular DPDK library so it doesn't use
the DPDK macros. And the bpf_api.h and bpf_elf.h are from iproute2
upstream and won't conform to DPDK checkpatch requirements.