From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 56E4842F53;
Wed, 26 Jul 2023 18:31:33 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id F029940E25;
Wed, 26 Jul 2023 18:31:32 +0200 (CEST)
Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com
[209.85.210.181])
by mails.dpdk.org (Postfix) with ESMTP id CAF8440A79
for <dev@dpdk.org>; Wed, 26 Jul 2023 18:31:30 +0200 (CEST)
Received: by mail-pf1-f181.google.com with SMTP id
d2e1a72fcca58-686b91c2744so41803b3a.0
for <dev@dpdk.org>; Wed, 26 Jul 2023 09:31:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1690389089;
x=1690993889;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:from:to:cc:subject:date:message-id
:reply-to; bh=0UTPHLhZhdl0FVLZ01gLULyKuS8fz2pRUKo61BuEx/U=;
b=PpkiyKKT1NcK1DZkHJx7lAq+JORLgDXq6ZWKgzDK/X/257sGeeH+8ZdN6NJQFayr5F
gvbpbi7Rzh6Yuy3nlqFokIhM+JLpxvjmDHrH9GR3GKX/iHyqK79IrTL21k9VyAsQxJy9
zHVY3cPxeKC5n4WveNz790IXxBAddqJG8PW0hqKEx1LRw1g9QRVoKt3xS6w0zm3GGTkt
JpmYxTRG/Sqmk8RFyeFj68bu0JIZmvGJxeXfONhob3uDC7PaDfCtxPrnoOsRJR94AEmN
0c8fG7FKlQYKmSX81OCJZIAqvyGd8HE3E6l6S+1iVUVifuCMrdxM07yylZazH4RCprMY
9tXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1690389089; x=1690993889;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=0UTPHLhZhdl0FVLZ01gLULyKuS8fz2pRUKo61BuEx/U=;
b=HVzSU7tYnkcnLL1f+bzRQ+cE0v53xsH2NkJDCyPxbspNclaIEd6G2fbWS48Znhqw5+
mSZIwN9vTfi010wE8ZCQ1icJsbHxmpWDjmpzNpYL6IQhe/70ViIVnXOEirqDUwVOp+V9
1f8WZ+tdeJ4Cn17Gn4BTn3ZeD4B+idB8Zro5L1t8RoVCV/FyzowFdbh5YOvYhUFjQfP6
95HFjm99u8aSDkCa5AKIBBibNE4Xv8FhwE1/kiupRfJ5Diy00CTFoy2NE3ReSvc3IQDB
lNMcCaXo2Eb2SZqVqysYDxyD3Ywob65IGzLI8SJlDyljxWNthK1WwHWiZOtRjQzz6Pjj
G94A==
X-Gm-Message-State: ABy/qLa/srwLXFcPJQ1cSW/cBb2g0HR7lxD2+hT2wfF1soIlou0iCaTa
D/Q05BXlwHeYUrYpRI3jSm51oOxuzG38AnRx2WG53Q==
X-Google-Smtp-Source: APBJJlHB551NJiwoQZcIlO06/yQziVwiB91/9afSBOSFt5oPMYO79izWbTsfaU2ePFTbAiRinsmOCA==
X-Received: by 2002:a05:6300:8089:b0:134:40f0:5d04 with SMTP id
ap9-20020a056300808900b0013440f05d04mr2365269pzc.13.1690389089529;
Wed, 26 Jul 2023 09:31:29 -0700 (PDT)
Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])
by smtp.gmail.com with ESMTPSA id
d5-20020aa78685000000b00686edbc3d90sm241396pfo.127.2023.07.26.09.31.29
for <dev@dpdk.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 26 Jul 2023 09:31:29 -0700 (PDT)
Date: Wed, 26 Jul 2023 09:31:27 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [PATCH v3] tap: fix build of TAP BPF program
Message-ID: <20230726093127.553ddb65@hermes.local>
In-Reply-To: <20230720232549.63619-1-stephen@networkplumber.org>
References: <20230716212544.5625-1-stephen@networkplumber.org>
<20230720232549.63619-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, 20 Jul 2023 16:25:49 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Move the BPF program related code into a subdirectory.
> And add a Makefile for building it.
>
> The code was depending on old versions of headers from iproute2.
> Include those headers here so that build works.
>
> The standalone build was also broken because by
> commit ef5baf3486e0 ("replace packed attributes")
> which introduced __rte_packed into this code.
>
> Add a python program to extract the resulting BPF into
> a format that can be consumed by the TAP driver.
>
> Update the documentation.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Some backstory notes:
0. No longer work for Microsoft, so don't have Azure/Failsafe/TAP setup.
Therefore compile tested only.
1. Went down this rabbit hole while trying to clear some of the DPDK
patch backlog, and ran into this one fix for RSS on fragmented packets
https://patchwork.dpdk.org/project/dpdk/patch/20220420112400.2271-1-madhuker.mythri@oracle.com/
2. This version of patch only makes the BPF program build.
It does not change the BPF program used currently by TAP device.
3. Doing build will change the bpf program since clang is probably
optimizing more now.
Bottom line:
Merging the patch won't fix the RSS bug, it won't change the current TAP
device behavior (same BPF). But it will allow for easier later fix in next release.