From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18C9042FB4; Wed, 2 Aug 2023 06:16:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1423410DC; Wed, 2 Aug 2023 06:16:21 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 9973C40DDB for ; Wed, 2 Aug 2023 06:16:19 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-686ed1d2594so6035308b3a.2 for ; Tue, 01 Aug 2023 21:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1690949778; x=1691554578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jwbi9Jrju0YaLksOqXF5gMLPPVhOfsZoSA/WueqAVIg=; b=AHoFoEXqj9nNgvlqeZ8u/RXsrv+NmcKtNBEIcppD/znpcLgL0KgQgnMTScOlBdDncW gpPKKwr467qy7GTPe1p6PddpXMKb49cWpdj5fgy3sSTdxlJk7GJaTND/0CdWUSX+FzpP 0rw/6FP3jTVYkM0nB19CTE053MgzmIf5uV9qxdcOsTKOn+Z08a5XVeM8WyIOAgMfcaGS d6/TTTIoL8HLhzMoQSzkJpy/b0dwiQycjnwewQVuzwnHlGPvLOf3+bkyGc7d44E3qS2T +U6eBYEGdO28CIa9lNzlTbHl4BtRa1rMASbbKb316DP0h2ygFO9r82dRlq/YN2XRjI7u DGBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690949778; x=1691554578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jwbi9Jrju0YaLksOqXF5gMLPPVhOfsZoSA/WueqAVIg=; b=FxTUoIqW3f78nVYqfaQaiZwa3fK9F3VUKA3CWJfiSDOO+V6pIZdiV928H3gJFHa79n ZgqxAA8d6MRX6u3VNAAD0XzQlzib2uFNIgHeNaF5z0tka5za1UPJTA1UKSMMWS3s1YYg BOLpbBY4UdwWyKdyCWsgkjrvLUI8F4z6U3uo4K0ik3DfPgwm4V78k3wjgj3M+y38n+BB ZojbSmOcoGeGreF/FQQH97wvhq6qe09qorCybzPX0tkzQmtYBsUQAe9jbLdD2pYTRcwN seGBexoX3pBDPpBeIbibgcO7bYQZFXEXnua5WGzkrydSIp88Guoxu/plbdD1jm3BR8A6 2ByQ== X-Gm-Message-State: ABy/qLaCOOzhEu1TqDplpCxqJloN29bC7OqiSEfTrT37ZtTQWw/oaCe0 hYNnT65S6nlPArLbBJTVE20sQQ== X-Google-Smtp-Source: APBJJlFUH4dcXClbw+26hQZEjzto8IvmoB9SE2oQBDITwl3FClu57YFSNWz1WOzkeima6fTbYCNLOg== X-Received: by 2002:a05:6a21:4889:b0:135:6ef6:171 with SMTP id av9-20020a056a21488900b001356ef60171mr14393308pzc.39.1690949778438; Tue, 01 Aug 2023 21:16:18 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id i5-20020aa787c5000000b00682936d04ccsm10001495pfo.180.2023.08.01.21.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 21:16:18 -0700 (PDT) Date: Tue, 1 Aug 2023 21:16:15 -0700 From: Stephen Hemminger To: huangdengdui Cc: , , , , , Subject: Re: [PATCH] app/testpmd: add flush multicast MAC address command Message-ID: <20230801211615.6018eae4@hermes.local> In-Reply-To: References: <20230801024304.2187484-1-huangdengdui@huawei.com> <20230801081821.0fcbf4d1@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 2 Aug 2023 10:41:46 +0800 huangdengdui wrote: > =E5=9C=A8 2023/8/1 23:18, Stephen Hemminger =E5=86=99=E9=81=93: > > On Tue, 1 Aug 2023 10:43:04 +0800 > > Dengdui Huang wrote: > > =20 > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > >> index 0d0723f659..2d9d925776 100644 > >> --- a/app/test-pmd/cmdline.c > >> +++ b/app/test-pmd/cmdline.c > >> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_resu= lt, > >> "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n" > >> " Remove a MAC address from port_id.\n\n" > >> =20 > >> + "mcast_addr flush (port_id)\n" > >> + " To flush the set of multicast addresses.\n\n" > >> + > >> "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n" > >> " Set the default MAC address for port_id.\n\n" =20 > >=20 > > Why out this in middle of the mac_addr commands? better to be in logica= l or alpha order. =20 > Sorry Stephen, I made a mistake in my reply. It's already in logical orde= r(mac_addr/mcast_addr add/remove---->other setting), the same order as in t= he doc. > The order looks odd because the help command doesn't have a description o= f "multicast add/remove".Do you agree with this explanation? The help is already a bit of a mess. It really needs to be split up more. Lets add the new line after "set allmulti"?