From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3004C42FBA; Thu, 3 Aug 2023 00:29:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03AD0406BA; Thu, 3 Aug 2023 00:29:04 +0200 (CEST) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mails.dpdk.org (Postfix) with ESMTP id 9A69A406B8 for <dev@dpdk.org>; Thu, 3 Aug 2023 00:29:02 +0200 (CEST) Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so4526001fa.2 for <dev@dpdk.org>; Wed, 02 Aug 2023 15:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691015342; x=1691620142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=veFQyFv89sCIRordf46wPRGg33uDN6GOlyQCpFO/3Zw=; b=DZ8BFOTQC8Nmyrwi7c8KR1Vl6fv6Zc3CWnhHn2nC8jFp5EJI6ZQYcOtWBvxAiqL1Yl Hu3Fos8NapnGmJ2Oh3tHTBNa14Y25hThmdvYyC1m3G9BmPCO2WNdL8L7303SW5YiFXst XaGTK7BVJi0Y7wk1LhMJeUrJj15+WVWDVtMAP9FmUMfRs7uL+/IbXt+nZAFl/mK7IWQp uB1CBlIAOONIWN31Zf4CiTnwPYRlPZzotZcB+AfMyEjUR7WQmC4aiYR1gIIEougF3KiO VBoxYFlDaLGo7YtmX4TzuIkwJknXa4JWVt+EP0AppzWtyNsVPTOB2rxJKdikPcTvd6f8 RbLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691015342; x=1691620142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=veFQyFv89sCIRordf46wPRGg33uDN6GOlyQCpFO/3Zw=; b=ZRHwwuFQY5m0fA0MzdrOtGl5RdPF57PJcWtQGk7LmygIaTG6rtsQgousCCU3Iqfu1T 4CBLbxC/9xqGL2WtcHG0zsOYyjnM7wTBBoO0VpkzoG8BrV22zAYqhockqMzleoXWnxXu xYTgeOtGSil44nDZCKHCJ/rPgY5KJIZS5G7ame29sOVyrV2iPSwF221smuL6ABNVRDlU f68JUuRVt4mUi910KXnVWaYcTPMfNOExivQ8TQQc0N7vV37ew7t6SjD2uReTfOh/VW9v 2emHCAC89OoFiT7Ck5L/LTY4V8rtijRQ7dihiSU9Bu47JfqIRWV8ZTbe44or28vInIu2 /3Dg== X-Gm-Message-State: ABy/qLaS7UxoyVsK4kG3kSELRpJZo1vM7QvodyKiehPXOoTwLgLdVWUy XhsaMyqqpq7RTsunfwoyAtA= X-Google-Smtp-Source: APBJJlHPMvViLjMPz6OBpYnqk4LfjAGMC1729W0Cjkm/NRM2ZhaXh8i0NbcW4t0TAQcdt4YplSUA9g== X-Received: by 2002:a2e:980c:0:b0:2b9:b41a:aa66 with SMTP id a12-20020a2e980c000000b002b9b41aaa66mr6739124ljj.20.1691015341781; Wed, 02 Aug 2023 15:29:01 -0700 (PDT) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id a3-20020a2e8303000000b002b9fdfdab75sm633463ljh.12.2023.08.02.15.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 15:29:01 -0700 (PDT) Date: Thu, 3 Aug 2023 01:29:00 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: dev@dpdk.org, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com> Subject: Re: [PATCH] eal/windows: resolve conversion and truncation warnings Message-ID: <20230803012900.57b9cb78@sovereign> In-Reply-To: <1691009302-32551-1-git-send-email-roretzla@linux.microsoft.com> References: <1691009302-32551-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 2023-08-02 13:48 (UTC-0700), Tyler Retzlaff: > * Initialize const int NS_PER_SEC with an integer literal instead of > double thereby avoiding implicit conversion from double to int. > > * Cast the result of the expression assigned to timspec.tv_nsec to long. Typo: "timespec". > Windows builds generate integer truncation warning for this assignment > since the result of the expression was 8 bytes (LONGLONG) but > on Windows targets is 4 bytes. Probably "but **tv_nsec** on Windows targets is 4 bytes". > The value produced for the expression should safely fit in the long. > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > --- > lib/eal/windows/include/rte_os_shim.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>