From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D17024302C; Thu, 10 Aug 2023 19:03:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A63342D12; Thu, 10 Aug 2023 19:03:03 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 37A5340691 for <dev@dpdk.org>; Thu, 10 Aug 2023 19:03:02 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-686efb9ee0cso1007776b3a.3 for <dev@dpdk.org>; Thu, 10 Aug 2023 10:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691686981; x=1692291781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=soBExZD6Ta/2Z9fa44ZCkbWIqQkRG/rk3nqmmrIoRR0=; b=XRc56m82KzBBpmJddnx9ETMZZuYuIg+6ooUFENtigzCA6Lhenaabipn3SIlY1VhsYN wt++e7PpTnv4X09enjHvTqTMQ+tcbSBu8/4iUlGezx57lWbdUz7XuTSTWFMaMI3zqlbM sZq0fjgyh3zp4a0YWwBYv0PPCVGj9eGo2pNMQbi6SyiMQ6VQbEY4Etvh0UeaOcEXqIy/ m7Fi4vi03soZE4zWUr7kcIL2irmAbiu/drbxsEhle3zA1YTvczQSEMIYiZs7lOP0MkJb GsA2QheH0kJ+FxzLLNeB6YP4BjK8K1RM/fNRKIzuoTy5w3siodzN4kRcmyh01EIB8KkL wVJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691686981; x=1692291781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=soBExZD6Ta/2Z9fa44ZCkbWIqQkRG/rk3nqmmrIoRR0=; b=Gnl34h73uf9PRgZN20zLWRq3Opy2+eGGgSJWw7UMO7H9cjj1XxBc8yi6K3Y2z6KJ5f /D71k1xu5BK1tCV2hJ/k22ys1vjvbsNy01/zlVLXhDCY5Qg/HX4FJfNkQod1BXR8ZxMn UwErGvaKnh+eN8n8GV6aNvltrwDZljTUaFe1XGajglsSUZujI6lFCfh8nzKlc4FDU/Zd fmYTzQY49sCYMPx051j3f8htfkEUXdUhlznQS0ISPYj55DXcrBaG3BG/qhGEC0nXS+2C KqcWNlpSk+jQ4Cd2G999aaLa+CRTZP0HUiN6WzP5taL/J2yA8OXk/EkraH3WbrqVjetw NEXg== X-Gm-Message-State: AOJu0Yw5apdDMjeWbKSNAg7AP+SEuc8GBhlAg0+ly7yXCu/shsF40Sh6 fKQY2zBnqKicAcwgIjuIWG3peg== X-Google-Smtp-Source: AGHT+IEvYR/NF9vwWi9ZpP6WfY2MoGoBje8UlX9mBRKCvv+CLXrBSHOyYlVXPx6mjI/HAI6/L9GEWg== X-Received: by 2002:a05:6a00:2d86:b0:686:bbfa:68e3 with SMTP id fb6-20020a056a002d8600b00686bbfa68e3mr3872486pfb.15.1691686980685; Thu, 10 Aug 2023 10:03:00 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id n5-20020aa78a45000000b0068675835e10sm1756208pfa.44.2023.08.10.10.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 10:03:00 -0700 (PDT) Date: Thu, 10 Aug 2023 10:02:58 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Thomas Monjalon <thomas@monjalon.net> Cc: Bruce Richardson <bruce.richardson@intel.com>, David Marchand <david.marchand@redhat.com>, dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Ali Alnubani <alialnu@nvidia.com>, galco@nvidia.com Subject: Re: [PATCH v5] build: update DPDK to use C11 standard Message-ID: <20230810100258.0a38bdb9@hermes.local> In-Reply-To: <60418966.matp6XCIr4@thomas> References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230810074839.446f655d@hermes.local> <ZNUR5fN9ImIDispI@bricha3-MOBL.ger.corp.intel.com> <60418966.matp6XCIr4@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 10 Aug 2023 18:49:09 +0200 Thomas Monjalon <thomas@monjalon.net> wrote: > 10/08/2023 18:35, Bruce Richardson: > > On Thu, Aug 10, 2023 at 07:48:39AM -0700, Stephen Hemminger wrote: =20 > > > On Thu, 10 Aug 2023 15:34:43 +0200 > > > Thomas Monjalon <thomas@monjalon.net> wrote: > > > =20 > > > > 03/08/2023 15:36, David Marchand: =20 > > > > > On Wed, Aug 2, 2023 at 2:32=E2=80=AFPM Bruce Richardson > > > > > <bruce.richardson@intel.com> wrote: =20 > > > > > > > > > > > > As previously announced, DPDK 23.11 will require a C11 supporti= ng > > > > > > compiler and will use the C11 standard in all builds. > > > > > > > > > > > > Forcing use of the C standard, rather than the standard with > > > > > > GNU extensions, means that some posix definitions which are not= in > > > > > > the C standard are unavailable by default. We fix this by ensur= ing > > > > > > the correct defines or cflags are passed to the components that > > > > > > need them. > > > > > > > > > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > > > > > Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> > > > > > > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com> =20 > > > > > Tested-by: Ali Alnubani <alialnu@nvidia.com> > > > > >=20 > > > > > The CI results look good. > > > > >=20 > > > > > Applied, thanks! =20 > > > >=20 > > > > The compiler support is updated, that's fine. > > > > Should we go further and document some major Linux distributions? > > > > One concern is to make clear RHEL 7 is not supported anymore. > > > > Should it be a release note? > > > > =20 > >=20 > > Well, DPDK currently is still building fine on Centos 7 for me, so let's > > hold off on claiming anything until it's definitely broken. > > =20 > > > > =20 > > >=20 > > > Should be addressed in linux/sys_reqs.rst as well as deprecation noti= ce. > > > Also, is it possible to add automated check in build for compiler ver= sion? =20 > >=20 > > I'd be a little careful about what we claim, and I think current docs a= re > > accurate vs our original plans. What we didn't plan to support was the = GCC > > and Clang compiler versions in RHEL 7, but if one installs an updated G= CC, > > for example, the build should be fine on RHEL 7. > >=20 > > Now, though, we are having to re-evaluate our use of stdatomics, which > > means we may not actually break RHEL 7 compatibility after all. We'll h= ave > > to "watch this space" as the saying goes! > >=20 > > Overall, I think the approach of build-time checks is the best, but not > > for specific versions, but instead for capabilities. If/when we add sup= port > > for stdatomics to DPDK builds on Linux/BSD, at that point we put in the > > initial compiler checks a suitable check for them being present and out= put > > a suitable error if not found. =20 >=20 > OK looks good Note: RHEL 7 official end of maintenance support is not until June 2024.