From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5056243035; Fri, 11 Aug 2023 17:56:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AC2542D3F; Fri, 11 Aug 2023 17:56:40 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id AA89240E03; Fri, 11 Aug 2023 17:56:38 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0B70720FD0C5; Fri, 11 Aug 2023 08:56:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0B70720FD0C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1691769398; bh=NCtR4OMzSHiHtwjzh6+penrNLOky1M+75Iq8CEauVBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+aZO1fgR//Kf9ipMlAsnMUxzK4p5feEqDADg3kA7JEHnXjRqtfdi/Eo7qVYpwb4H 7Rq7vR+Xn9nn9w/kfDtXYGgbgEaQ007icvcVHO10dzybbI0k+MZfWsyPvvLIaWUdRI yNi6Kzdj2IiqLtnSYkV/GXmvoNiLBEjWtlfnUxcI= Date: Fri, 11 Aug 2023 08:56:38 -0700 From: Tyler Retzlaff To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, techboard@dpdk.org, Bruce Richardson , Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Joyce Kong , David Christensen , Konstantin Ananyev , David Hunt , Thomas Monjalon , David Marchand Subject: Re: [PATCH 6/6] devtools: forbid new direct use of GCC atomic builtins Message-ID: <20230811155637.GC20040@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1691717521-1025-7-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87AE9@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87AE9@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 11, 2023 at 11:51:17AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Friday, 11 August 2023 03.32 > > > > Refrain from using compiler __atomic_xxx builtins DPDK now requires > > the use of rte_atomic__explicit macros when operating on DPDK > > atomic variables. > > > > Signed-off-by: Tyler Retzlaff > > Acked-by: Morten Brørup > > The Acked-by should have been: > Suggested-by: Morten Brørup ooh, did i make a mistake? i was carrying the ack from my abandoned series (or i thought you had acked this patch on that series sorry). i'll change it to suggested-by. thanks! > > > --- > > devtools/checkpatches.sh | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > index 43f5e36..a32f02e 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > @@ -102,6 +102,14 @@ check_forbidden_additions() { # > > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk > > \ > > "$1" || res=1 > > > > + # refrain from using compiler __atomic_xxx builtins > > + awk -v FOLDERS="lib drivers app examples" \ > > + -v EXPRESSIONS="__atomic_.*\\\(" \ > > This expression is a superset of other expressions in checkpatches (search for "__atomic" in the checkpatches, and you'll find them). Perhaps they can be removed? yes, seems like a good idea. v2 > > > + -v RET_ON_FAIL=1 \ > > + -v MESSAGE='Using __atomic_xxx builtins' \ > > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk > > \ > > + "$1" || res=1 > > + > > # refrain from using compiler __atomic_thread_fence() > > # It should be avoided on x86 for SMP case. > > awk -v FOLDERS="lib drivers app examples" \ > > -- > > 1.8.3.1 >