* [PATCH] build: move AVX512 check to x86 config
@ 2023-08-11 13:10 David Marchand
2023-08-11 13:38 ` Bruce Richardson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Marchand @ 2023-08-11 13:10 UTC (permalink / raw)
To: dev; +Cc: roretzla, Bruce Richardson, Konstantin Ananyev
The AVX512 check only matters to x86 compilation with gcc.
Move it where appropriate.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
buildtools/meson.build | 3 ---
{buildtools => config/x86}/binutils-avx512-check.py | 0
config/x86/meson.build | 3 +++
3 files changed, 3 insertions(+), 3 deletions(-)
rename {buildtools => config/x86}/binutils-avx512-check.py (100%)
diff --git a/buildtools/meson.build b/buildtools/meson.build
index e1c600e40f..266e727706 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -4,7 +4,6 @@
pkgconf = find_program('pkg-config', 'pkgconf', required: false)
check_symbols = find_program('check-symbols.sh')
ldflags_ibverbs_static = find_program('options-ibverbs-static.sh')
-objdump = find_program('objdump', 'llvm-objdump')
python3 = import('python').find_installation(required: false)
if python3.found()
@@ -18,8 +17,6 @@ map_to_win_cmd = py3 + files('map_to_win.py')
sphinx_wrapper = py3 + files('call-sphinx-build.py')
get_cpu_count_cmd = py3 + files('get-cpu-count.py')
get_numa_count_cmd = py3 + files('get-numa-count.py')
-binutils_avx512_check = (py3 + files('binutils-avx512-check.py') +
- [objdump] + cc.cmd_array())
# select library and object file format
pmdinfo = py3 + files('gen-pmdinfo-cfile.py') + [meson.current_build_dir()]
diff --git a/buildtools/binutils-avx512-check.py b/config/x86/binutils-avx512-check.py
similarity index 100%
rename from buildtools/binutils-avx512-check.py
rename to config/x86/binutils-avx512-check.py
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 54345c4da3..b2315c051f 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -4,6 +4,9 @@
# get binutils version for the workaround of Bug 97
binutils_ok = true
if is_linux or cc.get_id() == 'gcc'
+ objdump = find_program('objdump', 'llvm-objdump')
+ binutils_avx512_check = (py3 + files('binutils-avx512-check.py') +
+ [objdump] + cc.cmd_array())
binutils_ok = run_command(binutils_avx512_check, check: false).returncode() == 0
if not binutils_ok and cc.has_argument('-mno-avx512f')
machine_args += '-mno-avx512f'
--
2.41.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: move AVX512 check to x86 config
2023-08-11 13:10 [PATCH] build: move AVX512 check to x86 config David Marchand
@ 2023-08-11 13:38 ` Bruce Richardson
2023-08-11 15:58 ` Tyler Retzlaff
2023-08-25 8:39 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-08-11 13:38 UTC (permalink / raw)
To: David Marchand; +Cc: dev, roretzla, Konstantin Ananyev
On Fri, Aug 11, 2023 at 03:10:24PM +0200, David Marchand wrote:
> The AVX512 check only matters to x86 compilation with gcc.
> Move it where appropriate.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: move AVX512 check to x86 config
2023-08-11 13:10 [PATCH] build: move AVX512 check to x86 config David Marchand
2023-08-11 13:38 ` Bruce Richardson
@ 2023-08-11 15:58 ` Tyler Retzlaff
2023-08-25 8:39 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: Tyler Retzlaff @ 2023-08-11 15:58 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Bruce Richardson, Konstantin Ananyev
On Fri, Aug 11, 2023 at 03:10:24PM +0200, David Marchand wrote:
> The AVX512 check only matters to x86 compilation with gcc.
> Move it where appropriate.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: move AVX512 check to x86 config
2023-08-11 13:10 [PATCH] build: move AVX512 check to x86 config David Marchand
2023-08-11 13:38 ` Bruce Richardson
2023-08-11 15:58 ` Tyler Retzlaff
@ 2023-08-25 8:39 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-08-25 8:39 UTC (permalink / raw)
To: David Marchand; +Cc: dev, roretzla, Bruce Richardson, Konstantin Ananyev
On Fri, Aug 11, 2023 at 3:10 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> The AVX512 check only matters to x86 compilation with gcc.
> Move it where appropriate.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-25 8:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 13:10 [PATCH] build: move AVX512 check to x86 config David Marchand
2023-08-11 13:38 ` Bruce Richardson
2023-08-11 15:58 ` Tyler Retzlaff
2023-08-25 8:39 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).