DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] build: move enabled applications list declaration
@ 2023-08-11 13:28 David Marchand
  2023-08-11 13:40 ` Bruce Richardson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Marchand @ 2023-08-11 13:28 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

No functional impact foreseen. Simply move this variable and rename it
for consistency with other similar variables.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/meson.build | 4 +---
 meson.build     | 3 ++-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/meson.build b/app/meson.build
index 4fc1a83eba..0c2e7e4c00 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -38,8 +38,6 @@ if get_option('default_library') == 'static' and not is_windows
     default_ldflags += ['-Wl,--export-dynamic']
 endif
 
-enabled_apps = [] # used to print summary at the end
-
 foreach app:apps
     name = app
     build = true
@@ -90,7 +88,7 @@ foreach app:apps
         continue
     endif
 
-    enabled_apps += app
+    dpdk_apps_enabled += app
     link_libs = []
     if get_option('default_library') == 'static'
         link_libs = dpdk_static_libraries + dpdk_drivers
diff --git a/meson.build b/meson.build
index 70b54f0c98..2e6e546d20 100644
--- a/meson.build
+++ b/meson.build
@@ -44,6 +44,7 @@ dpdk_drivers = []
 dpdk_extra_ldflags = []
 dpdk_libs_deprecated = []
 dpdk_apps_disabled = []
+dpdk_apps_enabled = []
 dpdk_libs_disabled = []
 dpdk_libs_enabled = []
 dpdk_drvs_disabled = []
@@ -123,7 +124,7 @@ endif
 output_message = '\n=================\nApplications Enabled\n=================\n'
 output_message += '\napps:\n\t'
 output_count = 0
-foreach app:enabled_apps
+foreach app:dpdk_apps_enabled
     output_message += app + ', '
     output_count += 1
     if output_count == 8
-- 
2.41.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] build: move enabled applications list declaration
  2023-08-11 13:28 [PATCH] build: move enabled applications list declaration David Marchand
@ 2023-08-11 13:40 ` Bruce Richardson
  2023-08-11 15:59 ` Tyler Retzlaff
  2023-08-25  8:39 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-08-11 13:40 UTC (permalink / raw)
  To: David Marchand; +Cc: dev

On Fri, Aug 11, 2023 at 03:28:05PM +0200, David Marchand wrote:
> No functional impact foreseen. Simply move this variable and rename it
> for consistency with other similar variables.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] build: move enabled applications list declaration
  2023-08-11 13:28 [PATCH] build: move enabled applications list declaration David Marchand
  2023-08-11 13:40 ` Bruce Richardson
@ 2023-08-11 15:59 ` Tyler Retzlaff
  2023-08-25  8:39 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Tyler Retzlaff @ 2023-08-11 15:59 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Bruce Richardson

On Fri, Aug 11, 2023 at 03:28:05PM +0200, David Marchand wrote:
> No functional impact foreseen. Simply move this variable and rename it
> for consistency with other similar variables.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] build: move enabled applications list declaration
  2023-08-11 13:28 [PATCH] build: move enabled applications list declaration David Marchand
  2023-08-11 13:40 ` Bruce Richardson
  2023-08-11 15:59 ` Tyler Retzlaff
@ 2023-08-25  8:39 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-08-25  8:39 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Bruce Richardson, Tyler Retzlaff

On Fri, Aug 11, 2023 at 3:28 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> No functional impact foreseen. Simply move this variable and rename it
> for consistency with other similar variables.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-25  8:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 13:28 [PATCH] build: move enabled applications list declaration David Marchand
2023-08-11 13:40 ` Bruce Richardson
2023-08-11 15:59 ` Tyler Retzlaff
2023-08-25  8:39 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).