DPDK patches and discussions
 help / color / mirror / Atom feed
From: okaya@kernel.org
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Sinan Kaya <okaya@kernel.org>
Subject: [PATCH v1 5/7] eal_memory: skip initialization
Date: Mon, 14 Aug 2023 21:38:24 -0400	[thread overview]
Message-ID: <20230815013826.1288972-6-okaya@kernel.org> (raw)
In-Reply-To: <20230815013826.1288972-1-okaya@kernel.org>

From: Sinan Kaya <okaya@kernel.org>

Initialize heap area just once.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 lib/eal/common/eal_common_memory.c | 5 +++++
 lib/eal/common/malloc_heap.c       | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index 688dc615d7..e342eeb806 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -1084,10 +1084,14 @@ rte_eal_memory_init(void)
 
 	int retval;
 	RTE_LOG(DEBUG, EAL, "Setting up physically contiguous memory...\n");
+	static int initialized = 0;
 
 	if (!mcfg)
 		return -1;
 
+	if (initialized)
+		return 0;
+
 	/* lock mem hotplug here, to prevent races while we init */
 	rte_mcfg_mem_read_lock();
 
@@ -1106,6 +1110,7 @@ rte_eal_memory_init(void)
 	if (internal_conf->no_shconf == 0 && rte_eal_memdevice_init() < 0)
 		goto fail;
 
+	initialized = true;
 	return 0;
 fail:
 	rte_mcfg_mem_read_unlock();
diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c
index 6eb6fcda5e..4c5f8aed0b 100644
--- a/lib/eal/common/malloc_heap.c
+++ b/lib/eal/common/malloc_heap.c
@@ -1405,6 +1405,10 @@ rte_eal_malloc_heap_init(void)
 	unsigned int i;
 	const struct internal_config *internal_conf =
 		eal_get_internal_configuration();
+	static int initialized = 0;
+
+	if (initialized)
+		return 0;
 
 	if (internal_conf->match_allocations)
 		RTE_LOG(DEBUG, EAL, "Hugepages will be freed exactly as allocated.\n");
@@ -1443,6 +1447,8 @@ rte_eal_malloc_heap_init(void)
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
 		return 0;
 
+	initialized = true;
+
 	/* add all IOVA-contiguous areas to the heap */
 	return rte_memseg_contig_walk(malloc_add_seg, NULL);
 }
-- 
2.25.1


  parent reply	other threads:[~2023-08-15  1:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15  1:38 [PATCH v1 0/7] support reinit flow okaya
2023-08-15  1:38 ` [PATCH v1 1/7] eal: fixes for re-initialization issues okaya
2023-08-15  2:21   ` Stephen Hemminger
2023-08-15  2:24   ` Stephen Hemminger
2023-08-15  1:38 ` [PATCH v1 2/7] tailq: skip init if already initialized okaya
2023-08-15  2:22   ` Stephen Hemminger
2023-08-15  1:38 ` [PATCH v1 3/7] eal_memzone: bail out on initialized okaya
2023-08-15  2:22   ` Stephen Hemminger
2023-08-15  1:38 ` [PATCH v1 4/7] memseg: init once okaya
2023-08-15  1:38 ` okaya [this message]
2023-08-15  1:38 ` [PATCH v1 6/7] eal_interrupts: don't reinitialize threads okaya
2023-08-15  2:20   ` Stephen Hemminger
2023-08-15  1:38 ` [PATCH v1 7/7] eal: initialize worker threads once okaya
2023-08-15  2:24   ` Stephen Hemminger
2023-08-15  2:12 ` [PATCH v1 0/7] support reinit flow Stephen Hemminger
2023-08-15  3:12   ` Sinan Kaya
2023-08-15 21:49 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815013826.1288972-6-okaya@kernel.org \
    --to=okaya@kernel.org \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).