From: Stephen Hemminger <stephen@networkplumber.org>
To: okaya@kernel.org
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 8/8] eal: initialize worker threads once
Date: Tue, 15 Aug 2023 10:46:35 -0700 [thread overview]
Message-ID: <20230815104635.143aaf61@hermes.local> (raw)
In-Reply-To: <20230815145023.1386003-9-okaya@kernel.org>
On Tue, 15 Aug 2023 10:50:23 -0400
okaya@kernel.org wrote:
> From: Sinan Kaya <okaya@kernel.org>
>
> Initialize worker threads once and keep a flag
> for other init calls.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> lib/eal/linux/eal.c | 60 ++++++++++++++++++++++++---------------------
> 1 file changed, 32 insertions(+), 28 deletions(-)
>
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 584c78e640..1305e1df54 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -80,6 +80,7 @@ int rte_cycles_vmware_tsc_map;
>
>
> static uint32_t run_once;
> +static bool worker_initialized;
>
I see a pattern here. Many places are using static to
only initialize once. Could you name these variables the
same; suggest using run_once everywhere.
next prev parent reply other threads:[~2023-08-15 17:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 14:50 [PATCH v4 0/8] support reinit flow okaya
2023-08-15 14:50 ` [PATCH v4 1/8] eal: cleanup plugins data okaya
2023-08-15 14:50 ` [PATCH v4 2/8] eal: fixes for re-initialization issues okaya
2023-08-15 17:49 ` Stephen Hemminger
2023-08-15 18:35 ` Sinan Kaya
2023-08-15 14:50 ` [PATCH v4 3/8] tailq: skip init if already initialized okaya
2023-08-15 14:50 ` [PATCH v4 4/8] eal_memzone: bail out on initialized okaya
2023-08-15 14:50 ` [PATCH v4 5/8] memseg: init once okaya
2023-08-15 14:50 ` [PATCH v4 6/8] eal_memory: skip initialization okaya
2023-08-15 14:50 ` [PATCH v4 7/8] eal_interrupts: don't reinitialize threads okaya
2023-08-15 17:47 ` Stephen Hemminger
2023-08-15 14:50 ` [PATCH v4 8/8] eal: initialize worker threads once okaya
2023-08-15 17:46 ` Stephen Hemminger [this message]
2023-08-15 18:43 ` Sinan Kaya
2023-08-15 17:45 ` [PATCH v4 0/8] support reinit flow Stephen Hemminger
2023-08-15 18:58 ` Sinan Kaya
2023-08-15 19:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815104635.143aaf61@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).