From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH v4 1/2] devtools: add check on symbol maps format
Date: Wed, 16 Aug 2023 09:16:02 +0200 [thread overview]
Message-ID: <20230816071603.1002271-1-david.marchand@redhat.com> (raw)
In-Reply-To: <20230811154944.2947783-1-david.marchand@redhat.com>
Add a check on symbol maps format (fixing ethdev at the same time).
This will be required by a next commit.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changes since v3:
- fixed Alpine build (same issue with { in awk expression than commit
e1ab26df4862 ("buildtools: fix build with busybox")),
Changes since v2:
- fixed FreeBSD build by replacing (|pattern) with (pattern)?,
Changes since v1:
- moved this check in a separate patch,
- fixed ethdev map file,
---
devtools/check-symbol-maps.sh | 21 +++++++++++++++++++++
lib/ethdev/version.map | 30 ++++++++++++++----------------
2 files changed, 35 insertions(+), 16 deletions(-)
diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
index 8c116bfa9c..9913393ced 100755
--- a/devtools/check-symbol-maps.sh
+++ b/devtools/check-symbol-maps.sh
@@ -74,4 +74,25 @@ if [ -n "$empty_maps" ] ; then
ret=1
fi
+find_bad_format_maps ()
+{
+ for map in $@ ; do
+ cat $map | awk '
+ /^(DPDK_[0-9]*|EXPERIMENTAL|INTERNAL) \{$/ { next; } # start of a section
+ /^};$/ { next; } # end of a section
+ /^$/ { next; } # empty line
+ /^\t(global:|local: \*;)$/ { next; } # qualifiers
+ /^\t[a-zA-Z_0-9]*;( # WINDOWS_NO_EXPORT)?$/ { next; } # symbols
+ /^\t# added in [0-9]*\.[0-9]*$/ { next; } # version comments
+ { print $0; }' || echo $map
+ done
+}
+
+bad_format_maps=$(find_bad_format_maps $@)
+if [ -n "$bad_format_maps" ] ; then
+ echo "Found badly formatted maps:"
+ echo "$bad_format_maps"
+ ret=1
+fi
+
exit $ret
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index b965d6aa52..da4f847116 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -181,7 +181,20 @@ EXPERIMENTAL {
__rte_ethdev_trace_tx_burst;
rte_flow_get_aged_flows;
- # Marked as experimental in 20.11
+ # added in 20.11
+ rte_eth_hairpin_bind;
+ rte_eth_hairpin_get_peer_ports;
+ rte_eth_hairpin_unbind;
+ rte_eth_link_speed_to_str;
+ rte_eth_link_to_str;
+ rte_eth_fec_get_capability;
+ rte_eth_fec_get;
+ rte_eth_fec_set;
+ rte_flow_tunnel_decap_set;
+ rte_flow_tunnel_match;
+ rte_flow_get_restore_info;
+ rte_flow_tunnel_action_decap_release;
+ rte_flow_tunnel_item_release;
rte_tm_capabilities_get;
rte_tm_get_number_of_leaf_nodes;
rte_tm_hierarchy_commit;
@@ -213,21 +226,6 @@ EXPERIMENTAL {
rte_tm_wred_profile_add;
rte_tm_wred_profile_delete;
- # added in 20.11
- rte_eth_hairpin_bind;
- rte_eth_hairpin_get_peer_ports;
- rte_eth_hairpin_unbind;
- rte_eth_link_speed_to_str;
- rte_eth_link_to_str;
- rte_eth_fec_get_capability;
- rte_eth_fec_get;
- rte_eth_fec_set;
- rte_flow_tunnel_decap_set;
- rte_flow_tunnel_match;
- rte_flow_get_restore_info;
- rte_flow_tunnel_action_decap_release;
- rte_flow_tunnel_item_release;
-
# added in 21.02
rte_eth_get_monitor_addr;
--
2.41.0
next prev parent reply other threads:[~2023-08-16 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 15:49 [PATCH] devtools: list symbols by version David Marchand
2023-08-11 17:13 ` Stephen Hemminger
2023-08-14 9:48 ` Thomas Monjalon
2023-08-15 10:01 ` David Marchand
2023-08-15 10:36 ` [PATCH v2 1/2] devtools: add check on symbol maps format David Marchand
2023-08-15 10:36 ` [PATCH v2 2/2] devtools: list symbols by version David Marchand
2023-08-15 17:42 ` [PATCH v3 1/2] devtools: add check on symbol maps format David Marchand
2023-08-15 17:42 ` [PATCH v3 2/2] devtools: list symbols by version David Marchand
2023-08-16 7:16 ` David Marchand [this message]
2023-08-16 7:16 ` [PATCH v4 " David Marchand
2023-11-15 10:42 ` [PATCH v5 1/2] devtools: add check on symbol maps format David Marchand
2023-11-15 10:42 ` [PATCH v5 2/2] devtools: list symbols by version David Marchand
2023-11-27 7:37 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816071603.1002271-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).