DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vipin Varghese <vipin.varghese@amd.com>
To: <thomas@monjalon.net>, <dev@dpdk.org>, <anoobj@marvell.com>
Cc: <Ferruh.Yigit@amd.com>, <cheng1.jiang@intel.com>, <stable@dpdk.org>
Subject: [PATCH v2] app/dma-perf: fix physical address seg-fault
Date: Wed, 16 Aug 2023 14:54:41 +0530	[thread overview]
Message-ID: <20230816092441.1814-1-vipin.varghese@amd.com> (raw)
In-Reply-To: <20230816071810.1796-1-vipin.varghese@amd.com>

do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return
the start of the virtual address for both src and dst.
But in case of iova mode set as PA, this results in seg-fault.
This is because rte_memcpy uses VA address and not PA.

This fix invokes `rte_pktmbuf_mtod` for both src and dst.

Bugzilla ID: 1269
Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: cheng1.jiang@intel.com

Cc: stable@dpdk.org

Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
Suggested-by: Anoob Joseph <anoobj@marvell.com>
---

v2:
 - suggest use of pktmbuf_mtod for both va and pa.

tested for both va and pa

CMD:
PA: dpdk-test-dma-perf --iova-mode=pa  -- --config test.ini
VA: dpdk-test-dma-perf --iova-mode=va  -- --config test.ini
DC: dpdk-test-dma-perf --iova-mode=dc  -- --config test.ini

Log: fails for dc mode `EAL: invalid parameters for --iova-mode`

test.ini:
```
[case1]
type=CPU_MEM_COPY
mem_size=10
buf_size=64,8192,2,MUL
src_numa_node=0
dst_numa_node=0
cache_flush=0
test_seconds=2
lcore = 7
eal_args=--in-memory --no-pci
```
---
 app/test-dma-perf/benchmark.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
index 0601e0d171..9059253057 100644
--- a/app/test-dma-perf/benchmark.c
+++ b/app/test-dma-perf/benchmark.c
@@ -288,9 +288,12 @@ do_cpu_mem_copy(void *p)
 
 	while (1) {
 		for (i = 0; i < nr_buf; i++) {
+			void *src = rte_pktmbuf_mtod(dsts[i], void *);
+			void *dst = rte_pktmbuf_mtod(srcs[i], void *);
+
 			/* copy buffer form src to dst */
-			rte_memcpy((void *)(uintptr_t)rte_mbuf_data_iova(dsts[i]),
-				(void *)(uintptr_t)rte_mbuf_data_iova(srcs[i]),
+			rte_memcpy(dst,
+				src,
 				(size_t)buf_size);
 			worker_info->total_cpl++;
 		}
-- 
2.34.1


  parent reply	other threads:[~2023-08-16  9:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16  7:18 [PATCH] " Vipin Varghese
2023-08-16  7:26 ` [EXT] " Anoob Joseph
2023-08-16  7:31   ` Varghese, Vipin
2023-08-16  9:24 ` Vipin Varghese [this message]
2023-08-16  9:35 ` [PATCH v2] " Vipin Varghese
2023-08-16  9:42 ` Vipin Varghese
2023-08-16 10:12   ` Jerin Jacob
2023-08-16 10:46   ` [EXT] " Anoob Joseph
2023-09-21  2:28   ` Jiang, Cheng1
2023-10-04  9:00     ` Varghese, Vipin
2023-10-04 13:00       ` Jerin Jacob
2023-10-19  4:19   ` [PATCH v3] " Vipin Varghese
2023-10-24  2:16     ` lihuisong (C)
2023-11-14 14:27       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230816092441.1814-1-vipin.varghese@amd.com \
    --to=vipin.varghese@amd.com \
    --cc=Ferruh.Yigit@amd.com \
    --cc=anoobj@marvell.com \
    --cc=cheng1.jiang@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).