From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F8A543086; Wed, 16 Aug 2023 23:04:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBE2340ED9; Wed, 16 Aug 2023 23:04:08 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A674E40DDA; Wed, 16 Aug 2023 23:04:07 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id BDB7B211F618; Wed, 16 Aug 2023 14:04:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BDB7B211F618 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1692219846; bh=5942blqYQTzU5oC3yStlUJtnZXuwp9PRXJV2fWmLaOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JoKVOkc8jbY2inS0BRZM8kPAM+nhd5Khtsu1FZb6592n0XCpopa55esNVFNrZZ213 +8JWdRNqkcpUbj21bShuFN48Y4E9kjME3QbLRHzrYoO81uHbjsmx0PhhV3wHiYWKkk bZYxi6X7SiS75Agn/xEpCYSH4vZIFxWWnwrs+YOM= Date: Wed, 16 Aug 2023 14:04:06 -0700 From: Tyler Retzlaff To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, techboard@dpdk.org, Bruce Richardson , Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Joyce Kong , David Christensen , Konstantin Ananyev , David Hunt , Thomas Monjalon , David Marchand Subject: Re: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API Message-ID: <20230816210406.GA22350@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1692213549-11786-1-git-send-email-roretzla@linux.microsoft.com> <1692213549-11786-2-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87B11@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B11@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Wednesday, 16 August 2023 21.19 > > > > Provide API for atomic operations in the rte namespace that may > > optionally be configured to use C11 atomics with meson > > option enable_stdatomics=true > > > > Signed-off-by: Tyler Retzlaff > > Reviewed-by: Morten Brørup > > --- > > "#define RTE_ATOMIC(type) [...]" is missing in lib/eal/include/rte_stdatomic.h, both with and without RTE_ENABLE_STDATOMIC. > > I suggest you keep it together with "#define __rte_atomic [...]". this seems to be an error i made in patch submission, somehow i managed to drop the changes i made from v2-v3 from the series i submitted i'm confused how i managed to fat finger it. i'll submit a new series with the correct changes to rte_stdatomic.h > > Please also add descriptions as comments to both (type-qualifier and -specifier) in both locations. Your descriptions from the mailing list discussion are fine. > i'll do this in the v4 commit message thanks