From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4BF0B43093;
	Thu, 17 Aug 2023 21:09:40 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CDB08406A2;
	Thu, 17 Aug 2023 21:09:39 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 5FE3F4013F;
 Thu, 17 Aug 2023 21:09:38 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 960DD211F7BC; Thu, 17 Aug 2023 12:09:37 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 960DD211F7BC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1692299377;
 bh=ZrBcvEs1S63nFZDYO7RpRAqvcxHhZdfsGeDhOUjVPFw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=a2PP7VM36/1iVDppAhTpSk/ycmlUJxWYHC9fH3hoiYRl/U8k1u6XpzAznH9iz/22w
 jOhPWo0CLEw/Jl2phKLuzf2ZhBYjOSwKzKZkcHdtNhdXXE8IMz+SPdF1zV+NZdKqYe
 0fFo1QlrtHiQUF86LNNx3Gz42FkHA2EvJ9ExSXkg=
Date: Thu, 17 Aug 2023 12:09:37 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Cc: dev@dpdk.org, techboard@dpdk.org,
 Bruce Richardson <bruce.richardson@intel.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Ruifeng Wang <ruifeng.wang@arm.com>, Jerin Jacob <jerinj@marvell.com>,
 Sunil Kumar Kori <skori@marvell.com>,
 Mattias =?iso-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>,
 Joyce Kong <joyce.kong@arm.com>,
 David Christensen <drc@linux.vnet.ibm.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 David Hunt <david.hunt@intel.com>, Thomas Monjalon <thomas@monjalon.net>,
 David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v4 1/6] eal: provide rte stdatomics optional atomics API
Message-ID: <20230817190937.GA12307@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com>
 <1692221931-32334-1-git-send-email-roretzla@linux.microsoft.com>
 <1692221931-32334-2-git-send-email-roretzla@linux.microsoft.com>
 <98CBD80474FA8B44BF855DF32C47DC35D87B15@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B15@smartserver.smartshare.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Aug 17, 2023 at 01:45:21PM +0200, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Wednesday, 16 August 2023 23.39
> > 
> > Provide API for atomic operations in the rte namespace that may
> > optionally be configured to use C11 atomics with meson
> > option enable_stdatomics=true
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> 
> Speed blindness during my review... I have now spotted a couple of copy-paste typos:
> 
> > +#define rte_atomic_compare_exchange_weak_explicit( \
> > +	    ptr, expected, desired, succ_memorder, fail_memorder) \
> > +	atomic_compare_exchange_strong_explicit( \
> 
> atomic_compare_exchange_weak_explicit, not strong.

yikes, thanks for catching that cut & past error

> 
> > +	    ptr, expected, desired, succ_memorder, fail_memorder)
> > +
> 
> [...]
> 
> > +#define rte_atomic_flag_clear_explicit(ptr, memorder) \
> > +	atomic_flag_clear(ptr, memorder)
> 
> atomic_flag_clear_explicit(ptr, memorder), missing _explicit.

yes, currently unused otherwise it would have failed to compie

i'll correct this too.

thank you for the careful review i look at the diffs over and over and
still it's hard to spot subtle swaps/exchanges of things.

>