From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE3B743102; Fri, 25 Aug 2023 18:35:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 887A440A7A; Fri, 25 Aug 2023 18:35:38 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A158C400D5 for <dev@dpdk.org>; Fri, 25 Aug 2023 18:35:36 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id CE41A2127C94; Fri, 25 Aug 2023 09:35:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CE41A2127C94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1692981335; bh=B6Lbq/uI1bA1VOxBarn6DBfYqqgru62eoRw926U8ilw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RO2sKXj0O39KmGoPll3cDiQJM+QXP3a7MGHnMu28g0bTFw9es2OzRxg4z4cvyLmA0 3ncPugGZ8+xHY3uGTJkF5k5kt2cS6WYAt6NJRsOAw4xlwkEs5cEz4qGZIkdRAcinEr tN0BFjrf0rycfVHlGy8MGtQE+eH8F+7haGUYKc3w= Date: Fri, 25 Aug 2023 09:35:35 -0700 From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Kai Ji <kai.ji@intel.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>, Vikas Gupta <vikas.gupta@broadcom.com>, Timothy McDaniel <timothy.mcdaniel@intel.com>, Harry van Haaren <harry.van.haaren@intel.com>, Srikanth Yalavarthi <syalavarthi@marvell.com>, Somnath Kotur <somnath.kotur@broadcom.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Dongdong Liu <liudongdong3@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, David Christensen <drc@linux.vnet.ibm.com>, Qiming Yang <qiming.yang@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>, Wenjun Wu <wenjun1.wu@intel.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Liron Himi <lironh@marvell.com>, Long Li <longli@microsoft.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>, Nicolas Chautru <nicolas.chautru@intel.com>, Brian Dooley <brian.dooley@intel.com>, Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>, Chengwen Feng <fengchengwen@huawei.com>, Kevin Laatz <kevin.laatz@intel.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Mattias =?iso-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com> Subject: Re: [PATCH 1/2] use abstracted bit count functions Message-ID: <20230825163535.GC18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230825101812.2396339-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825101812.2396339-1-david.marchand@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Aug 25, 2023 at 12:18:10PM +0200, David Marchand wrote: > Now that DPDK provides such bit count functions, make use of them. > > This patch was prepared with a "brutal" commandline: > > $ old=__builtin_clzll; new=rte_clz64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > $ old=__builtin_clz; new=rte_clz32; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > > $ old=__builtin_ctzll; new=rte_ctz64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > $ old=__builtin_ctz; new=rte_ctz32; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > > $ old=__builtin_popcountll; new=rte_popcount64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > $ old=__builtin_popcount; new=rte_popcount32; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > > Then inclusion of rte_bitops.h was added were necessary. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- These kinds of patches always make me dizzy, I did a pass I cannot see any replacement problems so lgtm. Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>