[PATCH] doc: deprecation notice to add new hash function

[PATCH] doc: deprecation notice to add new hash function

[Xueming Li]

Deprecation notice to annouce new RSS hash function type.
The new symmetric hash function sort L3 address and L4 ports
before Toeplitz calculation.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index dcc1ca1696..fc988c3bfe 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -163,3 +163,7 @@ Deprecation Notices
   The new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status
   starting with DPDK 23.07 release.
+
+* ethdev: The enum ``rte_eth_hash_function`` will be extended to add
+  new subtype value ``RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT`` in
+  DPDK 23.11.
-- 
2.25.1

RE: [PATCH] doc: deprecation notice to add new hash function

[Ori Kam]

Hi Xueming,

> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Wednesday, May 24, 2023 2:38 PM
> 
> Deprecation notice to annouce new RSS hash function type.
> The new symmetric hash function sort L3 address and L4 ports
> before Toeplitz calculation.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index dcc1ca1696..fc988c3bfe 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -163,3 +163,7 @@ Deprecation Notices
>    The new port library API (functions rte_swx_port_*)
>    will gradually transition from experimental to stable status
>    starting with DPDK 23.07 release.
> +
> +* ethdev: The enum ``rte_eth_hash_function`` will be extended to add
> +  new subtype value
> ``RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT`` in
> +  DPDK 23.11.
> --
> 2.25.1

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori

Re: [PATCH] doc: deprecation notice to add new hash function

[Stephen Hemminger]

On Wed, 24 May 2023 19:38:27 +0800
Xueming Li <xuemingl@nvidia.com> wrote:

> +
> +* ethdev: The enum ``rte_eth_hash_function`` will be extended to add
> +  new subtype value ``RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT`` in
> +  DPDK 23.11.

Simple new additions like this don't need to clutter the deprecation
part of the release notes. This is for changes which would break applications.

Re: [PATCH] doc: deprecation notice to add new hash function

[Thomas Monjalon]

24/05/2023 16:49, Stephen Hemminger:
> On Wed, 24 May 2023 19:38:27 +0800
> Xueming Li <xuemingl@nvidia.com> wrote:
> 
> > +
> > +* ethdev: The enum ``rte_eth_hash_function`` will be extended to add
> > +  new subtype value ``RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT`` in
> > +  DPDK 23.11.
> 
> Simple new additions like this don't need to clutter the deprecation
> part of the release notes. This is for changes which would break applications.

Marking this patch as superseded.
My patch is mentioning such case: adding an enum field.
https://patches.dpdk.org/project/dpdk/patch/20230728142946.1201459-1-thomas@monjalon.net/

[PATCH] ethdev: add new symmetric hash function

[Xueming Li]

The new symmetric hash function swap src/dst L3 address and
L4 ports automatically by sorting.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 lib/ethdev/rte_flow.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index 86ed98c562..ec6dd170b5 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -3204,6 +3204,11 @@ enum rte_eth_hash_function {
 	 * src or dst address will xor with zero pair.
 	 */
 	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
+	/**
+	 * Symmetric Toeplitz: src, dst will be swapped
+	 * automatically by sorting.
+	 */
+	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
 	RTE_ETH_HASH_FUNCTION_MAX,
 };
 
-- 
2.25.1

RE: [PATCH] ethdev: add new symmetric hash function

[Ori Kam]

Hi Xueming,


> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Monday, August 7, 2023 2:55 PM
> 
> The new symmetric hash function swap src/dst L3 address and
> L4 ports automatically by sorting.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori

Re: [PATCH] ethdev: add new symmetric hash function

[Ivan Malov]

Hi,

Please see my notes below.

On Mon, 7 Aug 2023, Xueming Li wrote:

> The new symmetric hash function swap src/dst L3 address and
> L4 ports automatically by sorting.
>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
> lib/ethdev/rte_flow.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 86ed98c562..ec6dd170b5 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3204,6 +3204,11 @@ enum rte_eth_hash_function {
> 	 * src or dst address will xor with zero pair.
> 	 */
> 	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> +	/**
> +	 * Symmetric Toeplitz: src, dst will be swapped
> +	 * automatically by sorting.

This is very vague. Consider:

For symmetric Toeplitz, four inputs are prepared as follows:
- src_addr | dst_addr
- src_addr ^ dst_addr
- src_port | dst_port
- src_port ^ dst_port
and then passed to the regular Toeplitz function.

It is important to be as specific as possible
so that readers don't have to guess.

Thank you.

> +	 */
> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
> 	RTE_ETH_HASH_FUNCTION_MAX,
> };
>
> -- 
> 2.25.1
>
>

Re: [PATCH] ethdev: add new symmetric hash function

[fengchengwen]

On 2023/8/8 6:32, Ivan Malov wrote:
> Hi,
> 
> Please see my notes below.
> 
> On Mon, 7 Aug 2023, Xueming Li wrote:
> 
>> The new symmetric hash function swap src/dst L3 address and
>> L4 ports automatically by sorting.
>>
>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
>> ---
>> lib/ethdev/rte_flow.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
>> index 86ed98c562..ec6dd170b5 100644
>> --- a/lib/ethdev/rte_flow.h
>> +++ b/lib/ethdev/rte_flow.h
>> @@ -3204,6 +3204,11 @@ enum rte_eth_hash_function {
>>      * src or dst address will xor with zero pair.
>>      */
>>     RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>> +    /**
>> +     * Symmetric Toeplitz: src, dst will be swapped
>> +     * automatically by sorting.
> 
> This is very vague. Consider:
> 
> For symmetric Toeplitz, four inputs are prepared as follows:
> - src_addr | dst_addr
> - src_addr ^ dst_addr
> - src_port | dst_port
> - src_port ^ dst_port
> and then passed to the regular Toeplitz function.
> 
> It is important to be as specific as possible
> so that readers don't have to guess.

+1 for this, I try to understand and google it, but can't find useful info.

Also, how this new algo with src/dst only ?

> 
> Thank you.
> 
>> +     */
>> +    RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
>>     RTE_ETH_HASH_FUNCTION_MAX,

The new value will break the definition of MAX (maybe ABI compatible).
but I found only hns3 drivers use RTE_ETH_HASH_FUNCTION_MAX, not sure the application will use it.

>> };
>>
>> -- 
>> 2.25.1
>>
>>
> 
> .

RE: [PATCH] ethdev: add new symmetric hash function

[Xueming(Steven) Li]

> -----Original Message-----
> From: fengchengwen <fengchengwen@huawei.com>
> Sent: 8/8/2023 9:43
> To: Ivan Malov <ivan.malov@arknetworks.am>; Xueming(Steven) Li
> <xuemingl@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; dev@dpdk.org
> Subject: Re: [PATCH] ethdev: add new symmetric hash function
> 
> On 2023/8/8 6:32, Ivan Malov wrote:
> > Hi,
> >
> > Please see my notes below.
> >
> > On Mon, 7 Aug 2023, Xueming Li wrote:
> >
> >> The new symmetric hash function swap src/dst L3 address and
> >> L4 ports automatically by sorting.
> >>
> >> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> >> ---
> >> lib/ethdev/rte_flow.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
> >> 86ed98c562..ec6dd170b5 100644
> >> --- a/lib/ethdev/rte_flow.h
> >> +++ b/lib/ethdev/rte_flow.h
> >> @@ -3204,6 +3204,11 @@ enum rte_eth_hash_function {
> >>      * src or dst address will xor with zero pair.
> >>      */
> >>     RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> >> +    /**
> >> +     * Symmetric Toeplitz: src, dst will be swapped
> >> +     * automatically by sorting.
> >
> > This is very vague. Consider:
> >
> > For symmetric Toeplitz, four inputs are prepared as follows:
> > - src_addr | dst_addr
> > - src_addr ^ dst_addr
> > - src_port | dst_port
> > - src_port ^ dst_port
> > and then passed to the regular Toeplitz function.
> >
> > It is important to be as specific as possible so that readers don't
> > have to guess.
> 
> +1 for this, I try to understand and google it, but can't find useful info.
> 
> Also, how this new algo with src/dst only ?
> 

Thanks for taking care of this. 
When set the L3 and the L4 fields are sorted prior to the hash function.
  If src_ip > dst_ip, swap src_ip and dst_ip.
  If src_port > dst_port, swap src_port and dst_port.

> >
> > Thank you.
> >
> >> +     */
> >> +    RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
> >>     RTE_ETH_HASH_FUNCTION_MAX,
> 
> The new value will break the definition of MAX (maybe ABI compatible).
> but I found only hns3 drivers use RTE_ETH_HASH_FUNCTION_MAX, not sure
> the application will use it.
> 
> >> };
> >>
> >> --
> >> 2.25.1
> >>
> >>
> >
> > .

[PATCH v2 1/2] ethdev: add new symmetric hash function

[Xueming Li]

The new symmetric hash function swap src/dst L3 address and
L4 ports automatically by sorting.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 lib/ethdev/rte_flow.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index 2ebb76dbc0..4f4421ca50 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
 	 * src or dst address will xor with zero pair.
 	 */
 	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
+	/**
+	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
+	 * the hash function.
+	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
+	 *  If src_port > dst_port, swap src_port and dst_port.
+	 */
+	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
 	RTE_ETH_HASH_FUNCTION_MAX,
 };
 
-- 
2.25.1

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

[Ori Kam]

Hi Xueming,

> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Sunday, August 27, 2023 11:18 AM
> 
> The new symmetric hash function swap src/dst L3 address and
> L4 ports automatically by sorting.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  lib/ethdev/rte_flow.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 2ebb76dbc0..4f4421ca50 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
>  	 * src or dst address will xor with zero pair.
>  	 */
>  	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> +	/**
> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
> +	 * the hash function.
> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
> +	 *  If src_port > dst_port, swap src_port and dst_port.
> +	 */
> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
>  	RTE_ETH_HASH_FUNCTION_MAX,
>  };
> 
> --
> 2.25.1

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

[Ferruh Yigit]

On 8/30/2023 7:55 AM, Ori Kam wrote:
>> -----Original Message-----
>> From: Xueming(Steven) Li <xuemingl@nvidia.com>
>> Sent: Sunday, August 27, 2023 11:18 AM
>>
>> The new symmetric hash function swap src/dst L3 address and
>> L4 ports automatically by sorting.
>>
>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> 
> Acked-by: Ori Kam <orika@nvidia.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

Updated commit log with information provided in this mail thread.

Applied to dpdk-next-net/main, thanks.


Note only ethdev patch applied, not series, mlx5 patch delegated to Raslan.

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

[Xueming(Steven) Li]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: 9/21/2023 23:50
> To: Ori Kam <orika@nvidia.com>; Xueming(Steven) Li <xuemingl@nvidia.com>
> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> <ivan.malov@arknetworks.am>; Raslan Darawsheh <rasland@nvidia.com>
> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> 
> On 8/30/2023 7:55 AM, Ori Kam wrote:
> >> -----Original Message-----
> >> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> >> Sent: Sunday, August 27, 2023 11:18 AM
> >>
> >> The new symmetric hash function swap src/dst L3 address and
> >> L4 ports automatically by sorting.
> >>
> >> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> >
> > Acked-by: Ori Kam <orika@nvidia.com>
> >
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 
> Updated commit log with information provided in this mail thread.

Thanks very much!

> 
> Applied to dpdk-next-net/main, thanks.
> 
> 
> Note only ethdev patch applied, not series, mlx5 patch delegated to Raslan.

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

[lihuisong (C)]

Hi Xueming,

在 2023/8/27 16:17, Xueming Li 写道:
> The new symmetric hash function swap src/dst L3 address and
> L4 ports automatically by sorting.
>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>   lib/ethdev/rte_flow.h | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 2ebb76dbc0..4f4421ca50 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
>   	 * src or dst address will xor with zero pair.
>   	 */
>   	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> +	/**
> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
> +	 * the hash function.
> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
> +	 *  If src_port > dst_port, swap src_port and dst_port.
> +	 */
If hash result are computed by the order: "src_ip+dst_ip+src_port+dst_port"
How to obtain the value of every L3 and L4 field obove?
I still cannot understand how to swap and set these values for these 
fields?
> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
>   	RTE_ETH_HASH_FUNCTION_MAX,
>   };
>   

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

[Xueming(Steven) Li]

> -----Original Message-----
> From: lihuisong (C) <lihuisong@huawei.com>
> Sent: 8/30/2023 15:51
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> <ivan.malov@arknetworks.am>
> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> 
> Hi Xueming,
> 
> 在 2023/8/27 16:17, Xueming Li 写道:
> > The new symmetric hash function swap src/dst L3 address and
> > L4 ports automatically by sorting.
> >
> > Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> > ---
> >   lib/ethdev/rte_flow.h | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
> > 2ebb76dbc0..4f4421ca50 100644
> > --- a/lib/ethdev/rte_flow.h
> > +++ b/lib/ethdev/rte_flow.h
> > @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
> >   	 * src or dst address will xor with zero pair.
> >   	 */
> >   	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> > +	/**
> > +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
> > +	 * the hash function.
> > +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
> > +	 *  If src_port > dst_port, swap src_port and dst_port.
> > +	 */
> If hash result are computed by the order: "src_ip+dst_ip+src_port+dst_port"
> How to obtain the value of every L3 and L4 field obove?
> I still cannot understand how to swap and set these values for these fields?

Hash result is computed by order ""src_ip+dst_ip+src_port+dst_port"
Here is a detailed explanation of standard hash and symmetric hash by key:
  https://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf

If src_ip > dst_ip, swap them, then the input becomes:
  "dst_ip+src_ip+src_port+dst_port" // please note src and dst IP are swapped.
Same for L4 ports.

> > +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
> >   	RTE_ETH_HASH_FUNCTION_MAX,
> >   };
> >

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

[lihuisong (C)]

在 2023/8/30 16:38, Xueming(Steven) Li 写道:
>
>> -----Original Message-----
>> From: lihuisong (C) <lihuisong@huawei.com>
>> Sent: 8/30/2023 15:51
>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>
>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
>> <ivan.malov@arknetworks.am>
>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
>>
>> Hi Xueming,
>>
>> 在 2023/8/27 16:17, Xueming Li 写道:
>>> The new symmetric hash function swap src/dst L3 address and
>>> L4 ports automatically by sorting.
>>>
>>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
>>> ---
>>>    lib/ethdev/rte_flow.h | 7 +++++++
>>>    1 file changed, 7 insertions(+)
>>>
>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>> 2ebb76dbc0..4f4421ca50 100644
>>> --- a/lib/ethdev/rte_flow.h
>>> +++ b/lib/ethdev/rte_flow.h
>>> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
>>>    	 * src or dst address will xor with zero pair.
>>>    	 */
>>>    	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>>> +	/**
>>> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
>>> +	 * the hash function.
>>> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
>>> +	 *  If src_port > dst_port, swap src_port and dst_port.
>>> +	 */
>> If hash result are computed by the order: "src_ip+dst_ip+src_port+dst_port"
>> How to obtain the value of every L3 and L4 field obove?
>> I still cannot understand how to swap and set these values for these fields?
> Hash result is computed by order ""src_ip+dst_ip+src_port+dst_port"
> Here is a detailed explanation of standard hash and symmetric hash by key:
>    https://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf
>
> If src_ip > dst_ip, swap them, then the input becomes:
>    "dst_ip+src_ip+src_port+dst_port" // please note src and dst IP are swapped.
> Same for L4 ports.
get it.
What are the advantages of the symmetric toeplitz sort?
Or why swap here?
>
>>> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
>>>    	RTE_ETH_HASH_FUNCTION_MAX,
>>>    };
>>>

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

[Xueming(Steven) Li]

> -----Original Message-----
> From: lihuisong (C) <lihuisong@huawei.com>
> Sent: 8/30/2023 20:42
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> <ivan.malov@arknetworks.am>
> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> 
> 
> 在 2023/8/30 16:38, Xueming(Steven) Li 写道:
> >
> >> -----Original Message-----
> >> From: lihuisong (C) <lihuisong@huawei.com>
> >> Sent: 8/30/2023 15:51
> >> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam
> >> <orika@nvidia.com>
> >> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> >> <ivan.malov@arknetworks.am>
> >> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> >>
> >> Hi Xueming,
> >>
> >> 在 2023/8/27 16:17, Xueming Li 写道:
> >>> The new symmetric hash function swap src/dst L3 address and
> >>> L4 ports automatically by sorting.
> >>>
> >>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> >>> ---
> >>>    lib/ethdev/rte_flow.h | 7 +++++++
> >>>    1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
> >>> 2ebb76dbc0..4f4421ca50 100644
> >>> --- a/lib/ethdev/rte_flow.h
> >>> +++ b/lib/ethdev/rte_flow.h
> >>> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
> >>>    	 * src or dst address will xor with zero pair.
> >>>    	 */
> >>>    	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> >>> +	/**
> >>> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
> >>> +	 * the hash function.
> >>> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
> >>> +	 *  If src_port > dst_port, swap src_port and dst_port.
> >>> +	 */
> >> If hash result are computed by the order:
> "src_ip+dst_ip+src_port+dst_port"
> >> How to obtain the value of every L3 and L4 field obove?
> >> I still cannot understand how to swap and set these values for these fields?
> > Hash result is computed by order ""src_ip+dst_ip+src_port+dst_port"
> > Here is a detailed explanation of standard hash and symmetric hash by key:
> >    https://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf
> >
> > If src_ip > dst_ip, swap them, then the input becomes:
> >    "dst_ip+src_ip+src_port+dst_port" // please note src and dst IP are
> swapped.
> > Same for L4 ports.
> get it.
> What are the advantages of the symmetric toeplitz sort?
> Or why swap here?

It's a different symmetric hash calculation, hardware can support either/all of them.

From calculation perspective, the hash result distribution is better, the result is more
suitable to be used as hash table key.

> >
> >>> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
> >>>    	RTE_ETH_HASH_FUNCTION_MAX,
> >>>    };
> >>>

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

[lihuisong (C)]

在 2023/8/30 21:09, Xueming(Steven) Li 写道:
>
>> -----Original Message-----
>> From: lihuisong (C) <lihuisong@huawei.com>
>> Sent: 8/30/2023 20:42
>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>
>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
>> <ivan.malov@arknetworks.am>
>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
>>
>>
>> 在 2023/8/30 16:38, Xueming(Steven) Li 写道:
>>>> -----Original Message-----
>>>> From: lihuisong (C) <lihuisong@huawei.com>
>>>> Sent: 8/30/2023 15:51
>>>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam
>>>> <orika@nvidia.com>
>>>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
>>>> <ivan.malov@arknetworks.am>
>>>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
>>>>
>>>> Hi Xueming,
>>>>
>>>> 在 2023/8/27 16:17, Xueming Li 写道:
>>>>> The new symmetric hash function swap src/dst L3 address and
>>>>> L4 ports automatically by sorting.
>>>>>
>>>>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
>>>>> ---
>>>>>     lib/ethdev/rte_flow.h | 7 +++++++
>>>>>     1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>>>> 2ebb76dbc0..4f4421ca50 100644
>>>>> --- a/lib/ethdev/rte_flow.h
>>>>> +++ b/lib/ethdev/rte_flow.h
>>>>> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
>>>>>     	 * src or dst address will xor with zero pair.
>>>>>     	 */
>>>>>     	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>>>>> +	/**
>>>>> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
>>>>> +	 * the hash function.
>>>>> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
>>>>> +	 *  If src_port > dst_port, swap src_port and dst_port.
>>>>> +	 */
>>>> If hash result are computed by the order:
>> "src_ip+dst_ip+src_port+dst_port"
>>>> How to obtain the value of every L3 and L4 field obove?
>>>> I still cannot understand how to swap and set these values for these fields?
>>> Hash result is computed by order ""src_ip+dst_ip+src_port+dst_port"
>>> Here is a detailed explanation of standard hash and symmetric hash by key:
>>>     https://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf
>>>
>>> If src_ip > dst_ip, swap them, then the input becomes:
>>>     "dst_ip+src_ip+src_port+dst_port" // please note src and dst IP are
>> swapped.
>>> Same for L4 ports.
>> get it.
>> What are the advantages of the symmetric toeplitz sort?
>> Or why swap here?
> It's a different symmetric hash calculation, hardware can support either/all of them.
>
>  From calculation perspective, the hash result distribution is better, the result is more
> suitable to be used as hash table key.
I get it now.
but I have a question.
why not is that if src_ip < dst_ip, then swap src_ip and dst_ip?
I guess this is going to have the same effect as you said, right?
The symmetric toeplitz sort is not a standard algorithm, is just to 
enhance the hash result distribution.
If what I understand is right,
it is better that the new RSS algorithm should works on the one of them 
("src_ip > dst_ip" or "src_ip < dst_ip").
>
>>>>> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
>>>>>     	RTE_ETH_HASH_FUNCTION_MAX,
>>>>>     };
>>>>>

RE: [PATCH v2 1/2] ethdev: add new symmetric hash function

[Xueming(Steven) Li]

> -----Original Message-----
> From: lihuisong (C) <lihuisong@huawei.com>
> Sent: 8/31/2023 9:24
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> <ivan.malov@arknetworks.am>
> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> 
> 
> 在 2023/8/30 21:09, Xueming(Steven) Li 写道:
> >
> >> -----Original Message-----
> >> From: lihuisong (C) <lihuisong@huawei.com>
> >> Sent: 8/30/2023 20:42
> >> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam
> >> <orika@nvidia.com>
> >> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> >> <ivan.malov@arknetworks.am>
> >> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> >>
> >>
> >> 在 2023/8/30 16:38, Xueming(Steven) Li 写道:
> >>>> -----Original Message-----
> >>>> From: lihuisong (C) <lihuisong@huawei.com>
> >>>> Sent: 8/30/2023 15:51
> >>>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam
> >>>> <orika@nvidia.com>
> >>>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
> >>>> <ivan.malov@arknetworks.am>
> >>>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
> >>>>
> >>>> Hi Xueming,
> >>>>
> >>>> 在 2023/8/27 16:17, Xueming Li 写道:
> >>>>> The new symmetric hash function swap src/dst L3 address and
> >>>>> L4 ports automatically by sorting.
> >>>>>
> >>>>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> >>>>> ---
> >>>>>     lib/ethdev/rte_flow.h | 7 +++++++
> >>>>>     1 file changed, 7 insertions(+)
> >>>>>
> >>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
> >>>>> 2ebb76dbc0..4f4421ca50 100644
> >>>>> --- a/lib/ethdev/rte_flow.h
> >>>>> +++ b/lib/ethdev/rte_flow.h
> >>>>> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
> >>>>>     	 * src or dst address will xor with zero pair.
> >>>>>     	 */
> >>>>>     	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
> >>>>> +	/**
> >>>>> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
> >>>>> +	 * the hash function.
> >>>>> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
> >>>>> +	 *  If src_port > dst_port, swap src_port and dst_port.
> >>>>> +	 */
> >>>> If hash result are computed by the order:
> >> "src_ip+dst_ip+src_port+dst_port"
> >>>> How to obtain the value of every L3 and L4 field obove?
> >>>> I still cannot understand how to swap and set these values for these
> fields?
> >>> Hash result is computed by order ""src_ip+dst_ip+src_port+dst_port"
> >>> Here is a detailed explanation of standard hash and symmetric hash by
> key:
> >>>     https://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf
> >>>
> >>> If src_ip > dst_ip, swap them, then the input becomes:
> >>>     "dst_ip+src_ip+src_port+dst_port" // please note src and dst IP
> >>> are
> >> swapped.
> >>> Same for L4 ports.
> >> get it.
> >> What are the advantages of the symmetric toeplitz sort?
> >> Or why swap here?
> > It's a different symmetric hash calculation, hardware can support either/all
> of them.
> >
> >  From calculation perspective, the hash result distribution is better,
> > the result is more suitable to be used as hash table key.
> I get it now.
> but I have a question.
> why not is that if src_ip < dst_ip, then swap src_ip and dst_ip?
> I guess this is going to have the same effect as you said, right?
> The symmetric toeplitz sort is not a standard algorithm, is just to enhance the
> hash result distribution.
> If what I understand is right,
> it is better that the new RSS algorithm should works on the one of them
> ("src_ip > dst_ip" or "src_ip < dst_ip").

Any special reason to introduce the descending sort?
I personally prefer to keep the enum clean unless some new hw or new algorithm introduced.

> >
> >>>>> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
> >>>>>     	RTE_ETH_HASH_FUNCTION_MAX,
> >>>>>     };
> >>>>>

Re: [PATCH v2 1/2] ethdev: add new symmetric hash function

[lihuisong (C)]

在 2023/8/31 14:25, Xueming(Steven) Li 写道:
>
>> -----Original Message-----
>> From: lihuisong (C) <lihuisong@huawei.com>
>> Sent: 8/31/2023 9:24
>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>
>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
>> <ivan.malov@arknetworks.am>
>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
>>
>>
>> 在 2023/8/30 21:09, Xueming(Steven) Li 写道:
>>>> -----Original Message-----
>>>> From: lihuisong (C) <lihuisong@huawei.com>
>>>> Sent: 8/30/2023 20:42
>>>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam
>>>> <orika@nvidia.com>
>>>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
>>>> <ivan.malov@arknetworks.am>
>>>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
>>>>
>>>>
>>>> 在 2023/8/30 16:38, Xueming(Steven) Li 写道:
>>>>>> -----Original Message-----
>>>>>> From: lihuisong (C) <lihuisong@huawei.com>
>>>>>> Sent: 8/30/2023 15:51
>>>>>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam
>>>>>> <orika@nvidia.com>
>>>>>> Cc: dev@dpdk.org; fengchengwen@huawei.com; Ivan Malov
>>>>>> <ivan.malov@arknetworks.am>
>>>>>> Subject: Re: [PATCH v2 1/2] ethdev: add new symmetric hash function
>>>>>>
>>>>>> Hi Xueming,
>>>>>>
>>>>>> 在 2023/8/27 16:17, Xueming Li 写道:
>>>>>>> The new symmetric hash function swap src/dst L3 address and
>>>>>>> L4 ports automatically by sorting.
>>>>>>>
>>>>>>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
>>>>>>> ---
>>>>>>>      lib/ethdev/rte_flow.h | 7 +++++++
>>>>>>>      1 file changed, 7 insertions(+)
>>>>>>>
>>>>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>>>>>> 2ebb76dbc0..4f4421ca50 100644
>>>>>>> --- a/lib/ethdev/rte_flow.h
>>>>>>> +++ b/lib/ethdev/rte_flow.h
>>>>>>> @@ -3196,6 +3196,13 @@ enum rte_eth_hash_function {
>>>>>>>      	 * src or dst address will xor with zero pair.
>>>>>>>      	 */
>>>>>>>      	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>>>>>>> +	/**
>>>>>>> +	 * Symmetric Toeplitz: L3 and L4 fields are sorted prior to
>>>>>>> +	 * the hash function.
>>>>>>> +	 *  If src_ip > dst_ip, swap src_ip and dst_ip.
>>>>>>> +	 *  If src_port > dst_port, swap src_port and dst_port.
>>>>>>> +	 */
>>>>>> If hash result are computed by the order:
>>>> "src_ip+dst_ip+src_port+dst_port"
>>>>>> How to obtain the value of every L3 and L4 field obove?
>>>>>> I still cannot understand how to swap and set these values for these
>> fields?
>>>>> Hash result is computed by order ""src_ip+dst_ip+src_port+dst_port"
>>>>> Here is a detailed explanation of standard hash and symmetric hash by
>> key:
>>>>>      https://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf
>>>>>
>>>>> If src_ip > dst_ip, swap them, then the input becomes:
>>>>>      "dst_ip+src_ip+src_port+dst_port" // please note src and dst IP
>>>>> are
>>>> swapped.
>>>>> Same for L4 ports.
>>>> get it.
>>>> What are the advantages of the symmetric toeplitz sort?
>>>> Or why swap here?
>>> It's a different symmetric hash calculation, hardware can support either/all
>> of them.
>>>   From calculation perspective, the hash result distribution is better,
>>> the result is more suitable to be used as hash table key.
>> I get it now.
>> but I have a question.
>> why not is that if src_ip < dst_ip, then swap src_ip and dst_ip?
>> I guess this is going to have the same effect as you said, right?
>> The symmetric toeplitz sort is not a standard algorithm, is just to enhance the
>> hash result distribution.
>> If what I understand is right,
>> it is better that the new RSS algorithm should works on the one of them
>> ("src_ip > dst_ip" or "src_ip < dst_ip").
> Any special reason to introduce the descending sort?
Because the descending sort also can achieve the goal.
After all, this doesn't seem like a standard algorithm.

> I personally prefer to keep the enum clean unless some new hw or new algorithm introduced.

Agree with you. But this new enum cannot reveal ascending or descending 
sort.

>
>>>>>>> +	RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT,
>>>>>>>      	RTE_ETH_HASH_FUNCTION_MAX,
>>>>>>>      };
>>>>>>>

[PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function

[Xueming Li]

This patch supports the new RSS symmetric hash function:
RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT

The new hash function makes symmetric hash result by swapping
the source and destination IP and L4 port automatically.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 3a97975d69..e162baa7da 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -1456,8 +1456,8 @@ struct rte_flow_template_table {
 #define MLX5_RSS_HASH_NONE 0ULL
 
 #define MLX5_RSS_IS_SYMM(func) \
-		((func) == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
-
+		(((func) == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) || \
+		 ((func) == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT))
 
 /* extract next protocol type from Ethernet & VLAN headers */
 #define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
-- 
2.25.1

RE: [PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function

[Ori Kam]

> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Sunday, August 27, 2023 11:18 AM
> 
> This patch supports the new RSS symmetric hash function:
> RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT
> 
> The new hash function makes symmetric hash result by swapping
> the source and destination IP and L4 port automatically.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---


Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori

RE: [PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function

[Raslan Darawsheh]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Hi,

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Sunday, August 27, 2023 11:18 AM
> To: Ori Kam <orika@nvidia.com>
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; dev@dpdk.org;
> fengchengwen@huawei.com; Ivan Malov <ivan.malov@arknetworks.am>
> Subject: [PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function
> 
> This patch supports the new RSS symmetric hash function:
> RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT
> 
> The new hash function makes symmetric hash result by swapping the source
> and destination IP and L4 port automatically.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 15245 bytes --]