From: <wanry@3snic.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@amd.com>, Renyong Wan <wanry@3snic.com>,
Steven Song <steven.song@3snic.com>
Subject: [PATCH v2 13/32] net/sssnic: support link status event
Date: Thu, 31 Aug 2023 17:56:31 +0800 [thread overview]
Message-ID: <20230831095650.219964-14-wanry@3snic.com> (raw)
In-Reply-To: <20230831095650.219964-1-wanry@3snic.com>
From: Renyong Wan <wanry@3snic.com>
Signed-off-by: Steven Song <steven.song@3snic.com>
Signed-off-by: Renyong Wan <wanry@3snic.com>
---
v2:
* Fixed 'EINVAL' undeclared.
---
doc/guides/nics/features/sssnic.ini | 1 +
drivers/net/sssnic/base/meson.build | 1 +
drivers/net/sssnic/base/sssnic_exception.c | 116 +++++++++++++++++++++
drivers/net/sssnic/base/sssnic_exception.h | 10 ++
drivers/net/sssnic/base/sssnic_hw.c | 46 ++++++++
drivers/net/sssnic/base/sssnic_hw.h | 22 ++++
drivers/net/sssnic/sssnic_ethdev.c | 6 +-
drivers/net/sssnic/sssnic_ethdev_link.c | 98 +++++++++++++++++
drivers/net/sssnic/sssnic_ethdev_link.h | 2 +
9 files changed, 301 insertions(+), 1 deletion(-)
create mode 100644 drivers/net/sssnic/base/sssnic_exception.c
create mode 100644 drivers/net/sssnic/base/sssnic_exception.h
diff --git a/doc/guides/nics/features/sssnic.ini b/doc/guides/nics/features/sssnic.ini
index a0688e70ef..82b527ba26 100644
--- a/doc/guides/nics/features/sssnic.ini
+++ b/doc/guides/nics/features/sssnic.ini
@@ -5,6 +5,7 @@
;
[Features]
Link status = Y
+Link status event = Y
Unicast MAC filter = Y
Multicast MAC filter = Y
Linux = Y
diff --git a/drivers/net/sssnic/base/meson.build b/drivers/net/sssnic/base/meson.build
index e93ca7b24b..cf0c177cab 100644
--- a/drivers/net/sssnic/base/meson.build
+++ b/drivers/net/sssnic/base/meson.build
@@ -9,6 +9,7 @@ sources = [
'sssnic_workq.c',
'sssnic_ctrlq.c',
'sssnic_api.c',
+ 'sssnic_exception.c',
]
c_args = cflags
diff --git a/drivers/net/sssnic/base/sssnic_exception.c b/drivers/net/sssnic/base/sssnic_exception.c
new file mode 100644
index 0000000000..738ca9c6cd
--- /dev/null
+++ b/drivers/net/sssnic/base/sssnic_exception.c
@@ -0,0 +1,116 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018-2022 Shenzhen 3SNIC Information Technology Co., Ltd.
+ */
+
+#include <rte_byteorder.h>
+#include <rte_common.h>
+#include <ethdev_pci.h>
+
+#include "../sssnic_log.h"
+#include "sssnic_hw.h"
+#include "sssnic_reg.h"
+#include "sssnic_cmd.h"
+#include "sssnic_msg.h"
+#include "sssnic_eventq.h"
+#include "sssnic_mbox.h"
+#include "sssnic_exception.h"
+
+static void
+sssnic_link_event_msg_handle(struct sssnic_hw *hw, struct sssnic_msg *msg,
+ __rte_unused enum sssnic_msg_chann_id chan_id)
+{
+ struct sssnic_netif_link_status_get_cmd *cmd;
+ sssnic_link_event_cb_t *cb;
+ enum sssnic_link_status status;
+ void *priv;
+
+ cb = hw->link_event_handler.cb;
+ priv = hw->link_event_handler.priv;
+
+ cmd = (struct sssnic_netif_link_status_get_cmd *)msg->data_buf;
+ if (cb != NULL) {
+ if (cmd->status)
+ status = SSSNIC_LINK_STATUS_UP;
+ else
+ status = SSSNIC_LINK_STATUS_DOWN;
+
+ PMD_DRV_LOG(DEBUG, "Received sssnic%u link %s event",
+ SSSNIC_ETH_PORT_ID(hw), status ? "up" : "down");
+
+ return cb(cmd->port, status, priv);
+ }
+
+ PMD_DRV_LOG(WARNING, "Link event was not processed, port=%u, status=%u",
+ cmd->port, cmd->status);
+}
+
+static void
+sssnic_netif_vf_link_status_msg_handle(struct sssnic_hw *hw,
+ struct sssnic_msg *msg)
+{
+ int ret;
+
+ if (msg->ack != 0) {
+ msg->ack = 0;
+ msg->type = SSSNIC_MSG_TYPE_RESP;
+ msg->data_len = 1; /* indicate no data */
+ ret = sssnic_mbox_send(hw, msg, NULL, 0, 0);
+ if (ret != 0)
+ PMD_DRV_LOG(ERR,
+ "Failed to send VF link status response, ret=%d",
+ ret);
+ }
+}
+
+static void
+sssnic_netif_exception_msg_handle(struct sssnic_hw *hw, struct sssnic_msg *msg,
+ enum sssnic_msg_chann_id chan_id)
+{
+ if (msg->command == SSSNIC_GET_NETIF_LINK_STATUS_CMD) {
+ if (SSSNIC_FUNC_TYPE(hw) == SSSNIC_FUNC_TYPE_VF)
+ sssnic_netif_vf_link_status_msg_handle(hw, msg);
+
+ sssnic_link_event_msg_handle(hw, msg, chan_id);
+ return;
+ }
+
+ PMD_DRV_LOG(WARNING,
+ "Netif exception message was not processed, cmd=%u",
+ msg->command);
+}
+
+static int
+sssnic_exception_msg_process(struct sssnic_msg *msg,
+ enum sssnic_msg_chann_id chan_id, void *priv)
+{
+ struct sssnic_hw *hw = (struct sssnic_hw *)priv;
+
+ SSSNIC_DEBUG("command=%u, func=%u module=%u, type=%u, ack=%u, seq=%u, "
+ "status=%u, id=%u data_buf=%p, data_len=%u",
+ msg->command, msg->func, msg->module, msg->type, msg->ack,
+ msg->seg, msg->status, msg->id, msg->data_buf, msg->data_len);
+
+ if (msg->module == SSSNIC_NETIF_MODULE) {
+ sssnic_netif_exception_msg_handle(hw, msg, chan_id);
+ return SSSNIC_MSG_DONE;
+ }
+
+ PMD_DRV_LOG(WARNING, "Exception message was not processed, moule=%u",
+ msg->module);
+
+ return SSSNIC_MSG_DONE;
+}
+
+int
+sssnic_exception_process_init(struct sssnic_hw *hw)
+{
+ if (hw == NULL)
+ return -EINVAL;
+
+ sssnic_msg_rx_handler_register(hw, SSSNIC_MSG_CHAN_MPU,
+ SSSNIC_MSG_TYPE_REQ, sssnic_exception_msg_process, hw);
+ sssnic_msg_rx_handler_register(hw, SSSNIC_MSG_CHAN_MBOX,
+ SSSNIC_MSG_TYPE_REQ, sssnic_exception_msg_process, hw);
+
+ return 0;
+}
diff --git a/drivers/net/sssnic/base/sssnic_exception.h b/drivers/net/sssnic/base/sssnic_exception.h
new file mode 100644
index 0000000000..46f2f7465b
--- /dev/null
+++ b/drivers/net/sssnic/base/sssnic_exception.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018-2022 Shenzhen 3SNIC Information Technology Co., Ltd.
+ */
+
+#ifndef _SSSNIC_EXCEPTION_H_
+#define _SSSNIC_EXCEPTION_H_
+
+int sssnic_exception_process_init(struct sssnic_hw *hw);
+
+#endif /* _SSSNIC_EXCEPTION_H_ */
diff --git a/drivers/net/sssnic/base/sssnic_hw.c b/drivers/net/sssnic/base/sssnic_hw.c
index 8f5f556bde..82eb4ea295 100644
--- a/drivers/net/sssnic/base/sssnic_hw.c
+++ b/drivers/net/sssnic/base/sssnic_hw.c
@@ -15,6 +15,7 @@
#include "sssnic_msg.h"
#include "sssnic_mbox.h"
#include "sssnic_ctrlq.h"
+#include "sssnic_exception.h"
static int
wait_for_sssnic_hw_ready(struct sssnic_hw *hw)
@@ -133,6 +134,17 @@ sssnic_msix_all_disable(struct sssnic_hw *hw)
sssnic_msix_state_set(hw, i, SSSNIC_MSIX_DISABLE);
}
+void
+sssnic_msix_resend_disable(struct sssnic_hw *hw, uint16_t msix_id)
+{
+ struct sssnic_msix_ctrl_reg reg;
+
+ reg.u32 = 0;
+ reg.resend_timer_clr = SSSNIC_MSIX_DISABLE;
+ reg.msxi_idx = msix_id;
+ sssnic_cfg_reg_write(hw, SSSNIC_MSIX_CTRL_REG, reg.u32);
+}
+
static void
sssnic_pf_status_set(struct sssnic_hw *hw, enum sssnic_pf_status status)
{
@@ -276,6 +288,38 @@ sssnic_capability_init(struct sssnic_hw *hw)
return 0;
}
+int
+sssnic_link_event_callback_register(struct sssnic_hw *hw,
+ sssnic_link_event_cb_t *cb, void *priv)
+{
+ if (hw == NULL || cb == NULL)
+ return -EINVAL;
+
+ hw->link_event_handler.cb = cb;
+ hw->link_event_handler.priv = priv;
+
+ return 0;
+}
+
+void
+sssnic_link_event_callback_unregister(struct sssnic_hw *hw)
+{
+ if (hw != NULL) {
+ hw->link_event_handler.cb = NULL;
+ hw->link_event_handler.priv = NULL;
+ }
+}
+
+void
+sssnic_link_intr_handle(struct sssnic_hw *hw)
+{
+ PMD_DRV_LOG(DEBUG, "sssnic%u link interrupt triggered!",
+ SSSNIC_ETH_PORT_ID(hw));
+
+ sssnic_msix_resend_disable(hw, SSSNIC_LINK_INTR_MSIX_ID);
+ sssnic_eventq_flush(hw, SSSNIC_LINK_INTR_EVENTQ, 0);
+}
+
static int
sssnic_base_init(struct sssnic_hw *hw)
{
@@ -389,6 +433,8 @@ sssnic_hw_init(struct sssnic_hw *hw)
goto capbility_init_fail;
}
+ sssnic_exception_process_init(hw);
+
sssnic_pf_status_set(hw, SSSNIC_PF_STATUS_ACTIVE);
return 0;
diff --git a/drivers/net/sssnic/base/sssnic_hw.h b/drivers/net/sssnic/base/sssnic_hw.h
index f8fe2ac7e1..e25f5595e6 100644
--- a/drivers/net/sssnic/base/sssnic_hw.h
+++ b/drivers/net/sssnic/base/sssnic_hw.h
@@ -44,6 +44,22 @@ struct sssnic_hw_attr {
uint16_t num_irq;
};
+enum sssnic_link_status {
+ SSSNIC_LINK_STATUS_DOWN,
+ SSSNIC_LINK_STATUS_UP,
+};
+
+#define SSSNIC_LINK_INTR_MSIX_ID 0
+#define SSSNIC_LINK_INTR_EVENTQ 0
+
+typedef void sssnic_link_event_cb_t(uint8_t port,
+ enum sssnic_link_status status, void *priv);
+
+struct sssnic_link_event_handler {
+ sssnic_link_event_cb_t *cb;
+ void *priv;
+};
+
struct sssnic_hw {
struct rte_pci_device *pci_dev;
uint8_t *cfg_base_addr;
@@ -55,6 +71,7 @@ struct sssnic_hw {
struct sssnic_msg_inbox *msg_inbox;
struct sssnic_mbox *mbox;
struct sssnic_ctrlq *ctrlq;
+ struct sssnic_link_event_handler link_event_handler;
uint8_t num_eventqs;
uint8_t phy_port;
uint16_t eth_port_id;
@@ -82,5 +99,10 @@ enum sssnic_module {
int sssnic_hw_init(struct sssnic_hw *hw);
void sssnic_hw_shutdown(struct sssnic_hw *hw);
void sssnic_msix_state_set(struct sssnic_hw *hw, uint16_t msix_id, int state);
+void sssnic_msix_resend_disable(struct sssnic_hw *hw, uint16_t msix_id);
+int sssnic_link_event_callback_register(struct sssnic_hw *hw,
+ sssnic_link_event_cb_t *cb, void *priv);
+void sssnic_link_event_callback_unregister(struct sssnic_hw *hw);
+void sssnic_link_intr_handle(struct sssnic_hw *hw);
#endif /* _SSSNIC_HW_H_ */
diff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c
index 4e546cca66..1e2b5c0450 100644
--- a/drivers/net/sssnic/sssnic_ethdev.c
+++ b/drivers/net/sssnic/sssnic_ethdev.c
@@ -334,6 +334,7 @@ sssnic_ethdev_release(struct rte_eth_dev *ethdev)
{
struct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);
+ sssnic_ethdev_link_intr_disable(ethdev);
sssnic_ethdev_mac_addrs_clean(ethdev);
sssnic_hw_shutdown(hw);
rte_free(hw);
@@ -391,6 +392,9 @@ sssnic_ethdev_init(struct rte_eth_dev *ethdev)
ethdev->dev_ops = &sssnic_ethdev_ops;
+ sssnic_ethdev_link_update(ethdev, 0);
+ sssnic_ethdev_link_intr_enable(ethdev);
+
return 0;
mac_addrs_init_fail:
@@ -440,7 +444,7 @@ static const struct rte_pci_id sssnic_pci_id_map[] = {
static struct rte_pci_driver sssnic_pmd = {
.id_table = sssnic_pci_id_map,
- .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
+ .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
.probe = sssnic_pci_probe,
.remove = sssnic_pci_remove,
};
diff --git a/drivers/net/sssnic/sssnic_ethdev_link.c b/drivers/net/sssnic/sssnic_ethdev_link.c
index 04e2d2e5d2..9e932c51dd 100644
--- a/drivers/net/sssnic/sssnic_ethdev_link.c
+++ b/drivers/net/sssnic/sssnic_ethdev_link.c
@@ -109,3 +109,101 @@ sssnic_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)
out:
return rte_eth_linkstatus_set(ethdev, &link);
}
+
+static void
+sssnic_ethdev_link_status_print(struct rte_eth_dev *ethdev,
+ struct rte_eth_link *link)
+{
+ if (link->link_status) {
+ PMD_DRV_LOG(INFO, "Port %u Link Up - speed %s - %s",
+ ethdev->data->port_id,
+ rte_eth_link_speed_to_str(link->link_speed),
+ link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX ?
+ "full-duplex" :
+ "half-duplex");
+ } else {
+ PMD_DRV_LOG(INFO, "Port %u Link Down", ethdev->data->port_id);
+ }
+}
+
+static void
+sssnic_ethdev_link_event_cb(__rte_unused uint8_t port,
+ __rte_unused enum sssnic_link_status status, void *arg)
+{
+ struct rte_eth_dev *ethdev = (struct rte_eth_dev *)arg;
+ struct rte_eth_link link;
+ int ret;
+
+ memset(&link, 0, sizeof(link));
+ sssnic_ethdev_link_get(ethdev, &link);
+
+ ret = rte_eth_linkstatus_set(ethdev, &link);
+ if (ret == 0) {
+ sssnic_ethdev_link_status_print(ethdev, &link);
+ rte_eth_dev_callback_process(ethdev, RTE_ETH_EVENT_INTR_LSC,
+ NULL);
+ }
+}
+
+static void
+sssnic_ethdev_link_intr_callback(void *arg)
+{
+ struct rte_eth_dev *ethdev = (struct rte_eth_dev *)arg;
+ struct sssnic_hw *hw;
+
+ hw = SSSNIC_ETHDEV_TO_HW(ethdev);
+
+ sssnic_link_intr_handle(hw);
+}
+
+void
+sssnic_ethdev_link_intr_enable(struct rte_eth_dev *ethdev)
+{
+ struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(ethdev);
+ struct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);
+ int ret;
+
+ sssnic_link_event_callback_register(hw, sssnic_ethdev_link_event_cb,
+ ethdev);
+
+ ret = rte_intr_callback_register(pci_dev->intr_handle,
+ sssnic_ethdev_link_intr_callback, ethdev);
+ if (ret != 0) {
+ PMD_DRV_LOG(ERR, "Failed to register port %u intr callback!",
+ ethdev->data->port_id);
+
+ sssnic_link_event_callback_unregister(hw);
+
+ return;
+ }
+
+ ret = rte_intr_enable(pci_dev->intr_handle);
+ if (ret != 0) {
+ PMD_DRV_LOG(ERR, "Failed to enable port %u interrupt!",
+ ethdev->data->port_id);
+
+ rte_intr_callback_unregister(pci_dev->intr_handle,
+ sssnic_ethdev_link_intr_callback, ethdev);
+ sssnic_link_event_callback_unregister(hw);
+
+ return;
+ }
+
+ sssnic_msix_state_set(hw, SSSNIC_LINK_INTR_MSIX_ID, SSSNIC_MSIX_ENABLE);
+}
+
+void
+sssnic_ethdev_link_intr_disable(struct rte_eth_dev *ethdev)
+{
+ struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(ethdev);
+ struct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);
+
+ sssnic_msix_state_set(hw, SSSNIC_LINK_INTR_MSIX_ID,
+ SSSNIC_MSIX_DISABLE);
+
+ rte_intr_disable(pci_dev->intr_handle);
+ rte_intr_callback_unregister(pci_dev->intr_handle,
+ sssnic_ethdev_link_intr_callback, ethdev);
+
+ sssnic_link_event_callback_unregister(hw);
+}
diff --git a/drivers/net/sssnic/sssnic_ethdev_link.h b/drivers/net/sssnic/sssnic_ethdev_link.h
index 00ad13fe9b..52a86b4771 100644
--- a/drivers/net/sssnic/sssnic_ethdev_link.h
+++ b/drivers/net/sssnic/sssnic_ethdev_link.h
@@ -8,5 +8,7 @@
int sssnic_ethdev_set_link_up(struct rte_eth_dev *ethdev);
int sssnic_ethdev_set_link_down(struct rte_eth_dev *ethdev);
int sssnic_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete);
+void sssnic_ethdev_link_intr_enable(struct rte_eth_dev *ethdev);
+void sssnic_ethdev_link_intr_disable(struct rte_eth_dev *ethdev);
#endif /* _SSSNIC_ETHDEV_LINK_H_ */
--
2.27.0
next prev parent reply other threads:[~2023-08-31 9:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 9:56 [PATCH v2 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters wanry
2023-08-31 9:56 ` [PATCH v2 01/32] net/sssnic: add build and doc infrastructure wanry
2023-08-31 9:56 ` [PATCH v2 02/32] net/sssnic: add log type and log macros wanry
2023-08-31 9:56 ` [PATCH v2 03/32] net/sssnic: support probe and remove wanry
2023-08-31 9:56 ` [PATCH v2 04/32] net/sssnic: initialize hardware base wanry
2023-08-31 9:56 ` [PATCH v2 05/32] net/sssnic: add event queue wanry
2023-08-31 9:56 ` [PATCH v2 06/32] net/sssnic/base: add message definition and utility wanry
2023-08-31 9:56 ` [PATCH v2 07/32] net/sssnic/base: add mailbox support wanry
2023-08-31 9:56 ` [PATCH v2 08/32] net/sssnic/base: add work queue wanry
2023-08-31 9:56 ` [PATCH v2 09/32] net/sssnic/base: add control queue wanry
2023-08-31 9:56 ` [PATCH v2 10/32] net/sssnic: add dev configure and infos get wanry
2023-08-31 9:56 ` [PATCH v2 11/32] net/sssnic: add dev MAC ops wanry
2023-08-31 9:56 ` [PATCH v2 12/32] net/sssnic: support dev link status wanry
2023-08-31 9:56 ` wanry [this message]
2023-08-31 9:56 ` [PATCH v2 14/32] net/sssnic: support Rx queue setup and release wanry
2023-08-31 9:56 ` [PATCH v2 15/32] net/sssnic: support Tx " wanry
2023-08-31 9:56 ` [PATCH v2 16/32] net/sssnic: support Rx queue start and stop wanry
2023-08-31 9:56 ` [PATCH v2 17/32] net/sssnic: support Tx " wanry
2023-08-31 9:56 ` [PATCH v2 18/32] net/sssnic: add Rx interrupt support wanry
2023-08-31 9:56 ` [PATCH v2 19/32] net/sssnic: support dev start and stop wanry
2023-08-31 9:56 ` [PATCH v2 20/32] net/sssnic: support dev close and reset wanry
2023-08-31 9:56 ` [PATCH v2 21/32] net/sssnic: add allmulticast and promiscuous ops wanry
2023-08-31 9:56 ` [PATCH v2 22/32] net/sssnic: add basic and extended stats ops wanry
2023-08-31 9:56 ` [PATCH v2 23/32] net/sssnic: support Rx packet burst wanry
2023-08-31 9:56 ` [PATCH v2 24/32] net/sssnic: support Tx " wanry
2023-08-31 9:56 ` [PATCH v2 25/32] net/sssnic: add RSS support wanry
2023-08-31 9:56 ` [PATCH v2 26/32] net/sssnic: support dev MTU set wanry
2023-08-31 9:56 ` [PATCH v2 27/32] net/sssnic: support dev queue info get wanry
2023-08-31 9:56 ` [PATCH v2 28/32] net/sssnic: support dev firmware version get wanry
2023-08-31 9:56 ` [PATCH v2 29/32] net/sssnic: add dev flow control ops wanry
2023-08-31 9:56 ` [PATCH v2 30/32] net/sssnic: support VLAN offload and filter wanry
2023-08-31 9:56 ` [PATCH v2 31/32] net/sssnic: add generic flow ops wanry
2023-08-31 9:56 ` [PATCH v2 32/32] net/sssnic: add VF dev support wanry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831095650.219964-14-wanry@3snic.com \
--to=wanry@3snic.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=steven.song@3snic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).