DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	jingjing.wu@intel.com, stable@dpdk.org
Subject: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure
Date: Thu, 31 Aug 2023 13:33:36 +0100	[thread overview]
Message-ID: <20230831123337.871496-4-bruce.richardson@intel.com> (raw)
In-Reply-To: <20230831123337.871496-1-bruce.richardson@intel.com>

After reconfiguring an RX queue the mbuf_initializer value was not being
correctly set. Fix this by calling the appropriate function if vector
processing is enabled. This mirrors the behaviour by the i40e driver.

Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
Cc: jingjing.wu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/iavf/iavf_rxtx.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index f7df4665d1..797cdda4b2 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -755,6 +755,13 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
 	if (check_rx_vec_allow(rxq) == false)
 		ad->rx_vec_allowed = false;
 
+#if defined RTE_ARCH_X86 || defined RTE_ARCH_ARM
+	/* check vector conflict */
+	if (ad->rx_vec_allowed && iavf_rxq_vec_setup(rxq)) {
+		PMD_DRV_LOG(ERR, "Failed vector rx setup.");
+		return -EINVAL;
+	}
+#endif
 	return 0;
 }
 
-- 
2.39.2


  parent reply	other threads:[~2023-08-31 12:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 15:59 [PATCH 0/4] Fix i40e/iavf queue reconfig and restarting Bruce Richardson
2023-08-30 15:59 ` [PATCH 1/4] net/i40e: fix buffer leak on Rx reconfiguration Bruce Richardson
2023-08-30 15:59 ` [PATCH 2/4] net/iavf: fix buffer leak on Tx queue stop Bruce Richardson
2023-08-30 15:59 ` [PATCH 3/4] net/iavf: fix restart of Rx queue on reconfigure Bruce Richardson
2023-08-30 15:59 ` [PATCH 4/4] net/iavf: add support for runtime queue reconfiguration Bruce Richardson
2023-08-31 12:33 ` [PATCH v2 0/4] Fix i40e/iavf queue reconfig and restarting Bruce Richardson
2023-08-31 12:33   ` [PATCH v2 1/4] net/i40e: fix buffer leak on Rx reconfiguration Bruce Richardson
2023-09-01  7:12     ` Zhang, Qi Z
2023-08-31 12:33   ` [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop Bruce Richardson
2023-09-04  2:17     ` Lu, Wenzhuo
2023-09-04  2:30       ` Zhang, Qi Z
2023-08-31 12:33   ` Bruce Richardson [this message]
2023-09-04  1:15     ` [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure Zhang, Qi Z
2023-09-04  1:30       ` Zhang, Qi Z
2023-09-04  7:54         ` Bruce Richardson
2023-09-05  0:02           ` Zhang, Qi Z
2023-08-31 12:33   ` [PATCH v2 4/4] net/iavf: add support for runtime queue reconfiguration Bruce Richardson
2023-09-05  2:25     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831123337.871496-4-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).