DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] eal: provide per lcore macros for MSVC
Date: Thu, 31 Aug 2023 16:08:13 -0700	[thread overview]
Message-ID: <20230831230812.GA31929@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <2619168.k3LOHGUjKi@thomas>

On Thu, Aug 31, 2023 at 01:57:36PM +0200, Thomas Monjalon wrote:
> 11/07/2023 17:52, Tyler Retzlaff:
> > +#ifdef RTE_TOOLCHAIN_MSVC
> >  /**
> >   * Macro to define a per lcore variable "var" of type "type", don't
> >   * use keywords like "static" or "volatile" in type, just prefix the
> >   * whole macro.
> >   */
> >  #define RTE_DEFINE_PER_LCORE(type, name)			\
> > -	__thread __typeof__(type) per_lcore_##name
> > +	__declspec(thread) typeof(type) per_lcore_##name
> >  
> >  /**
> >   * Macro to declare an extern per lcore variable "var" of type "type"
> >   */
> >  #define RTE_DECLARE_PER_LCORE(type, name)			\
> > +	extern __declspec(thread) typeof(type) per_lcore_##name
> > +#else
> > +#define RTE_DEFINE_PER_LCORE(type, name)			\
> > +	__thread __typeof__(type) per_lcore_##name
> > +
> > +#define RTE_DECLARE_PER_LCORE(type, name)			\
> >  	extern __thread __typeof__(type) per_lcore_##name
> > +#endif
> 
> I'm afraid you damaged the doxygen document here.
> Please check what happens when generating doxygen.
> I suppose it does not take the RTE_TOOLCHAIN_MSVC path,
> so it does not find any comment.

Thanks Thomas i will look into fixing it.

> 
> 

  reply	other threads:[~2023-08-31 23:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 21:29 [PATCH] provide Windows/MSVC lcore macros Tyler Retzlaff
2023-07-10 21:29 ` [PATCH] eal: provide per lcore macros for MSVC Tyler Retzlaff
2023-07-11  6:25   ` Thomas Monjalon
2023-07-11 15:52 ` [PATCH v2] provide Windows/MSVC lcore macros Tyler Retzlaff
2023-07-11 15:52   ` [PATCH v2] eal: provide per lcore macros for MSVC Tyler Retzlaff
2023-07-11 16:09     ` Stephen Hemminger
2023-08-25  8:49       ` David Marchand
2023-08-31 11:57     ` Thomas Monjalon
2023-08-31 23:08       ` Tyler Retzlaff [this message]
2023-09-21  9:36         ` Thomas Monjalon
2023-09-21 15:45           ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831230812.GA31929@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).