From: <pbhagavatula@marvell.com>
To: <jerinj@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>,
"Shijith Thotton" <sthotton@marvell.com>
Cc: <dev@dpdk.org>
Subject: [PATCH 2/3] event/cnxk: remove checks from op release
Date: Tue, 5 Sep 2023 22:09:07 +0530 [thread overview]
Message-ID: <20230905163908.19946-2-pbhagavatula@marvell.com> (raw)
In-Reply-To: <20230905163908.19946-1-pbhagavatula@marvell.com>
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Remove expensive fastpath checks from op release, remove
explicit release in CN9K tx routine.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
drivers/event/cnxk/cn9k_worker.h | 17 -----------------
drivers/event/cnxk/cnxk_worker.h | 6 ------
2 files changed, 23 deletions(-)
diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
index 9ddab095ac..ee659e80d6 100644
--- a/drivers/event/cnxk/cn9k_worker.h
+++ b/drivers/event/cnxk/cn9k_worker.h
@@ -156,15 +156,6 @@ cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base,
}
}
-static __rte_always_inline void
-cn9k_sso_tx_tag_flush(uint64_t base)
-{
- if (unlikely(CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) ==
- SSO_TT_EMPTY))
- return;
- plt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH);
-}
-
static __rte_always_inline void
cn9k_wqe_to_mbuf(uint64_t wqe, const uint64_t mbuf, uint8_t port_id,
const uint32_t tag, const uint32_t flags,
@@ -727,7 +718,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd,
uint64_t *txq_data, const uint32_t flags)
{
struct rte_mbuf *m = ev->mbuf;
- uint16_t ref_cnt = m->refcnt;
struct cn9k_eth_txq *txq;
/* Perform header writes before barrier for TSO */
@@ -800,13 +790,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd,
}
done:
- if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
- if (ref_cnt > 1)
- return 1;
- }
-
- cn9k_sso_tx_tag_flush(base);
-
return 1;
}
diff --git a/drivers/event/cnxk/cnxk_worker.h b/drivers/event/cnxk/cnxk_worker.h
index 2bd41f8a5e..0e0d728ba4 100644
--- a/drivers/event/cnxk/cnxk_worker.h
+++ b/drivers/event/cnxk/cnxk_worker.h
@@ -54,12 +54,6 @@ cnxk_sso_hws_swtag_untag(uintptr_t swtag_untag_op)
static __rte_always_inline void
cnxk_sso_hws_swtag_flush(uint64_t base)
{
- /* Ensure that there is no previous flush is pending. */
- while (plt_read64(base + SSOW_LF_GWS_PENDSTATE) & BIT_ULL(56))
- ;
- if (CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) ==
- SSO_TT_EMPTY)
- return;
plt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH);
}
--
2.41.0
next prev parent reply other threads:[~2023-09-05 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 16:39 [PATCH 1/3] cnxk/event: invalidate GWC on port reset pbhagavatula
2023-09-05 16:39 ` pbhagavatula [this message]
2023-09-05 16:39 ` [PATCH 3/3] common/cnxk: use local labels in asm intrinsic pbhagavatula
2023-09-19 16:22 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905163908.19946-2-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).