From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CD9EF42527;
Wed, 6 Sep 2023 17:11:21 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C96BC402BC;
Wed, 6 Sep 2023 17:11:21 +0200 (CEST)
Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com
[209.85.210.173])
by mails.dpdk.org (Postfix) with ESMTP id 3BDAD402BC
for <dev@dpdk.org>; Wed, 6 Sep 2023 17:11:20 +0200 (CEST)
Received: by mail-pf1-f173.google.com with SMTP id
d2e1a72fcca58-68e26165676so779962b3a.0
for <dev@dpdk.org>; Wed, 06 Sep 2023 08:11:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1694013079;
x=1694617879; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=TgRGz+fjrXEV98Tg6iMdqqfEOESH66raBfOSqg7+5Tk=;
b=Z0fHlUo7ooOugcOeq8U08aRqx8OYlmcoR5sXQyk1WDOg9TEott5XaO5ybUCKFEsYF8
B1l2nbYef4thlg1lBlx+15VKjF1BaegOhilqjmJmrvpu991MyW3k31y0FXbpvAIZidDc
MpeCJhaG7jDHjrRXKe7xTQyKn55APMXEpjojxL3Crxtx8NkFfo8f7sGn6WzWLwBvhnHO
Txqfsp70O5O/d+/mR/pVSCj+VFD/Nu6yVJ4KYp+/NcCz4mN4yivquBGBmg8c1xovgNII
l4I65hsYf4owqL0A+X50s7+p5MCx7ZO6gv6QIvAjv0IsS4+w2Cp7V4rVQZ98+eOv5Wrq
Vpwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1694013079; x=1694617879;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=TgRGz+fjrXEV98Tg6iMdqqfEOESH66raBfOSqg7+5Tk=;
b=SlTnVq3QK6UHMUaOO8tGRH1PeWiZWayuM2nPGpoFzoGF04+vd6XIbjkSibH6HLMSZ9
sjcXkc3BHFWoLAC7c7vRkbrtil6Gv/ZCxfplBvRVogGUlarVW4eD5V60nVcm6ICrRVuj
6qs5W+6FW7o9pNjapHLMdEVmU4Osbn5T7cfoy57AvGaSTRIm57uXr/93paI5RHYBLUJw
9i80gE8sCgfqbmmEMHhmtA74V4h98J2KMT+lblvw1a0NvtTUbOD4pJ3xdcJRgTLn15D9
1QYLtzUMWtSaCiHArYReYbJhXzKZuT/uIggbD5EcJgsnUtxdJbEWtEkmKSMV4tDZfSzJ
Yukw==
X-Gm-Message-State: AOJu0YzZnBo8RuF/25D33S78467xTz4vAKxFPwnXB5xWSwS3DooF70fD
n49dF0UMxoRsVbleeqG7/XpW+A==
X-Google-Smtp-Source: AGHT+IG5McOizOXpR97tc+00aRTT2iVbfP7etmS3YVtU0ORqJmFbUnR3HM6pDkh4qERhlPlT8uiOSw==
X-Received: by 2002:a05:6a20:441c:b0:14e:2208:d62f with SMTP id
ce28-20020a056a20441c00b0014e2208d62fmr26319270pzb.22.1694013079403;
Wed, 06 Sep 2023 08:11:19 -0700 (PDT)
Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131])
by smtp.gmail.com with ESMTPSA id
z14-20020a63b04e000000b00563590be25esm11224015pgo.29.2023.09.06.08.11.18
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 06 Sep 2023 08:11:19 -0700 (PDT)
Date: Wed, 6 Sep 2023 08:11:17 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Trevor Tao <taozj888@163.com>
Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org
Subject: Re: [PATCH v1] examples/l3fwd: relax the RSS/Offload requirement
Message-ID: <20230906081117.32a61ec8@hermes.local>
In-Reply-To: <20230903040111.126695-1-taozj888@163.com>
References: <20230903040111.126695-1-taozj888@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Sun, 3 Sep 2023 04:01:11 +0000
Trevor Tao <taozj888@163.com> wrote:
> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS, and offload
> mode set to RTE_ETH_RX_OFFLOAD_CHECKSUM by default, but some hardware
> and/or virtual interface does not support the RSS and offload mode
> presupposed, e.g., some virtio interfaces in the cloud don't support
> RSS and may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/
> RTE_ETH_RX_OFFLOAD_TCP_CKSUM,
> but not RTE_ETH_RX_OFFLOAD_IPV4_CKSUM, and the error msg here:
>
> virtio_dev_configure(): RSS support requested but not supported by
> the device
> Port0 dev_configure = -95
>
> and:
> Ethdev port_id=0 requested Rx offloads 0xe does not match Rx offloads
> capabilities 0x201d in rte_eth_dev_configure()
>
> So to enable the l3fwd running in that environment, the Rx mode requirement
> can be relaxed to reflect the hardware feature reality here, and the l3fwd
> can run smoothly then.
> A warning msg would be provided to user in case it happens here.
>
> On the other side, enabling the software cksum check in case the
> hw support missing.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Trevor Tao <taozj888@163.com>
Multiple queue without RSS and rte_flow support is kind of useless.
All packets will arrive on one queue.