From: Erez Shitrit <erezsh@nvidia.com>
To: <valex@nvidia.com>, <thomas@monjalon.net>, <suanmingm@nvidia.com>,
"Matan Azrad" <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
"Ori Kam" <orika@nvidia.com>
Cc: <dev@dpdk.org>
Subject: [PATCH 3/4] net/mlx5/hws: print syndrome value on error
Date: Sun, 10 Sep 2023 17:03:18 +0300 [thread overview]
Message-ID: <20230910140319.3064208-3-erezsh@nvidia.com> (raw)
In-Reply-To: <20230910140319.3064208-1-erezsh@nvidia.com>
Print the syndrome of failure of FW command.
Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
Reviewed-by: Alex Vesker <valex@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_cmd.c | 48 ++++++++++++++++++++++---------
1 file changed, 34 insertions(+), 14 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c
index f9f220cc6a..7771aeb8cf 100644
--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c
+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c
@@ -4,6 +4,12 @@
#include "mlx5dr_internal.h"
+static uint32_t mlx5dr_cmd_get_syndrome(uint32_t *out)
+{
+ /* Assumption: syndrome is always the second u32 */
+ return be32toh(out[1]);
+}
+
int mlx5dr_cmd_destroy_obj(struct mlx5dr_devx_obj *devx_obj)
{
int ret;
@@ -39,7 +45,8 @@ mlx5dr_cmd_flow_table_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create FT");
+ DR_LOG(ERR, "Failed to create FT (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -73,7 +80,8 @@ mlx5dr_cmd_flow_table_modify(struct mlx5dr_devx_obj *devx_obj,
ret = mlx5_glue->devx_obj_modify(devx_obj->obj, in, sizeof(in), out, sizeof(out));
if (ret) {
- DR_LOG(ERR, "Failed to modify FT");
+ DR_LOG(ERR, "Failed to modify FT (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
}
@@ -96,7 +104,8 @@ mlx5dr_cmd_flow_table_query(struct mlx5dr_devx_obj *devx_obj,
ret = mlx5_glue->devx_obj_query(devx_obj->obj, in, sizeof(in), out, sizeof(out));
if (ret) {
- DR_LOG(ERR, "Failed to query FT");
+ DR_LOG(ERR, "Failed to query FT (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
return ret;
}
@@ -129,7 +138,8 @@ mlx5dr_cmd_flow_group_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create Flow group");
+ DR_LOG(ERR, "Failed to create Flow group(syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -182,7 +192,8 @@ mlx5dr_cmd_set_fte(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create FTE");
+ DR_LOG(ERR, "Failed to create FTE (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
goto free_devx;
}
@@ -325,7 +336,8 @@ mlx5dr_cmd_rtc_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create RTC");
+ DR_LOG(ERR, "Failed to create RTC (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -365,7 +377,8 @@ mlx5dr_cmd_stc_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create STC");
+ DR_LOG(ERR, "Failed to create STC (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -505,7 +518,8 @@ mlx5dr_cmd_stc_modify(struct mlx5dr_devx_obj *devx_obj,
ret = mlx5_glue->devx_obj_modify(devx_obj->obj, in, sizeof(in), out, sizeof(out));
if (ret) {
- DR_LOG(ERR, "Failed to modify STC FW action_type %d", stc_attr->action_type);
+ DR_LOG(ERR, "Failed to modify STC FW action_type %d (syndrome: %#x)",
+ stc_attr->action_type, mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
}
@@ -542,7 +556,8 @@ mlx5dr_cmd_arg_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create ARG");
+ DR_LOG(ERR, "Failed to create ARG (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -606,7 +621,8 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create header_modify_pattern");
+ DR_LOG(ERR, "Failed to create header_modify_pattern (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
goto free_obj;
}
@@ -649,7 +665,8 @@ mlx5dr_cmd_ste_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create STE");
+ DR_LOG(ERR, "Failed to create STE (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -708,7 +725,8 @@ mlx5dr_cmd_definer_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create Definer");
+ DR_LOG(ERR, "Failed to create Definer (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
@@ -775,7 +793,8 @@ int mlx5dr_cmd_sq_modify_rdy(struct mlx5dr_devx_obj *devx_obj)
ret = mlx5_glue->devx_obj_modify(devx_obj->obj, in, sizeof(in), out, sizeof(out));
if (ret) {
- DR_LOG(ERR, "Failed to modify SQ");
+ DR_LOG(ERR, "Failed to modify SQ (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
}
@@ -843,7 +862,8 @@ mlx5dr_cmd_alias_obj_create(struct ibv_context *ctx,
devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));
if (!devx_obj->obj) {
- DR_LOG(ERR, "Failed to create ALIAS OBJ");
+ DR_LOG(ERR, "Failed to create ALIAS OBJ (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
simple_free(devx_obj);
rte_errno = errno;
return NULL;
--
2.18.2
next prev parent reply other threads:[~2023-09-10 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 14:03 [PATCH 1/4] net/mlx5/hws: allow relaxed mode in MPLS matching Erez Shitrit
2023-09-10 14:03 ` [PATCH 2/4] net/mlx5/hws: allow attaching action template to matcher Erez Shitrit
2023-09-10 14:03 ` Erez Shitrit [this message]
2023-09-10 14:03 ` [PATCH 4/4] net/mlx5/hws: skip process action-template on coll matcher Erez Shitrit
2023-09-19 12:02 ` [PATCH 1/4] net/mlx5/hws: allow relaxed mode in MPLS matching Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230910140319.3064208-3-erezsh@nvidia.com \
--to=erezsh@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=valex@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).