From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3791E42575;
	Tue, 12 Sep 2023 02:49:21 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD38140269;
	Tue, 12 Sep 2023 02:49:20 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 84EFE40223
 for <dev@dpdk.org>; Tue, 12 Sep 2023 02:49:18 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id C2E5C212BBBB; Mon, 11 Sep 2023 17:49:17 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C2E5C212BBBB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1694479757;
 bh=lvXKiZCIfxRd3pfqiPNBS7cWz6oCZGIIN1h8EhU80lU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=l6qhBd8s657ha5AsHGjjrbDl8VkKuSAj4KdOYOHp+4mmxBKkARzelPtpVeH29zxD3
 oI1+O9w8OuV6/pIocSicU+PCh89bQz/3YQiznJS9ryERNOvHOFr0i/ajyUj+Ap79nq
 W55JJ20JREwYEaxSwR1OCzxE0/aitnjcfbl3zzB0=
Date: Mon, 11 Sep 2023 17:49:17 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
 Ferruh Yigit <ferruh.yigit@amd.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH 10/11] eal: remove deprecated thread functions
Message-ID: <20230912004917.GA23059@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230906162226.1618088-1-thomas@monjalon.net>
 <20230906162226.1618088-11-thomas@monjalon.net>
 <20230908042256.GF7692@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <3054789.ktpJ11cQ8Q@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3054789.ktpJ11cQ8Q@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Sep 11, 2023 at 06:13:48PM +0200, Thomas Monjalon wrote:
> 08/09/2023 06:22, Tyler Retzlaff:
> > On Wed, Sep 06, 2023 at 06:12:27PM +0200, Thomas Monjalon wrote:
> > > --- a/lib/eal/common/eal_common_thread.c
> > > +++ b/lib/eal/common/eal_common_thread.c
> > > @@ -248,7 +248,7 @@ struct rte_thread_ctrl_params {
> > >  	enum __rte_ctrl_thread_status ctrl_thread_status;
> > >  };
> > 
> > the code above here
> > 
> > struct rte_thread_ctrl_params i think can now get renamed to
> > rte_thread_control_params and i think we can get rid of the union.
> > if i look through the code history i only added it to help maintain
> > compatibility while we had both ctrl and control thread APIs.
> 
> Yes  I can do this cleanup.
> Instead of rte_thread_control_params,
> I would call it control_thread_params as it is private.

sounds good to me, i didn't intend to express a preference about the
name just that it could be cleaned up.
>