From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A89884257C; Tue, 12 Sep 2023 13:08:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F19C402AC; Tue, 12 Sep 2023 13:08:07 +0200 (CEST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mails.dpdk.org (Postfix) with ESMTP id 7BF3C402A3 for ; Tue, 12 Sep 2023 13:08:06 +0200 (CEST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-9a9f139cd94so610039866b.2 for ; Tue, 12 Sep 2023 04:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1694516886; x=1695121686; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Q52RZk3sAnlqjklz1HqJSRwp0pKlFpNh8Ub2w2EK67E=; b=SL9Y5MZqh+Kin3rvb/QE6HwvHusohtGWzdB+EuK+AHS9/DRfsZAL8CihkertFIF47X bVGIpjibDumsvUr7Nu5BlJssxwSvx0VRKONh5jMDXAQhymdIBy2wjyb5HXApRp9hr6nI LeW5GR3ZD9DOk2/07zvSetLioSRwUIjKBhDYKtuQUH/iien6OquDQtHi0zjCOK+8qflC IoKmjB657N2CksIP0kef/GCea/Fc7HRmODxaUmdaP9Nnt+yN4waVMJou8GVvPVROmi/8 pLl5CUzrNVHR5SayKAQZrmFO5kdPFaClWa7HGaUF+e3Hbi97b7n9RXoVsqlPPVgRX/mK GPXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694516886; x=1695121686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q52RZk3sAnlqjklz1HqJSRwp0pKlFpNh8Ub2w2EK67E=; b=JukLxidk9PVa8c+IrmcWQ9smJ/cmE8Xn0FfvSCyFXGKsg/wuJOJ+AI1u85/K1itlHX +07exwdBmkWQbFg/QbIsgdxxcIxc7q2jCQKnC76n3FBdcq8/XT+VPZzbUfA5xpHP4Q51 BUdR5Yf8xufWRhbnr2DeVUeAYY7aEvnYO/xaV0ivqLg5+nvy64iBSQvs8NupmAZN4Wr+ 7YmPqg+oqYYFB+BTUdBzcBYlEIRJ0nmnSplT7aHbG5RDHk4MQqgcFpwDS7qboFlM2GMu zR+h6GECc1uJpsgLg8ADkpCtapW6Qj7tk1Dwr2lpUizvad41fEuzusJYdjLJpxIt1fcM gOAQ== X-Gm-Message-State: AOJu0Yy4DkFqOgd0XT4Vv0DNMYGWjGRa33N8AxcOeRQS9OGymrIuMOfr puLjfRuaTRnX+OU3Bawg1ptJv/a5P7eAxzDZLGft/g== X-Google-Smtp-Source: AGHT+IHuIoaElyAZ3eBddN94q5lbkDxDjpQ5x5QTpIg5Pii+WJX7hh6bk4W/atGNB1mt/AkHeFYxiw== X-Received: by 2002:a17:906:256:b0:9a2:1e14:86bd with SMTP id 22-20020a170906025600b009a21e1486bdmr10823168ejl.65.1694516885897; Tue, 12 Sep 2023 04:08:05 -0700 (PDT) Received: from fedora ([79.140.208.123]) by smtp.gmail.com with ESMTPSA id o24-20020a1709062e9800b009a19701e7b5sm6661829eji.96.2023.09.12.04.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 04:08:05 -0700 (PDT) Date: Tue, 12 Sep 2023 04:08:01 -0700 From: Stephen Hemminger To: 835703180@qq.com Cc: david.hunt@intel.com, dev@dpdk.org Subject: Re: [PATCH 2/2] lib/power:fix comparision to bool warning Message-ID: <20230912040801.6b130a4b@fedora> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Jun 2022 23:56:43 +0800 835703180@qq.com wrote: > From: newsky647 <835703180@qq.com> > > expr "if ([expr] == true)" can be simplified to "if ([expr])". > Therefore, simplify it, no functional change. > > Fixes: 450f0791312 ("lib/power: power: add traffic pattern aware > power control" Signed-off-by: newsky647 <835703180@qq.com> This patch does not meet Developer Certificate of Origin legal requirements. You need to use your legal name because Signed Off by has legal meaning. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. then you just add a line saying: Signed-off-by: Random J Developer using a known identity (sorry, no anonymous contributions.) This will be done for you automatically if you use git commit -s. Reverts should also include "Signed-off-by". git revert -s does that for you. Some people also put extra tags at the end. They'll just be ignored for now, but you can do this to mark internal company procedures or just point out some special detail about the sign-off. Any further SoBs (Signed-off-by:'s) following the author's SoB are from people handling and transporting the patch, but were not involved in its development. SoB chains should reflect the real route a patch took as it was propagated to the maintainers and ultimately to Linus, with the first SoB entry signalling primary authorship of a single author.