From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F25D425A6; Fri, 15 Sep 2023 17:11:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D5D6402B8; Fri, 15 Sep 2023 17:11:57 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 4BD3B40295 for ; Fri, 15 Sep 2023 17:11:56 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so1788591a12.1 for ; Fri, 15 Sep 2023 08:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1694790715; x=1695395515; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6MnL0GvMF17QJdUmtHmy97hhcGkXkgVC7lwiI1ungRI=; b=sPCaRB6409FtzUJm8XlUoNp8S8yMvfV/KBGROvE02cKCz56NoNu2Z+HrrW86lgOZGf boYoicyOQT5Tr0VgrQm55/VJRpBcuD3bp8eDHRPMhlcYFBTdSoMfrYL4uNdOE3MKZoPG w9IsYkHrGMZqVDkro/uQgbIA+kGMPAe77yeXriE2R8VcGzCo+eq8L4F7o2GeF8dKVOMb eOPhAHJEWmmDVT6llEyHkQYen2ijFKBszw7WnV4qd26J42pHSMor5WUsDzJabyr7QjrP 49L0Cj83YkgTzaOcv0ciJtmgCtY2p4lhN3dGvjpP2IS6/wXr9sVH+Mx/j4ASD6idt0IX lqFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694790715; x=1695395515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6MnL0GvMF17QJdUmtHmy97hhcGkXkgVC7lwiI1ungRI=; b=s2dvzfJtUXrR2IKGulLkT2cAh/1Zn3Kjg1PMRwlZ9+ftO9d7wnsh+NCmavgBBKSYD/ LB8JxSGZFwicwpWCvyBoZVVwSM4JAYkvYM9w5TBDa7Hohy0MUQdbUEfcqE/4zDSwIGBz IMJjrlyPv6Nbq5K3hryUT8xNq718BKPCoyv943EkwASXkzf+bofl9Qs8USQbfq+TbDaz P63zhpSpJj68HT8oUuh2FnjXOWHMh+sI5/JzcpAEQaesx+qXdfE3jT+5VNVw/1P62tJH MPI0HlK26llMegTfnDXTRpPZDqIzI0o5r8HeOd1BkxkA/bfGIh3eQ/BP+XfKJMeXUJg3 wMfw== X-Gm-Message-State: AOJu0YzwLr3jYac9eYoWochk+C1FIncMnizbITmMDuBYyTmMQIClRxpy jhEvHI7aDY4sBtAx4yGt4mH3eA== X-Google-Smtp-Source: AGHT+IEVDQrwdKBF97E8/6FaqsboFhkEo/S8qCOy4HCBZXI+JJMmanKzv5F3zeHPHfMyBTt8BDhtiw== X-Received: by 2002:a17:90a:fb55:b0:268:1e51:3496 with SMTP id iq21-20020a17090afb5500b002681e513496mr1856074pjb.21.1694790715237; Fri, 15 Sep 2023 08:11:55 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id 28-20020a17090a1a1c00b00256799877ffsm3382585pjk.47.2023.09.15.08.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 08:11:55 -0700 (PDT) Date: Fri, 15 Sep 2023 08:11:53 -0700 From: Stephen Hemminger To: "Zhang, Yuying" Cc: dev@dpdk.org, qi.z.zhang@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com, mingxia.liu@intel.com, Wenjing Qiao Subject: Re: [PATCH v4 1/9] net/cpfl: add json parser for rte flow pattern rules Message-ID: <20230915081153.394a9386@hermes.local> In-Reply-To: <20230815165050.86595-2-yuying.zhang@intel.com> References: <20230906093407.3635038-1-wenjing.qiao@intel.com> <20230815165050.86595-1-yuying.zhang@intel.com> <20230815165050.86595-2-yuying.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Aug 2023 16:50:42 +0000 "Zhang, Yuying" wrote: > +Rte_flow > +~~~~~~~~~~~~~ > + > +PMD uses a json file to direct CPF PMD to parse rte_flow tokens into > +low level hardware resources. > + > +- Required Libraries > + > + * json-c (version 0.14+) > + > + * For Ubuntu, it can be installed using `apt install libjson-c-dev` Other parts of DPDK are using jansson library with equivalent functionality. Introducing another dependency to DPDK which is duplicate of already used code just makes life more complicated and difficult for existing users. Therefore my recommendation is that the patch not be accepted as is.