DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] event/sw: remove obsolete comment
@ 2023-09-14  9:37 Bruce Richardson
  2023-09-14 10:10 ` Van Haaren, Harry
  2023-09-15 15:12 ` Stephen Hemminger
  0 siblings, 2 replies; 5+ messages in thread
From: Bruce Richardson @ 2023-09-14  9:37 UTC (permalink / raw)
  To: dev; +Cc: Harry van Haaren, Bruce Richardson, stable

Code that the comment refers to was previously removed, but the
comment remained.

Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/event/sw/sw_evdev_scheduler.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c
index de6ed21643..17953fde0e 100644
--- a/drivers/event/sw/sw_evdev_scheduler.c
+++ b/drivers/event/sw/sw_evdev_scheduler.c
@@ -368,12 +368,6 @@ __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder)
 		if (!allow_reorder && !eop)
 			flags = QE_FLAG_VALID;
 
-		/*
-		 * if we don't have space for this packet in an IQ,
-		 * then move on to next queue. Technically, for a
-		 * packet that needs reordering, we don't need to check
-		 * here, but it simplifies things not to special-case
-		 */
 		uint32_t iq_num = PRIO_TO_IQ(qe->priority);
 		struct sw_qid *qid = &sw->qids[qe->queue_id];
 
-- 
2.39.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] event/sw: remove obsolete comment
  2023-09-14  9:37 [PATCH] event/sw: remove obsolete comment Bruce Richardson
@ 2023-09-14 10:10 ` Van Haaren, Harry
  2023-09-14 10:29   ` Bruce Richardson
  2023-09-15 15:12 ` Stephen Hemminger
  1 sibling, 1 reply; 5+ messages in thread
From: Van Haaren, Harry @ 2023-09-14 10:10 UTC (permalink / raw)
  To: Richardson, Bruce, dev; +Cc: stable

> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Thursday, September 14, 2023 10:38 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: [PATCH] event/sw: remove obsolete comment
> 
> Code that the comment refers to was previously removed, but the
> comment remained.
> 
> Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> Cc: stable@dpdk.org

Do we want to backport this? It's a code-level change, that doesn't really "fix" any issue.
I'm fine with it being backported to stables, or skipped.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] event/sw: remove obsolete comment
  2023-09-14 10:10 ` Van Haaren, Harry
@ 2023-09-14 10:29   ` Bruce Richardson
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2023-09-14 10:29 UTC (permalink / raw)
  To: Van Haaren, Harry; +Cc: dev, stable

On Thu, Sep 14, 2023 at 11:10:17AM +0100, Van Haaren, Harry wrote:
> > -----Original Message-----
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Sent: Thursday, September 14, 2023 10:38 AM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; stable@dpdk.org
> > Subject: [PATCH] event/sw: remove obsolete comment
> > 
> > Code that the comment refers to was previously removed, but the
> > comment remained.
> > 
> > Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> > Cc: stable@dpdk.org
> 
> Do we want to backport this? It's a code-level change, that doesn't really "fix" any issue.
> I'm fine with it being backported to stables, or skipped.
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 

I'd take the view that since backporting is going to be entirely harmless,
and it does fix the code for anyone trying to read it, we might as well do so.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] event/sw: remove obsolete comment
  2023-09-14  9:37 [PATCH] event/sw: remove obsolete comment Bruce Richardson
  2023-09-14 10:10 ` Van Haaren, Harry
@ 2023-09-15 15:12 ` Stephen Hemminger
  2023-09-19 14:05   ` Jerin Jacob
  1 sibling, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2023-09-15 15:12 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, Harry van Haaren, stable

On Thu, 14 Sep 2023 10:37:51 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> Code that the comment refers to was previously removed, but the
> comment remained.
> 
> Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] event/sw: remove obsolete comment
  2023-09-15 15:12 ` Stephen Hemminger
@ 2023-09-19 14:05   ` Jerin Jacob
  0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-09-19 14:05 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Bruce Richardson, dev, Harry van Haaren, stable

On Fri, Sep 15, 2023 at 8:43 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 14 Sep 2023 10:37:51 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > Code that the comment refers to was previously removed, but the
> > comment remained.
> >
> > Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>


Applied to dpdk-next-net-eventdev/for-main. Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-19 14:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14  9:37 [PATCH] event/sw: remove obsolete comment Bruce Richardson
2023-09-14 10:10 ` Van Haaren, Harry
2023-09-14 10:29   ` Bruce Richardson
2023-09-15 15:12 ` Stephen Hemminger
2023-09-19 14:05   ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).