From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56224425C9; Mon, 18 Sep 2023 04:23:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53DEA402B1; Mon, 18 Sep 2023 04:22:59 +0200 (CEST) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by mails.dpdk.org (Postfix) with ESMTP id 5E4BB4021F for ; Mon, 18 Sep 2023 04:22:58 +0200 (CEST) Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3adcd85493bso656820b6e.0 for ; Sun, 17 Sep 2023 19:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695003777; x=1695608577; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3U6nxx6YKyHrc5R8fjpE3eXc62TMlqYUrxW3mgGajjE=; b=xGtzvnDqpDGSW+rimoGLgBuJ/j2g6bojbWymmRU/rKRohHapwMEGxlAfyxPR4WoYD9 JTWKScH9Tbhxa/KpcAyr5tYqeEUwdH4gfrqX/XY9SguqaRFFAOPBjNtIdL55FT2S/G9I kS+yDRuU3hm9hFiyqpOMik8Dx/6ZbC6RzX+2hKtq7Xzt2kf6o9s+bHBe/Wew9krnlw3h cze6Pkr+tC8mUZcgYq6D67fI8iAixy//25p4DkMH5OJyHVgE4HXJ7BjSHz1f7CDOM7S2 NWPYxiiXJW8aF7Hhbksk0AKW4nPDpfh5I/IoM8LpEzCQzWAfsTlmNAF9OLnVF3lB6gak l5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695003777; x=1695608577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3U6nxx6YKyHrc5R8fjpE3eXc62TMlqYUrxW3mgGajjE=; b=LxeJRZYtpsVv0X8OlXw8HuDRvkYSyF517mwisB5CLCuoPMDsI6jD4HsIO5aS+toJoI 7Ami432EDJp9wpADuy0ZTy9IP3/EMGpa8nrwzgzxXCk44tvbehfT7VdVCr5c47q0VAlW j2Anj3c/J6WM1n/cwI/k3HluUahURmGzx+T0n1FxYLmRB6bqqz3zRH0q6U95IPmX7EU7 7aX8RPTuz6y1HcVMah2yANb16r4KJeBx4jba3JuDo55UNrTnnfN5QAUNut/jJOApj26r Vmtbb7ETTnazKxDBWQvFm/rDN1ZyA+eBGH2wMqo/MAEOOpI+iidRo2fyBAAxdqRKJRSH QzTA== X-Gm-Message-State: AOJu0YzHMbq+7aAsQo+uCMlN9mbJLQgp4Pfp0R+IL1XinFfrqzpQ9oZY 3R0YvV7/z9chV5DG+aBZCcCTdQ== X-Google-Smtp-Source: AGHT+IHAB+zea864SVcCJoZrA78sF4vkqeLafhN1ZpMY/SRL1FTFvCyPKQreRDTnEfL8mPkNvP943w== X-Received: by 2002:a54:4e93:0:b0:3a7:5611:a53b with SMTP id c19-20020a544e93000000b003a75611a53bmr8242233oiy.0.1695003776095; Sun, 17 Sep 2023 19:22:56 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id w6-20020a170902e88600b001c413e216fbsm6874651plg.226.2023.09.17.19.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Sep 2023 19:22:55 -0700 (PDT) Date: Sun, 17 Sep 2023 19:22:54 -0700 From: Stephen Hemminger To: Chaoyong He Cc: Ferruh Yigit , "dev@dpdk.org" Subject: Re: [PATCH v3 02/27] net/nfp: unify the indent coding style Message-ID: <20230917192254.70f9156f@hermes.local> In-Reply-To: References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> <20230915091551.1459606-3-chaoyong.he@corigine.com> <1d69aa46-eb43-48ba-ad20-f909986a83be@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 18 Sep 2023 01:25:28 +0000 Chaoyong He wrote: > > From: Ferruh Yigit > > Sent: Friday, September 15, 2023 9:41 PM > > To: Chaoyong He ; dev@dpdk.org > > Cc: oss-drivers ; Niklas Soderlund > > > > Subject: Re: [PATCH v3 02/27] net/nfp: unify the indent coding style > > > > On 9/15/2023 10:15 AM, Chaoyong He wrote: > > > Each parameter of function should occupy one line, and indent two TAB > > > character. > > > > > > > No objection to it, but "Each parameter of function should occupy one line" is > > NOT coming from DPDK coding convention, right? > > If this is for driver code consistancey, that is OK. > > Yes, it's our own coding style, a little stricter than the DPDK coding convention. I wish DPDK had a uniform style and use one of the styles describable by the clang-format settings.