From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8EAE0425C9;
Mon, 18 Sep 2023 04:32:55 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7B64440395;
Mon, 18 Sep 2023 04:32:55 +0200 (CEST)
Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com
[209.85.214.178])
by mails.dpdk.org (Postfix) with ESMTP id AECAE4021F
for <dev@dpdk.org>; Mon, 18 Sep 2023 04:32:54 +0200 (CEST)
Received: by mail-pl1-f178.google.com with SMTP id
d9443c01a7336-1c47309a8ccso4907705ad.1
for <dev@dpdk.org>; Sun, 17 Sep 2023 19:32:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695004374;
x=1695609174; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=VZ4HB8bhZ2KWAHoOvs+b4cNv4fOzuK2lWyWFDNs4Ifw=;
b=HpJtRf4imh5nnAS+x4t7OTk8a2ikXRYxx0WZVXIXq+/tuDsqqg77TbFiFHdtS/Ua/N
3vShl3mfOjei6UniDHKCj9oxNAwFRdOxuiqzecDa7q5OkcZm+A48kRP8x4JDPMzCAPSP
NggS28AEJA+V4PCZySw98Cqnr9xd2wL+MZy6kP9bOdm5P+2TThICRPE4w3fgUVSrHqxX
Xl96mn0crwltAY9mUwl1GCLWP2mfiRrARqh3zTZ6i6FQR0uUzC7sZ5fmQE+rweeFz7Cv
pUAkScWV0xoRWZr4/kkt6a4/PeQAHhJ4Tkr9lxEWx1zmtG1VoyCum/AgttcPE1jUEsgX
eQeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1695004374; x=1695609174;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=VZ4HB8bhZ2KWAHoOvs+b4cNv4fOzuK2lWyWFDNs4Ifw=;
b=Ks3E4wo1br16EeWbX0sc62Qnt9i0tKuJaOBbCrvBjzMPx6gfprexXrMHKONPsgF3WV
BjkDDCPQndLLS3yh8IagEGd53FjnAcKZ0fB+IpnVXbUji7L16pad6iAL0cHDvrNmzTLQ
kLID77dhVeeGWZ+bWCD7QLR0go0FK77UYTr2WoUCgaTRVPc7/Ysk5nwL1RbYc6zAKdBy
FMewH5us6zRDt2sOaZGHlMZN0fjyWEUL0Powv6Zj0Isnya2D/Q83XYpLEnIOIMXUulZs
ajthEMSEN01MMBb3G4FmvgFcLzloKV3IbwfYH49NQ9H7h0qYlDK4lcq9bnun5Dcw4sBF
iPVg==
X-Gm-Message-State: AOJu0YwQT0S1vjsfcztPfJCa2CHscTsrIJheaVjf2lRU4nylJF6P2b/5
eaQhIneIthuCE+Fe1ymo4ycXtA==
X-Google-Smtp-Source: AGHT+IEJfJvxoJK+vCY3QuhFNOL7EliQWtW3CVbzQFWTx4SbDJyvc9mkpdtjjJ2lGSntOdrg876D0w==
X-Received: by 2002:a17:902:d502:b0:1bc:2fe1:1821 with SMTP id
b2-20020a170902d50200b001bc2fe11821mr15743859plg.17.1695004373890;
Sun, 17 Sep 2023 19:32:53 -0700 (PDT)
Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131])
by smtp.gmail.com with ESMTPSA id
iz11-20020a170902ef8b00b001b03b7f8adfsm7254283plb.246.2023.09.17.19.32.53
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 17 Sep 2023 19:32:53 -0700 (PDT)
Date: Sun, 17 Sep 2023 19:32:51 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: <wanry@3snic.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, Steven Song <steven.song@3snic.com>
Subject: Re: [PATCH v5 07/32] net/sssnic/base: add mailbox support
Message-ID: <20230917193251.5c7444f1@hermes.local>
In-Reply-To: <20230904045658.238185-8-wanry@3snic.com>
References: <20230904045658.238185-1-wanry@3snic.com>
<20230904045658.238185-8-wanry@3snic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, 4 Sep 2023 12:56:33 +0800
<wanry@3snic.com> wrote:
> +struct sssnic_mbox_send_ctrl1_reg {
> + union {
> + uint32_t u32;
> + struct {
> + uint32_t resvd0 : 10;
> + /* Destination eventq in the mgmt cpu */
> + uint32_t dst_eq : 2;
> + /* eventq that will be informed if tx done */
> + uint32_t src_eq : 2;
> + uint32_t dma_attr : 6;
> + /* mailbox message size include header and body
> + * must 4byte align and unit is 4byte
> + */
> + uint32_t tx_size : 5;
> + uint32_t ordering : 2;
> + uint32_t resvd1 : 1;
> + /*write result back to DMA address of sending result */
> + uint32_t wb : 1;
Minor nit: the comment above has odd word spacing.