DPDK patches and discussions
 help / color / mirror / Atom feed
From: Haifei Luo <haifeil@nvidia.com>
To: <dev@dpdk.org>
Cc: <orika@nvidia.com>, <viacheslavo@nvidia.com>,
	<rasland@nvidia.com>, <xuemingl@nvidia.com>, <haifeil@nvidia.com>,
	Dariusz Sosnowski <dsosnowski@nvidia.com>,
	Matan Azrad <matan@nvidia.com>,
	Suanming Mou <suanmingm@nvidia.com>
Subject: [PATCH v2 3/5] net/mlx5: enhance the validation for item VXLAN-GPE
Date: Mon, 25 Sep 2023 05:09:18 +0300	[thread overview]
Message-ID: <20230925020921.4607-4-haifeil@nvidia.com> (raw)
In-Reply-To: <20230925020921.4607-1-haifeil@nvidia.com>

Enhance the validation so that configuring vxlan-gpe's next protocol as NSH
is supported.

1. The spec's protocol can have value and nic_mask's protocol is 0xff.

Signed-off-by: Haifei Luo <haifeil@nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f7f8f54eb4..202e878ddf 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -3198,6 +3198,11 @@ mlx5_flow_validate_item_vxlan_gpe(const struct rte_flow_item *item,
 		uint8_t vni[4];
 	} id = { .vlan_id = 0, };
 
+	struct rte_flow_item_vxlan_gpe nic_mask = {
+		.vni = "\xff\xff\xff",
+		.protocol = 0xff,
+	};
+
 	if (!priv->sh->config.l3_vxlan_en)
 		return rte_flow_error_set(error, ENOTSUP,
 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
@@ -3221,18 +3226,12 @@ mlx5_flow_validate_item_vxlan_gpe(const struct rte_flow_item *item,
 		mask = &rte_flow_item_vxlan_gpe_mask;
 	ret = mlx5_flow_item_acceptable
 		(item, (const uint8_t *)mask,
-		 (const uint8_t *)&rte_flow_item_vxlan_gpe_mask,
+		 (const uint8_t *)&nic_mask,
 		 sizeof(struct rte_flow_item_vxlan_gpe),
 		 MLX5_ITEM_RANGE_NOT_ACCEPTED, error);
 	if (ret < 0)
 		return ret;
 	if (spec) {
-		if (spec->hdr.proto)
-			return rte_flow_error_set(error, ENOTSUP,
-						  RTE_FLOW_ERROR_TYPE_ITEM,
-						  item,
-						  "VxLAN-GPE protocol"
-						  " not supported");
 		memcpy(&id.vni[1], spec->hdr.vni, 3);
 		memcpy(&id.vni[1], mask->hdr.vni, 3);
 	}
-- 
2.27.0


  parent reply	other threads:[~2023-09-25  2:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  7:40 [PATCH 0/5] support item NSH matching Haifei Luo
2023-08-09  7:40 ` [PATCH 1/5] app/testpmd: support for VXLAN-GPE's next protocol Haifei Luo
2023-08-09  7:40 ` [PATCH 2/5] common/mlx5: extend HCA attribute query for NSH Haifei Luo
2023-08-09  7:40 ` [PATCH 3/5] net/mlx5: enhance the validation for item VXLAN-GPE Haifei Luo
2023-08-09  7:40 ` [PATCH 4/5] app/testpmd: support for NSH flow item Haifei Luo
2023-08-09  7:40 ` [PATCH 5/5] net/mlx5: add support for item NSH Haifei Luo
2023-09-25  2:09 ` [PATCH v2 0/5] support item NSH matching Haifei Luo
2023-09-25  2:09   ` [PATCH v2 1/5] app/testpmd: support for VXLAN-GPE's next protocol Haifei Luo
2023-09-25  2:09   ` [PATCH v2 2/5] common/mlx5: extend HCA attribute query for NSH Haifei Luo
2023-09-25  2:09   ` Haifei Luo [this message]
2023-09-25  2:09   ` [PATCH v2 4/5] app/testpmd: support for NSH flow item Haifei Luo
2023-09-25  2:09   ` [PATCH v2 5/5] net/mlx5: add support for item NSH Haifei Luo
2023-09-25  8:07   ` [PATCH v3 0/5] support item NSH matching Haifei Luo
2023-09-25  8:07     ` [PATCH v3 1/5] app/testpmd: support for VXLAN-GPE's next protocol Haifei Luo
2023-09-25  8:07     ` [PATCH v3 2/5] common/mlx5: extend HCA attribute query for NSH Haifei Luo
2023-09-25  8:07     ` [PATCH v3 3/5] net/mlx5: enhance the validation for item VXLAN-GPE Haifei Luo
2023-09-25  8:07     ` [PATCH v3 4/5] app/testpmd: support for NSH flow item Haifei Luo
2023-09-25  8:07     ` [PATCH v3 5/5] net/mlx5: add support for item NSH Haifei Luo
2023-10-08  3:10     ` [PATCH v4 0/5] support item NSH matching Haifei Luo
2023-10-08  3:10       ` [PATCH v4 1/5] app/testpmd: support for VXLAN-GPE's next protocol Haifei Luo
2023-10-08  3:10       ` [PATCH v4 2/5] common/mlx5: extend HCA attribute query for NSH Haifei Luo
2023-10-08  3:10       ` [PATCH v4 3/5] net/mlx5: enhance the validation for item VXLAN-GPE Haifei Luo
2023-10-08  3:10       ` [PATCH v4 4/5] app/testpmd: support for NSH flow item Haifei Luo
2023-10-08  3:10       ` [PATCH v4 5/5] net/mlx5: add support for item NSH Haifei Luo
2023-10-09 11:15       ` [PATCH v4 0/5] support item NSH matching Raslan Darawsheh
2023-10-16  9:27         ` Thomas Monjalon
2023-10-08 10:34   ` [PATCH v2 " Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230925020921.4607-4-haifeil@nvidia.com \
    --to=haifeil@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=suanmingm@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).