From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, Kevin Liu <kevinx.liu@intel.com>,
Mingjin Ye <mingjinx.ye@intel.com>
Subject: [PATCH v2 3/4] net/ice: remove log from Tx prepare datapath function
Date: Wed, 27 Sep 2023 11:41:47 +0200 [thread overview]
Message-ID: <20230927094148.1129330-3-david.marchand@redhat.com> (raw)
In-Reply-To: <20230927094148.1129330-1-david.marchand@redhat.com>
ice_prep_pkts reports to the application that the packet is invalid
(from the driver pov). Having a log message in those branches is not
consistent with all other checks in this function and it may slow down
the application if such invalid packets are being sent continuously.
Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes")
Fixes: 688cb2f2c61e ("net/ice: fix scalar Tx path segment")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/ice/ice_rxtx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index e07c6d1f15..d5513e9e93 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3708,7 +3708,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
if (m->data_len < ICE_TX_MIN_PKT_LEN ||
m->data_len > max_frame_size) {
rte_errno = EINVAL;
- PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len);
return i;
}
@@ -3727,7 +3726,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
if (ice_check_empty_mbuf(m) != 0) {
rte_errno = EINVAL;
- PMD_DRV_LOG(ERR, "INVALID mbuf: last mbuf data_len=[0]");
return i;
}
}
--
2.41.0
next prev parent reply other threads:[~2023-09-27 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 14:04 [PATCH 1/2] net/iavf: fix TSO with big segments David Marchand
2023-09-19 14:04 ` [PATCH 2/2] net/ice: " David Marchand
2023-09-21 5:48 ` Zhang, Qi Z
2023-09-21 5:55 ` David Marchand
2023-09-21 10:42 ` Zhang, Qi Z
2023-09-25 10:30 ` David Marchand
2023-09-27 4:05 ` Zhang, Qi Z
2023-09-27 9:41 ` [PATCH v2 1/4] net/iavf: remove log from Tx prepare datapath function David Marchand
2023-09-27 9:41 ` [PATCH v2 2/4] net/iavf: fix TSO with big segments David Marchand
2023-09-27 9:41 ` David Marchand [this message]
2023-09-27 9:41 ` [PATCH v2 4/4] net/ice: " David Marchand
2023-09-27 12:36 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927094148.1129330-3-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kevinx.liu@intel.com \
--cc=mingjinx.ye@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).