From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30EBA42651; Wed, 27 Sep 2023 13:45:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04AD040271; Wed, 27 Sep 2023 13:45:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A85C64026B for ; Wed, 27 Sep 2023 13:45:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695815120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8tRT+jEU8e8OPMXEzOpxf5o2qAXduXnoEgqAAQUbNQE=; b=gDuJD5B8If8wqNHsE927rFEGbT2v1bNJShMJCw+/HsqxzViOt/4XWI3eCtp/XM7wu0V9ZW lu5ast6ggo3/5UeFSPYDYSaZF/vBuOKKGvrO6pPvjnOAagscRq8xdHFIFUEADnnX5q4VgR Zu6YUG6ulVHxxNtKM4gBuKrEF4WC2IQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-mkZAzzclO4WRNJz63MYlEA-1; Wed, 27 Sep 2023 07:45:18 -0400 X-MC-Unique: mkZAzzclO4WRNJz63MYlEA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5ABA1801779; Wed, 27 Sep 2023 11:45:18 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1C57C15BB8; Wed, 27 Sep 2023 11:45:17 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: probb@iol.unh.edu Subject: [PATCH v4 0/3] Release ethdev shared memory on port cleanup Date: Wed, 27 Sep 2023 13:45:12 +0200 Message-ID: <20230927114515.1245213-1-david.marchand@redhat.com> In-Reply-To: <20230818091321.2404089-1-david.marchand@redhat.com> References: <20230818091321.2404089-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This series was triggered after investigating why the eal_flags_file_prefix_autotest unit test was failing in the case of statically built binaries [1]). For now, I went with a simple (naive) approach and put all accesses to the shared data under a single lock: ethdev maintainers, it is your turn to shine and give me reasons why we should keep the locks the way they were ;-). And let's see what the CI reports... 1: https://inbox.dpdk.org/dev/20230816153439.551501-12-bruce.richardson@intel.com/T/#m0e4c23f7be80bbdac076a387f4a2f9094dd07e0a -- David Marchand Changes since v3: - updated commitlogs, Changes since v2: - fixed multiprocess via patch 2, - fixed "ownership" history (not releasing shared mem if some owner is registered), Changes since v1: - fixed uaf in port cleanup, David Marchand (3): ethdev: protect shared memory accesses under one lock ethdev: avoid panicking in absence of ethdev shared data ethdev: cleanup shared data with the last port lib/eal/common/eal_common_mcfg.c | 6 ++ lib/eal/common/eal_memcfg.h | 1 + lib/eal/include/rte_eal_memconfig.h | 4 ++ lib/eal/version.map | 1 + lib/ethdev/ethdev_driver.c | 53 ++++++++++----- lib/ethdev/ethdev_private.c | 38 +++++++---- lib/ethdev/ethdev_private.h | 13 +++- lib/ethdev/ethdev_trace.h | 6 +- lib/ethdev/rte_ethdev.c | 99 ++++++++++++++++++----------- 9 files changed, 151 insertions(+), 70 deletions(-) -- 2.41.0