From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F03D4265E; Thu, 28 Sep 2023 11:37:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EDBF40DDA; Thu, 28 Sep 2023 11:37:17 +0200 (CEST) Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by mails.dpdk.org (Postfix) with ESMTP id 0544A40A84; Thu, 28 Sep 2023 11:37:13 +0200 (CEST) X-QQ-mid: bizesmtp74t1695893822txnhfp6q Received: from wxdbg.localdomain.com ( [115.200.229.121]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 28 Sep 2023 17:37:02 +0800 (CST) X-QQ-SSF: 01400000000000K0Z000000A0000000 X-QQ-FEAT: 5q30pvLz2ie9MkCTgu7/OETrKqpin5cGuyjRdC4QTBFcUaMHXmN0+81+Bma3i TbjIlqvi/KTHajtj62cNSWdyh17XkMPb+N8FrtohF1OMJamglyg+H1QTsR9cFkkbMByUkSx mQh+mnmJlEwkuEBNcd4GkUyCKKdEc5TgsRvrI6Jnz1f3dRtR5iJXqP957NW/DcqNLFlX2g9 8Gzp7jpEzYNCi/tz+Eq/MYLzkjrZeLoRUwMl52Eu6hmDSDgm3l9w/K+35O5Wi/k+rwn/zvz j0ds0iYHMPy7hDwlxK3TRslaiUMo45Hk5TgKH1cpPNe1zUs21xtWHEWeIdxbd+Nvjy2jGOS Q7TkjOZez+NUAgTRA3o4CqgfX9iCzeFB1J96WYMYFWmxA39MeDqPBwdRKHysiJnooQYBqIO zVr1oRO9vXE= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 4015351842153690812 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 01/11] net/txgbe: add Tx queue maximum limit Date: Thu, 28 Sep 2023 17:47:48 +0800 Message-Id: <20230928094758.1076236-2-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230928094758.1076236-1-jiawenwu@trustnetic.com> References: <20230928094758.1076236-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Limit TX queue maximum to 64 when neither VT nor DCB are enabled, since hardware doesn't support it. Fixes: 75cbb1f0e8a6 ("net/txgbe: add device configuration") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 13 +++++++++++++ drivers/net/txgbe/txgbe_ethdev.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 15911a3621..479cd810f8 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -1499,6 +1499,19 @@ txgbe_check_mq_mode(struct rte_eth_dev *dev) return -EINVAL; } } + + /* + * When DCB/VT is off, maximum number of queues changes + */ + if (dev_conf->txmode.mq_mode == RTE_ETH_MQ_TX_NONE) { + if (nb_tx_q > TXGBE_NONE_MODE_TX_NB_QUEUES) { + PMD_INIT_LOG(ERR, + "Neither VT nor DCB are enabled, " + "nb_tx_q > %d.", + TXGBE_NONE_MODE_TX_NB_QUEUES); + return -EINVAL; + } + } } return 0; } diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h index 6b296d6fd1..7feb45d0cf 100644 --- a/drivers/net/txgbe/txgbe_ethdev.h +++ b/drivers/net/txgbe/txgbe_ethdev.h @@ -41,6 +41,7 @@ /*Default value of Max Rx Queue*/ #define TXGBE_MAX_RX_QUEUE_NUM 128 #define TXGBE_VMDQ_DCB_NB_QUEUES TXGBE_MAX_RX_QUEUE_NUM +#define TXGBE_NONE_MODE_TX_NB_QUEUES 64 #ifndef NBBY #define NBBY 8 /* number of bits in a byte */ -- 2.27.0