From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5046426AE; Tue, 3 Oct 2023 18:27:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B06B6402A2; Tue, 3 Oct 2023 18:27:30 +0200 (CEST) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by mails.dpdk.org (Postfix) with ESMTP id 2EF5640262 for ; Tue, 3 Oct 2023 18:27:29 +0200 (CEST) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1dc9c2b2b79so677019fac.0 for ; Tue, 03 Oct 2023 09:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696350448; x=1696955248; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/lzpWXq+SUDXDwYj6xPKka9jMG7JDyiuqz/pGb5wMRg=; b=db6ocd8eKjFbnWTm1YBZPjpSYhW/s+6XFul4xDI236PAr5yTalbSE8LT89NQTiMZRT TBNvro1N53CVh2oeZgt1Mqw8ebLYA6vlnDlJjEP+Ye+Z+LTtYvMkusFQqFEzSBgeJag2 UfAB/ZHA1VIIe9/SegPcx61i2Wko4+ntNbBmGGd2mgmQR/vFvJZSAzXHVkkclsPZBsCC 3wtsZg5eD0KpdrDcplNzUHZwcJDdxsauF96Ta006cEqCt0Au+eu3vtrJTX4FeljQ4GO5 P306Rm7+do24HgQ4FRKVNNWVKQ5RE5kHaybYkWodd0n/vAh32iO8Y8KZIvNxwRllJ8Zc z1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696350448; x=1696955248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/lzpWXq+SUDXDwYj6xPKka9jMG7JDyiuqz/pGb5wMRg=; b=bY3WNv73xqo2E7NbyVfyDRzJQdYZLzw9Z4ONtE84tJwMNfdsKtQECa5+y6tC65FxzC 73yDKOzIycDeAJgnksSQxfdp2CKdWR01VohFY+e+p4+apeAhR2+gCXDHYUb4Z1vJI8zT VeENaA0ZCGSR6AcWx87V0fowEIHK6AVD/W8xjrUj0t1tPRgx6kr6IyT0/twZm0bEshBx FIqh6OJlovwMZtzVG8fz9u3gVquNsbcdv9VQXLgOqG/GiW3tBHyYjhiXLX2T7DLcF4rn C1zwzLbOD4UcD7b61wYgSiPQy13GJ4t3bSlmJKm7U0/bp/5lFlz0ihnpGONHFzCl5nmQ 9aPw== X-Gm-Message-State: AOJu0Yx2HqzfkJznWEzJVWUODSVnZAv5Jv1fJUcyoN1AMl0gpfId6leV llJIMcZRZ0t3RzHE8VLb7ggqhA== X-Google-Smtp-Source: AGHT+IEBwCcRChytmgbpwPjgYSo0faft8V7REKlg+1FDkSJeyfbeIak9d8HHgddrMjZFiNm4e2gDvw== X-Received: by 2002:a05:6870:5608:b0:1de:84a3:bb91 with SMTP id m8-20020a056870560800b001de84a3bb91mr104652oao.16.1696350448233; Tue, 03 Oct 2023 09:27:28 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id s20-20020a63af54000000b0056c2f1a2f6bsm1569142pgo.41.2023.10.03.09.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 09:27:28 -0700 (PDT) Date: Tue, 3 Oct 2023 09:27:26 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v2 0/3] rte_ether_unformat_addr changes Message-ID: <20231003092726.1921d9ba@hermes.local> In-Reply-To: <1cba5fee-2283-422e-abda-4cc7f239d5d8@amd.com> References: <20230929163611.62691-1-stephen@networkplumber.org> <20231002183730.301163-1-stephen@networkplumber.org> <1cba5fee-2283-422e-abda-4cc7f239d5d8@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 3 Oct 2023 11:44:16 +0100 Ferruh Yigit wrote: > On 10/2/2023 7:37 PM, Stephen Hemminger wrote: > > This patchset makes rte_ether_unformat_addr allow other formats > > for MAC address. Need to remove some inputs from existing > > cmdline_etheraddr test, and add a new test in test suite > > to cover this. There is some overlap between the two tests > > but that is fine. > > > > Stephen Hemminger (3): > > test: remove some strings from cmdline_etheraddr tests > > rte_ether_unformat: accept more inputs > > test: add tests for rte_ether routines > > > > Thanks Stephen, > > This enables using the API as replacement to the tap PMD's local parse > implementation: > https://patchwork.dpdk.org/project/dpdk/patch/20230323170145.129901-1-drc@linux.vnet.ibm.com/ That looks good, but indentation is wrong and it duplicates a check for value == NULL which will cause a new Coverity warning.