From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58B9B426AE; Tue, 3 Oct 2023 18:36:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 375F4402A2; Tue, 3 Oct 2023 18:36:29 +0200 (CEST) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by mails.dpdk.org (Postfix) with ESMTP id 831AA40262 for ; Tue, 3 Oct 2023 18:36:27 +0200 (CEST) Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3af8b4a557dso735369b6e.0 for ; Tue, 03 Oct 2023 09:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696350987; x=1696955787; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EXYEHBZ6yc6sqcsvhYmByRDNOgq2DF6jVeDx6BMQswo=; b=Rwph9NJ0yE8RLeGxj3V/ik+cecaGA6GlZ/vQ8RfHS9luhe9M0hq9A70U7cmCinvmKm mImITBXw19MQ5iYSvuH7EIxPJdHWea2EajlamIiZqHagYLOCMxS/P+UEd8NMbmPkA5KT PohxS/UnlnKJYA3xSSKu4efUo6pfpioOoTWa5aCESisSkrOYkRMvjanQg5wN/o+KErEx 7Zu3W2P2dNmUFjCBAykVkZMlIlSQbpiRctwfoUjRFPYHLnYo47/LUm0po47riikgml7q rDJckKh0LqDx7IzSbnWQDbwVXcST81Z//Kw5jVQk6ZlEMe+nkXrZSTJCR485dJJAy45B UiKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696350987; x=1696955787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EXYEHBZ6yc6sqcsvhYmByRDNOgq2DF6jVeDx6BMQswo=; b=wfC2ksVafqZ66Pl3pH8obr6w4ATxQc29YJxUBoodMDpAJJMlpDSkybtUUlanuYUiOO 1rB3LsV5E4or6olEDSxZ3Kih9Wot4WdnMr9uEbJTeBlGz++h/RiOmexfKT+6mTo8+3XM GHVlQvOzqynlju3zCalLpGVo57Ds6SkhITm0nfzduY/6EUaG6QAooAk+QRdSTWXazJLG MdhmWhu7zhCH9Fkh4vC5QwYKF3hIoMkWNXY7gh3sSrOvIVB8gwqkptfvX0byqQEdpMul aNE+bWCB517rZzOqrCKTS9RtJ8UvROFbaIzbpESZeEuysqHF3EKgGJZIwo18b5kW7w2w ifmg== X-Gm-Message-State: AOJu0Yzy8YE9fb6uZsKxn3vFMP/wat62xWyEsxn8ysDv5N+MiU2EATj8 NvPStk/iPr9DDGv4IfMTUz/YHw== X-Google-Smtp-Source: AGHT+IGpiOyW+fNX9JssWUI8xKHh/2nRB0JgqBKVlnPgua0RDBZkmvMr02BNbcpwysO1cvgWzvfWbg== X-Received: by 2002:a05:6808:8c:b0:3af:744e:92ff with SMTP id s12-20020a056808008c00b003af744e92ffmr99945oic.34.1696350986843; Tue, 03 Oct 2023 09:36:26 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id 23-20020a17090a199700b0026801e06ac1sm1711501pji.30.2023.10.03.09.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 09:36:26 -0700 (PDT) Date: Tue, 3 Oct 2023 09:36:25 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests Message-ID: <20231003093625.0e833f9f@hermes.local> In-Reply-To: References: <20230929163611.62691-1-stephen@networkplumber.org> <20231002183730.301163-1-stephen@networkplumber.org> <20231002183730.301163-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 3 Oct 2023 11:47:51 +0100 Ferruh Yigit wrote: > On 10/2/2023 7:37 PM, Stephen Hemminger wrote: > > Some of the ethernet address formats which were invalid will > > now become valid inputs when rte_ether_unformat_addr is modified > > to allow leading zeros. > > > > Also, make local variables static. > > > > Signed-off-by: Stephen Hemminger > > > > <...> > > > @@ -61,10 +60,8 @@ const char * ether_addr_invalid_strs[] = { > > "INVA:LIDC:HARS", > > /* misc */ > > "01 23 45 67 89 AB", > > - "01.23.45.67.89.AB", > > "01,23,45,67,89,AB", > > - "01:23:45\0:67:89:AB", > > - "01:23:45#:67:89:AB", > > > > Why these two are valid now? > > And I guess second one is still not valid, but first one is parsed as > [1], is this expected? > > [1] 00:01:00:23:00:45 The code in cmdline converts the comment character # to a null byte. So both test are the same. With new unformat, it allows a 3 part mac address with leading zeros. 01:23:45 is equivalent to 0001:0023:0045