From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
declan.doherty@intel.com, stable@dpdk.org,
Chaoyong He <chaoyong.he@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 3/3] app/test: fix checking return value
Date: Tue, 10 Oct 2023 14:23:04 +0800 [thread overview]
Message-ID: <20231010062304.205933-4-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20231010062304.205933-1-chaoyong.he@corigine.com>
From: Long Wu <long.wu@corigine.com>
CI found the function without checking return value in this place.
Coverity issue: 403101
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.doherty@intel.com
Cc: stable@dpdk.org
Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
app/test/test_link_bonding.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 4d715c4465..4d54706c21 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -449,7 +449,8 @@ test_add_already_bonding_member_to_bonding_device(void)
uint16_t members[RTE_MAX_ETHPORTS];
char pmd_name[RTE_ETH_NAME_MAX_LEN];
- test_add_member_to_bonding_device();
+ TEST_ASSERT_SUCCESS(test_add_member_to_bonding_device(),
+ "Failed to add member to bonding device");
current_member_count = rte_eth_bond_members_get(test_params->bonding_port_id,
members, RTE_MAX_ETHPORTS);
--
2.39.1
next prev parent reply other threads:[~2023-10-10 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 6:23 [PATCH 0/3] Fix three coverity issues of bond PMD Chaoyong He
2023-10-10 6:23 ` [PATCH 1/3] app/test: fix control flow issue Chaoyong He
2023-10-31 14:51 ` Ferruh Yigit
2023-10-10 6:23 ` [PATCH 2/3] net/bonding: fix illegal memory accesses Chaoyong He
2023-10-31 14:51 ` Ferruh Yigit
2023-11-01 2:19 ` [PATCH v2] " Chaoyong He
2023-11-01 15:38 ` Ferruh Yigit
2023-10-10 6:23 ` Chaoyong He [this message]
2023-10-31 14:52 ` [PATCH 3/3] app/test: fix checking return value Ferruh Yigit
2023-10-31 14:52 ` [PATCH 0/3] Fix three coverity issues of bond PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010062304.205933-4-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).