From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0F7B4234D; Tue, 10 Oct 2023 17:55:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BB30402CD; Tue, 10 Oct 2023 17:55:08 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 07A9040297 for ; Tue, 10 Oct 2023 17:55:08 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-69101022969so5134763b3a.3 for ; Tue, 10 Oct 2023 08:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696953307; x=1697558107; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7oGYCukJFQRjafzleFD7Vpjdvc5a5tk18FctoV2I19c=; b=GzTR+syJUGJGSMjrXHgftLL2J/6iPfrlu8lHu/t6g4BIext0wUe7ef7GBK57kC5hai ZXgfr1phCbDggORxAitCmKjpNps8MUfLthVDvpOMtIk6T8Jcb7uMBQ4RBRvmS5ft2zIO GxwzL+7CHc2G/hJnHNIw+dvIr5SgbSJbXGWFk03zBsETfJjXNl7kOm/mHRL5RzNYNEAJ N8DiLB/oaZQ0XZfaONMPbLLMSXicpSLEYXlXm3lNmZO92WlzApfvP4hL4ZkFhxW/JhRB nMGbrbvUSNkmmTfTavmLa+BmMIChPd0+5bAALCkOYxsTn0HURUzfMY0U4knrzvvKodSa wySA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696953307; x=1697558107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7oGYCukJFQRjafzleFD7Vpjdvc5a5tk18FctoV2I19c=; b=PtMy/ysS4tDfOKMU5l/bZHFQS+DZrET808hAVfZpo7rIjizluch7fa7zjQPkKuvdR6 53JJglN51O02FVaacERHq4HrX0ARw6TcoocQ+jMWhWIekn6RBa3VWO/P1UuvOvqjmE5D K8CPYcBWdMniZl46pQ0u/WdyJTvwWIeWvf3hZM8otFz99HklsiA5foSaNnno3Oq6Rh/Z 0Z/g1jIKz+0yF1oWYhWd2OoqWh3RF/C0g3gea6k4ToAeVuHB0gDObrO81yNVyKblp5eS GJrax6/9r+jHn2o9pNpSKMzVgA3mk1JepJBKGSZAFu3fd6bTsBAIkF/Bh+BmuS0ybGvq 0d+A== X-Gm-Message-State: AOJu0Yzu/q5joyaPxV4yIdj8sy9QSSr8SA6K+SeMTJofV72Mtli7ifvD Qpn65N1wyKyA9Nc1g2OFYZeulg== X-Google-Smtp-Source: AGHT+IGQuK4ZIoeuEXHop1GKv0kDjLBSpmS5MhkvAmoqqcD75dlXUfYcyJGeMdtnh+OXAirakcaKOw== X-Received: by 2002:a05:6a20:1007:b0:169:cd02:65ed with SMTP id gs7-20020a056a20100700b00169cd0265edmr15557597pzc.34.1696953307077; Tue, 10 Oct 2023 08:55:07 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id x8-20020aa784c8000000b00690fdeb5c0dsm8339629pfn.2.2023.10.10.08.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 08:55:06 -0700 (PDT) Date: Tue, 10 Oct 2023 08:55:04 -0700 From: Stephen Hemminger To: Sam Andrew Cc: "dev@dpdk.org" , Long Li Subject: Re: [EXTERNAL] Re: [PATCH] net/netvsc: add support for mtu_set Message-ID: <20231010085504.138f2352@hermes.local> In-Reply-To: References: <20231009081737.3b64131e@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 9 Oct 2023 16:41:38 +0000 Sam Andrew wrote: > > It looks like this proposed patch does not have the accelerated networking > > virtual device case. The driver needs to first update the MTU of the underlying > > VF device (and handle errors), then reinit the vmbus device. > > The following line should handle the AN virtual device case: > > + /* Change MTU of underlying VF dev first, if it exists */ > + ret = hn_vf_mtu_set(dev, mtu); > + if (ret) > + return ret; > > This is the new method added in hn_vf.c: Yes, that should cover it.