From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 396134235E;
Wed, 11 Oct 2023 11:32:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3BC55410E4;
Wed, 11 Oct 2023 11:31:48 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
by mails.dpdk.org (Postfix) with ESMTP id B833040DDA
for <dev@dpdk.org>; Wed, 11 Oct 2023 11:31:35 +0200 (CEST)
Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53])
by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4S56qr3bn9zkY4M;
Wed, 11 Oct 2023 17:27:36 +0800 (CST)
Received: from localhost.localdomain (10.67.165.2) by
kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.31; Wed, 11 Oct 2023 17:31:34 +0800
From: Jie Hai <haijie1@huawei.com>
To: <dev@dpdk.org>, John Daley <johndale@cisco.com>, Hyong Youb Kim
<hyonkim@cisco.com>
CC: <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<liudongdong3@huawei.com>
Subject: [PATCH v5 14/40] net/enic: check RSS hash algorithms
Date: Wed, 11 Oct 2023 17:27:39 +0800
Message-ID: <20231011092805.693171-15-haijie1@huawei.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20231011092805.693171-1-haijie1@huawei.com>
References: <20230908080030.3837515-1-haijie1@huawei.com>
<20231011092805.693171-1-haijie1@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.67.165.2]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
kwepemi500020.china.huawei.com (7.221.188.8)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
A new field 'algorithm' has been added to rss_conf, check it
in case of ignoring unsupported values.
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
drivers/net/enic/enic_ethdev.c | 1 +
drivers/net/enic/enic_main.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index cdf091559196..164f423a85c8 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -834,6 +834,7 @@ static int enicpmd_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
ENICPMD_FUNC_TRACE();
if (rss_conf == NULL)
return -EINVAL;
+
if (rss_conf->rss_key != NULL &&
rss_conf->rss_key_len < ENIC_RSS_HASH_KEY_SIZE) {
dev_err(enic, "rss_hash_conf_get: wrong rss_key_len. given=%u"
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 19a99a82c501..2eafe7637b3a 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1428,6 +1428,9 @@ int enic_set_rss_conf(struct enic *enic, struct rte_eth_rss_conf *rss_conf)
}
}
+ if (rss_enable && rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)
+ return -EINVAL;
+
ret = enic_set_niccfg(enic, ENIC_RSS_DEFAULT_CPU, rss_hash_type,
ENIC_RSS_HASH_BITS, ENIC_RSS_BASE_CPU,
rss_enable);
--
2.30.0