From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BFA343180; Mon, 16 Oct 2023 18:27:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 091A5402D7; Mon, 16 Oct 2023 18:27:55 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 096EA40269 for ; Mon, 16 Oct 2023 18:27:53 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6b36e1fcea0so2146005b3a.1 for ; Mon, 16 Oct 2023 09:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697473673; x=1698078473; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GjJzuZnf5LyMH9JTLvxvWglkSsl5MSy4TNPOYWvrb8I=; b=wU2LbcfPYjqH/bCMXygrRNqw41JHa/Zla+NxrMvCNwP7IGSjOwBPRJGTK9/7SqlsUR opwYnH1FCCtcKXr46fS8WtGbj4bkxrOc800GxA1FaCV4r6ToFNEsvAjKLsW3OqxpkKso //JMxBvXjDIOre8C2eDAuOO/4bShfQpBiG1UJBiRnik5pYuXwmv6vCfHFVeCspNrVfXf kyI3/y4WhOoJR4Aa6jkbjRPdliXbDsXKhJaum5x9omwuGLISD8SZ0tyMzVzfmFfGk8DV E0VhzIktxpyUUXwAi+FSY8P+iTD/hTO0RZgY8UZpQUc3ZborSmbr15DqafEKcbwQsc/b upwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697473673; x=1698078473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GjJzuZnf5LyMH9JTLvxvWglkSsl5MSy4TNPOYWvrb8I=; b=FCIZrh3Y+9SYQTLLiyp9K2bUw10f7ua7/s3sXjVKG6vaUCEidEr9AJsN4Xc9+d5MIO cbnMgSMRxwVc5JWfYpPqFRUTHXyA1Ov/lb12FWQHDqMsestNk0ElV3Ey9C353Z+5QwU7 h4gyAnQbzPIl7ThNPD1rWSgjOoE/+vNp/gb2xyocbRWrlLEaIVF7S39JJDwaPnGRGPqi 3C1PgR9TJeaJOan6AgPqhiGH5Y5opkgBuYeSMZuylIeI2U7rTsXpA9HTHkIpzPsmBtDc oN+tj9RFu1UvIMNpEY/HmSuA+qKxGl5GyKC4GqQFQRwQzeRam71wD5XPdpYgq6o9B3We ZYdA== X-Gm-Message-State: AOJu0Yyys6qatIZZR/Ktc2Ay/JBYQ4vZ+LFuIB8qsS7jHmfYcSPDu4Jw Gy4UfLy8rRTxsKE1HzuzogzjJA== X-Google-Smtp-Source: AGHT+IGBvn0Zvn+5FwQTkuGY4umE6N7LvoJzRy2xZDs4PhjxnV0RPxX7H/TbUnlAUYmiEJAf4eK/mg== X-Received: by 2002:a05:6a00:16cd:b0:68b:a137:3739 with SMTP id l13-20020a056a0016cd00b0068ba1373739mr34837259pfc.4.1697473673013; Mon, 16 Oct 2023 09:27:53 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id r27-20020aa79edb000000b006be2927ca7esm97626pfq.85.2023.10.16.09.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:27:52 -0700 (PDT) Date: Mon, 16 Oct 2023 09:27:51 -0700 From: Stephen Hemminger To: Jerin Jacob Cc: skori@marvell.com, dev@dpdk.org Subject: Re: [PATCH v8 00/12] add CLI based graph application Message-ID: <20231016092751.17b32abb@hermes.local> In-Reply-To: References: <20230927115412.55018-13-skori@marvell.com> <20230929095814.692890-1-skori@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 16 Oct 2023 21:31:29 +0530 Jerin Jacob wrote: > ### [PATCH] app/graph: add telnet connectivity framework > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://github.com/KSPP/linux/issues/90 > #205: FILE: app/graph/conn.c:162: > + strncpy(conn->welcome, p->welcome, CONN_WELCOME_LEN_MAX); > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://github.com/KSPP/linux/issues/90 > #206: FILE: app/graph/conn.c:163: > + strncpy(conn->prompt, p->prompt, CONN_PROMPT_LEN_MAX); > > total: 0 errors, 2 warnings, 554 lines checked These are from the kernel version of checkpatch which now is pushing developers towards replacement kernel apis. For DPDK though you should be using strlcpy() in most places to avoid the missing null end of string on copy of full size.