From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4562B4318D; Tue, 17 Oct 2023 17:56:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33B2340273; Tue, 17 Oct 2023 17:56:45 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 685E740270 for <dev@dpdk.org>; Tue, 17 Oct 2023 17:56:44 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6b3c2607d9bso3324541b3a.1 for <dev@dpdk.org>; Tue, 17 Oct 2023 08:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697558203; x=1698163003; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=64dWIrIJWvtVCcKgKLqdIBIBprdQ+8unZYefJrkWd4I=; b=lgxecOeKb9B4DmfC19y/kY9IZSredxGO3HfK6DUSafnLB5ggPnGN6fQNzihqiz16ob ey8DDgaq4Cj0tEe/wn7I0EbV11Gfy+uFecj4Nfn9EwkpNzmtj4O/436ErET0TmymVJdU KfaEYWzrI4FTRUCHDhyFqTStWYqMN5fGIDIzipg4F09rQz41QtiV9qDSY+H2HX9zh2/C RmDlretzH1k2DrZet/WL7gUpjZPueP7hx04vawIzVVPc0IfspzCxY1Ul9eF8weIirDEP k2TfUqkaxDjl7WD+wrfByyhKDR52AuvM/1A4WQsm2PR+qvS3XKvIhgexdbNELV4LPoVF OYIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697558203; x=1698163003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=64dWIrIJWvtVCcKgKLqdIBIBprdQ+8unZYefJrkWd4I=; b=MCudLSd4b9H4ISbajO/r/x004Iypv6ZUT564FcxNdo+wrkKzG0TdQdvWIHFRL7ZNHL DhC8t10mmBBlENness2fy7QfuE5bxPM3iLV6VjV9quGrLApU8j1Zt4fGE4dAShJV1KlI SYKFJ0xepwG3AX9KvD/DTTs7fLPN1q1BY5OoYo3hqmB+WrH1rFIWrUV3arJji5mvh75W ZONf8VxSVenRdNkHJ5T0TNJRAHYnTr9XoTXl2gzGRx8cFxrc41Z+fZND0EzXNteOCl0x k2zf+7k7hinra2nAcVoEhHPGVKDP3eGEnOf38YzXePu+s1pQfsMT8vYIA60PNzatOXdZ VM5A== X-Gm-Message-State: AOJu0Yz3QM8zQqwGrYzsWRoQE/Hk/wr3WDPlRjLkkvBE1fdG8GQqn9iu kvbjlfm5NgOW563JzJMbk3hn/VYnoiP+sbu+vLogug== X-Google-Smtp-Source: AGHT+IH8/1kxsPk+eDQ7r620gGI07ZU5IYOma9Jqnk9z5CnsGNMAn7L8YCK7PjEpCFAXVVdQrTBO9w== X-Received: by 2002:a05:6a21:8182:b0:165:186:1560 with SMTP id pd2-20020a056a21818200b0016501861560mr2305297pzb.53.1697558203599; Tue, 17 Oct 2023 08:56:43 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id w9-20020a17090aaf8900b002776288537fsm1488240pjq.53.2023.10.17.08.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 08:56:42 -0700 (PDT) Date: Tue, 17 Oct 2023 08:56:40 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: "lihuisong (C)" <lihuisong@huawei.com> Cc: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>, <oss-drivers@corigine.com>, Long Wu <long.wu@corigine.com>, James Hershaw <james.hershaw@corigine.com> Subject: Re: [PATCH v3 7/8] net/bonding: support checking valid bonding port ID Message-ID: <20231017085640.4d352d22@hermes.local> In-Reply-To: <9d3ed36d-5fd1-3a13-82ee-9bd955a10b0f@huawei.com> References: <20231007013440.1309422-1-chaoyong.he@corigine.com> <20231008015041.1551165-1-chaoyong.he@corigine.com> <20231008015041.1551165-8-chaoyong.he@corigine.com> <9d3ed36d-5fd1-3a13-82ee-9bd955a10b0f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 17 Oct 2023 16:33:26 +0800 "lihuisong (C)" <lihuisong@huawei.com> wrote: > > +__rte_experimental > > +int > > +rte_eth_bond_valid_bonding_port_id(uint16_t bonding_port_id); Ok, but my personal preference is to use shorter variable names to avoid typos and overly long lines. Maybe: __rte_experimental bool rte_eth_bond_is_valid_port(uint16_t port_id)