From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E06A4318E; Tue, 17 Oct 2023 18:49:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F08E40EA5; Tue, 17 Oct 2023 18:49:54 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 1E1A940273 for ; Tue, 17 Oct 2023 18:49:53 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-564b6276941so4393421a12.3 for ; Tue, 17 Oct 2023 09:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697561392; x=1698166192; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=u833RQlwMCu7Io7zeXRdLWjIN76j8WRkqvV2RSZRt/o=; b=qBmMboFQIfMKYR/86H7TU7rd7prA2PBqme3RWXFQV8n2sokE0ewWCxjqtsuB6tycqP AUzjghKfPYNRjv7f59/C3He5IjSyhnBMl8dsfDL1vik8cI852/n58slwY0zEv2n6garv pT41Zip9a/MbG1gc2hlcuUkxPqN6HyRsn+ItnCsA/2tt8qIl1vD92YIYVOeaH0gp1PxY c78ZQL5JkIK/JftkhkSCy4j+03hG0da/DLPhDoiW2ujTc5sk3Xk4iQzzzQu0HwyeJArT w2IN+XY/9YqWZFnlyA+4N/tPX6OB5UkZG9BX/Qxi/WA70vWowGJG+/hicoM6rwTI6305 DbuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697561392; x=1698166192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u833RQlwMCu7Io7zeXRdLWjIN76j8WRkqvV2RSZRt/o=; b=bb6q/SgwxqZaVScZjb8bXj/2eLFi0mn0jRWcwkrd+YAawNosHee68136lDjBAIghiO cYwyoVNSVj9liZkvKHQD3K2GKdarp4dK1efZQ48HFJ5qYWAgOUOXa1dJnfDIU05TK1B+ Ggp8WChpyRw93HSNUMV/ZKWNAqc2OqesCdxkAngXtfqbDQFf2+EP8bCNg7bTeIquBlh3 l5MEBq0h8I5mvbJy94Om6JyFUCEfAKU8EuR1FSxTjwz4THuNKZACVc53zzGY4R9ZKKah D1VtOviJw646pPH+0a0rooyuHTzFbt0sraiN/LVdbFI2I35NT/winuIveU970pEQjNzP cK/A== X-Gm-Message-State: AOJu0YxH9hUG6bjC2P1ys5HhVRAnYGbHbe58xChpGs0bNrUTHH7eEreL JL9bGZoOFIWAsNC/WtFy34qB6w== X-Google-Smtp-Source: AGHT+IE7q986Ssnf8Q2Ts2wF2zfKu4BYTBTFiIpv7nuCC6JN3z5hH7rRcgW/DYF5q7ZrtE45oxw7PA== X-Received: by 2002:a17:902:ecce:b0:1c9:d940:78ea with SMTP id a14-20020a170902ecce00b001c9d94078eamr3277110plh.22.1697561392340; Tue, 17 Oct 2023 09:49:52 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id d13-20020a170902728d00b001c724732058sm1798359pll.235.2023.10.17.09.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 09:49:52 -0700 (PDT) Date: Tue, 17 Oct 2023 09:49:50 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: madhuker.mythri@oracle.com, grive@u256.net, dev@dpdk.org Subject: Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id Message-ID: <20231017094950.2492dc13@hermes.local> In-Reply-To: <8971e9a0-e9d0-4da8-1cc3-a1ffbf6ad8f0@amd.com> References: <20221116121121.1969-1-madhuker.mythri@oracle.com> <8971e9a0-e9d0-4da8-1cc3-a1ffbf6ad8f0@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 7 Dec 2022 17:21:42 +0000 Ferruh Yigit wrote: > This is in the 'FOREACH_SUBDEV()' block, why an invalid subdevice > provided by the macro? > > Instead of invalid port check, should we fix the macro? > > Overall I am not clear why this defect occurs, bugzilla report also > don't have much detail. > Can you please provide more details why this defect happens? This looks like a duplicate of same problem Oracle was having when there was a race during setup and secondary process failed. https://patchwork.dpdk.org/project/dpdk/patch/20211021214215.1633-1-vipul.ashri@oracle.com/