From: Timothy Miskell <timothy.miskell@intel.com>
To: qi.z.zhang@intel.com
Cc: dev@dpdk.org, Timothy Miskell <timothy.miskell@intel.com>,
stable@dpdk.org
Subject: [PATCH] ice: Increase L1 check interval to account for lengthier link time
Date: Thu, 19 Oct 2023 16:38:46 +0000 [thread overview]
Message-ID: <20231019163846.324098-1-timothy.miskell@intel.com> (raw)
For edge cases where the transceiver is physically inserted first and immediately afterwards the DPDK PF is started the LSC event may occur outside the current setting for the maximum check interval window. This change lengthens the check interval to account for this along with other reported cases where the link event be longer than 1 second.
Cc: stable@dpdk.org
Reported-by: Timothy Miskell
Suggested-by: Timothy Miskell
Signed-off-by: Timothy Miskell
Reviewed-by: Larry Wang
Tested-by: Jonathan Tsai
---
.mailmap | 2 ++
drivers/net/ice/ice_ethdev.c | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.mailmap b/.mailmap
index 3f5bab26a8..93c09a23ee 100644
--- a/.mailmap
+++ b/.mailmap
@@ -674,6 +674,7 @@ John Romein <romein@astron.nl>
John W. Linville <linville@tuxdriver.com>
Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>
Jonathan Erb <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>
+Jonathan Tsai <jonathan1.tsai@intel.com>
Jon DeVree <nuxi@vault24.org>
Jon Loeliger <jdl@netgate.com>
Joongi Kim <joongi@an.kaist.ac.kr>
@@ -1414,6 +1415,7 @@ Tianli Lai <laitianli@tom.com>
Tianyu Li <tianyu.li@arm.com>
Timmons C. Player <timmons.player@spirent.com>
Timothy McDaniel <timothy.mcdaniel@intel.com>
+Timothy Miskell <timothy.miskell@intel.com>
Timothy Redaelli <tredaelli@redhat.com>
Tim Shearer <tim.shearer@overturenetworks.com>
Ting Xu <ting.xu@intel.com>
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 305077e74e..6ef06b9926 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,
static int
ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)
{
-#define CHECK_INTERVAL 100 /* 100ms */
-#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */
+#define CHECK_INTERVAL 50 /* 50ms */
+#define MAX_REPEAT_TIME 40 /* 2s (40 * 50ms) in total */
struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
struct ice_link_status link_status;
struct rte_eth_link link, old;
--
2.25.1
reply other threads:[~2023-10-19 16:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019163846.324098-1-timothy.miskell@intel.com \
--to=timothy.miskell@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).