From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0FA2A431AE;
Thu, 19 Oct 2023 18:59:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 73A1442E95;
Thu, 19 Oct 2023 18:56:47 +0200 (CEST)
Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com
[209.85.167.171])
by mails.dpdk.org (Postfix) with ESMTP id F02CC42E34
for <dev@dpdk.org>; Thu, 19 Oct 2023 18:56:34 +0200 (CEST)
Received: by mail-oi1-f171.google.com with SMTP id
5614622812f47-3b2ea7cc821so1265151b6e.1
for <dev@dpdk.org>; Thu, 19 Oct 2023 09:56:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697734594;
x=1698339394; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=/Cxt7XYjdWv6GUQuA6c6TD6H9lIsxZBCp7ZK1bd3YRM=;
b=cT4WG/5Ox7ly1am40YPb/veucA67UVgnWMnlbpS6Ueu52f97ALBRuqfwnpgjoIwbwC
+wXPAhkLmAWyHrvNQk+McDtkNbT5Tujvx3IWaF2QwSnE2XHYmSWR3URLeKYwsvV9Jkxo
oTbk+SQycL+PuwgJlbs9KePczl2xTgISy1ETf7RjKiDlWE+Safxiz7Tsts21hDIut1UB
Pffdc2FucQywkTYeTBXf9bvrMhFqUSHoKmc/4/WPDv42Ys6xA3CadXRRMJt/Sj4Amhj/
+TA+23kCuuOH0Csa0qKL9LmXEtf0Sru+TuXwTKQflJkSq5jVdIzPpwxNVeyVmi9yTEg2
oH2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697734594; x=1698339394;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=/Cxt7XYjdWv6GUQuA6c6TD6H9lIsxZBCp7ZK1bd3YRM=;
b=POJpQySG8xd/6fqECyDUckWF3h9Okx0UdujFb9x0hp27ai9q1moPnGiXskQFv2gmP8
Ov0ob51ROVmsbuVRpg2T7GsY9fOXv/O9fakrQLSyvSIZzDX+F9RWb7NKBI9QIDmG04dL
P+yjADzRN3ljNw4j/R3TBfYzodEUhtC7wYbIPWXGnlcV0LSKzC3gPcnYauNz8jB9ewH3
Yaw+F/z6HefdeT2IAqdwYRZNDXg8CYazGTwOm+ehStR9OdlKiamPlCTj87SlChpgbLZP
jIQ04mcY9kflQML8Q22yyJNrQZyTD0tqZdzIE8jXFgD14vJO7+iSsZRBxgs5QdqDPrEB
v9cw==
X-Gm-Message-State: AOJu0YyOQkLVNXi3ii+uSGRRQBKZQTdrFx8p01MWKxNcAl3urJrNA0Ig
rcmzDUZylIZZ/+UFy9cuLV4NveRbg9bzbIFBAPiC8w==
X-Google-Smtp-Source: AGHT+IHzbdQDIRJwvN05Qs4Ql2uYZn5I03qtnd3P+qP+zCbJ7Lh2/tYmjO3QoIa8bTakWhBPedoiFQ==
X-Received: by 2002:a05:6808:98f:b0:3ab:843f:76fd with SMTP id
a15-20020a056808098f00b003ab843f76fdmr2913807oic.19.1697734594100;
Thu, 19 Oct 2023 09:56:34 -0700 (PDT)
Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])
by smtp.gmail.com with ESMTPSA id
y22-20020aa79436000000b00672ea40b8a9sm13988pfo.170.2023.10.19.09.56.33
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 19 Oct 2023 09:56:33 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [PATCH v3 28/29] table: remove experimental from API
Date: Thu, 19 Oct 2023 09:55:57 -0700
Message-Id: <20231019165559.115742-29-stephen@networkplumber.org>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20231019165559.115742-1-stephen@networkplumber.org>
References: <20230808173527.186042-1-stephen@networkplumber.org>
<20231019165559.115742-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Though this library is marked for deprecation in future.
This patch follows the guideline in deprecation notice which
states the experimental API's will become stable.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
doc/guides/rel_notes/deprecation.rst | 2 --
lib/table/rte_swx_table_learner.h | 10 ----------
lib/table/rte_swx_table_selector.h | 6 ------
lib/table/rte_table_hash_func.h | 9 ---------
lib/table/version.map | 18 ++----------------
5 files changed, 2 insertions(+), 43 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 81b93515cbd9..2526040e44f9 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -139,8 +139,6 @@ Deprecation Notices
* table: The table library legacy API (functions rte_table_*)
will be deprecated and subsequently removed in DPDK 24.11 release.
- Before this, the new table library API (functions rte_swx_table_*)
- will gradually transition from experimental to stable status.
* port: The port library legacy API (functions rte_port_*)
will be deprecated and subsequently removed in DPDK 24.11 release.
diff --git a/lib/table/rte_swx_table_learner.h b/lib/table/rte_swx_table_learner.h
index c5ea015b8dcf..66be5fd7d032 100644
--- a/lib/table/rte_swx_table_learner.h
+++ b/lib/table/rte_swx_table_learner.h
@@ -107,7 +107,6 @@ struct rte_swx_table_learner_params {
* @return
* Table memory footprint in bytes.
*/
-__rte_experimental
uint64_t
rte_swx_table_learner_footprint_get(struct rte_swx_table_learner_params *params);
@@ -121,7 +120,6 @@ rte_swx_table_learner_footprint_get(struct rte_swx_table_learner_params *params)
* @return
* Table mailbox footprint in bytes.
*/
-__rte_experimental
uint64_t
rte_swx_table_learner_mailbox_size_get(void);
@@ -135,7 +133,6 @@ rte_swx_table_learner_mailbox_size_get(void);
* @return
* Table handle, on success, or NULL, on error.
*/
-__rte_experimental
void *
rte_swx_table_learner_create(struct rte_swx_table_learner_params *params, int numa_node);
@@ -152,7 +149,6 @@ rte_swx_table_learner_create(struct rte_swx_table_learner_params *params, int nu
* 0 on success or the following error codes otherwise:
* -EINVAL: Invalid argument(s).
*/
-__rte_experimental
int
rte_swx_table_learner_timeout_update(void *table,
uint32_t key_timeout_id,
@@ -206,7 +202,6 @@ rte_swx_table_learner_timeout_update(void *table,
* 0 when the table lookup operation is not yet completed, and 1 when the table lookup operation
* is completed. No other return values are allowed.
*/
-__rte_experimental
int
rte_swx_table_learner_lookup(void *table,
void *mailbox,
@@ -239,7 +234,6 @@ rte_swx_table_learner_lookup(void *table,
* @return
* 0 on success, 1 or error (table full).
*/
-__rte_experimental
uint32_t
rte_swx_table_learner_add(void *table,
void *mailbox,
@@ -261,7 +255,6 @@ rte_swx_table_learner_add(void *table,
* @param[in] time
* Current time measured in CPU clock cycles.
*/
-__rte_experimental
void
rte_swx_table_learner_rearm(void *table,
void *mailbox,
@@ -282,7 +275,6 @@ rte_swx_table_learner_rearm(void *table,
* @param[in] key_timeout_id
* Key timeout ID.
*/
-__rte_experimental
void
rte_swx_table_learner_rearm_new(void *table,
void *mailbox,
@@ -301,7 +293,6 @@ rte_swx_table_learner_rearm_new(void *table,
* @param[in] mailbox
* Mailbox for the current operation.
*/
-__rte_experimental
void
rte_swx_table_learner_delete(void *table,
void *mailbox);
@@ -312,7 +303,6 @@ rte_swx_table_learner_delete(void *table,
* @param[in] table
* Table handle.
*/
-__rte_experimental
void
rte_swx_table_learner_free(void *table);
diff --git a/lib/table/rte_swx_table_selector.h b/lib/table/rte_swx_table_selector.h
index 05863cc90b0a..1f9b93640b1f 100644
--- a/lib/table/rte_swx_table_selector.h
+++ b/lib/table/rte_swx_table_selector.h
@@ -83,7 +83,6 @@ struct rte_swx_table_selector_group {
* @return
* Selector table memory footprint in bytes.
*/
-__rte_experimental
uint64_t
rte_swx_table_selector_footprint_get(uint32_t n_groups_max, uint32_t n_members_per_group_max);
@@ -97,7 +96,6 @@ rte_swx_table_selector_footprint_get(uint32_t n_groups_max, uint32_t n_members_p
* @return
* Selector table mailbox footprint in bytes.
*/
-__rte_experimental
uint64_t
rte_swx_table_selector_mailbox_size_get(void);
@@ -115,7 +113,6 @@ rte_swx_table_selector_mailbox_size_get(void);
* @return
* Table handle, on success, or NULL, on error.
*/
-__rte_experimental
void *
rte_swx_table_selector_create(struct rte_swx_table_selector_params *params,
struct rte_swx_table_selector_group **groups,
@@ -135,7 +132,6 @@ rte_swx_table_selector_create(struct rte_swx_table_selector_params *params,
* -EINVAL: Invalid argument(s);
* -ENOSPC: Too many group members.
*/
-__rte_experimental
int
rte_swx_table_selector_group_set(void *table,
uint32_t group_id,
@@ -177,7 +173,6 @@ rte_swx_table_selector_group_set(void *table,
* 0 when the operation is not yet completed, and 1 when the operation is complete. No other
* return values are allowed.
*/
-__rte_experimental
int
rte_swx_table_selector_select(void *table,
void *mailbox,
@@ -191,7 +186,6 @@ rte_swx_table_selector_select(void *table,
* @param[in] table
* Selector table handle.
*/
-__rte_experimental
void
rte_swx_table_selector_free(void *table);
diff --git a/lib/table/rte_table_hash_func.h b/lib/table/rte_table_hash_func.h
index a962ec2f68e8..d7013ba6c091 100644
--- a/lib/table/rte_table_hash_func.h
+++ b/lib/table/rte_table_hash_func.h
@@ -14,7 +14,6 @@ extern "C" {
#include <rte_compat.h>
#include <rte_common.h>
-__rte_experimental
static inline uint64_t
rte_crc32_u64_generic(uint64_t crc, uint64_t value)
{
@@ -53,7 +52,6 @@ rte_crc32_u64(uint64_t crc, uint64_t v)
#endif
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key8(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -67,7 +65,6 @@ rte_table_hash_crc_key8(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key16(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -86,7 +83,6 @@ rte_table_hash_crc_key16(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key24(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -108,7 +104,6 @@ rte_table_hash_crc_key24(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key32(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -134,7 +129,6 @@ rte_table_hash_crc_key32(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key40(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -160,7 +154,6 @@ rte_table_hash_crc_key40(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key48(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -187,7 +180,6 @@ rte_table_hash_crc_key48(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key56(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
@@ -217,7 +209,6 @@ rte_table_hash_crc_key56(void *key, void *mask, __rte_unused uint32_t key_size,
return crc0;
}
-__rte_experimental
static inline uint64_t
rte_table_hash_crc_key64(void *key, void *mask, __rte_unused uint32_t key_size,
uint64_t seed)
diff --git a/lib/table/version.map b/lib/table/version.map
index 6c8991073210..c73bf2fc4ec7 100644
--- a/lib/table/version.map
+++ b/lib/table/version.map
@@ -15,29 +15,15 @@ DPDK_24 {
rte_table_lpm_ipv6_ops;
rte_table_lpm_ops;
rte_table_stub_ops;
-
- local: *;
-};
-
-EXPERIMENTAL {
- global:
-
- # added in 20.11
rte_swx_table_exact_match_ops;
rte_swx_table_exact_match_unoptimized_ops;
-
- # added in 21.05
rte_swx_table_wildcard_match_ops;
-
- # added in 21.08
rte_swx_table_selector_create;
rte_swx_table_selector_footprint_get;
rte_swx_table_selector_free;
rte_swx_table_selector_group_set;
rte_swx_table_selector_mailbox_size_get;
rte_swx_table_selector_select;
-
- # added in 21.11
rte_swx_table_learner_add;
rte_swx_table_learner_create;
rte_swx_table_learner_delete;
@@ -45,9 +31,9 @@ EXPERIMENTAL {
rte_swx_table_learner_free;
rte_swx_table_learner_lookup;
rte_swx_table_learner_mailbox_size_get;
-
- # added in 22.07
rte_swx_table_learner_rearm;
rte_swx_table_learner_rearm_new;
rte_swx_table_learner_timeout_update;
+
+ local: *;
};
--
2.39.2