From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21193431B1; Thu, 19 Oct 2023 21:11:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C90C24281D; Thu, 19 Oct 2023 21:10:34 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 980DD40EE7 for ; Thu, 19 Oct 2023 21:10:31 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1c9b1e3a809so59139055ad.2 for ; Thu, 19 Oct 2023 12:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697742630; x=1698347430; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=gQiK9jkHXWRrYMcCKttmyVtm0Kbuh4bl1tW+8C90CVHLCi0Po1rRvwN7K1MzN3ElVa HQqcj+nlRTUr7oNTZt0FVLGzPjDvYtmhnDergNi8mg8MpAyIowKdiYrRxkRrGOkrev+e i6pzv2j+o5nmACOF6cO2d2H5s98qLXtlpfB19YGFDO7x+vgTLZMHeutdgTjzudu7vUYM Jw8KjvPeqj6TOQHND1cfPg8x/BrVwm+ejmNDpZyoV5/Fc6haLJuoDZ1ttYhj5mPRT/y7 +Y8DgQS5jJ8CnKUWK/hifZ439hbKEgBGyM42PCSuEYKh3wf8PPPtOyDcVZZQnD3Xd5Br 2TJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697742630; x=1698347430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=wBHJKt0wud+stxDA5S4Yt+kmDrfakzm8x1IUoSeyMdH+zpFZmjyiIGeg+PjNtJK/cK owHiYscTglaj5RoDSe1o7UOX3dZkYod4Cq3nhyol9y2er5C0PDYO1DzFzD4cHVQOnd0V do8xITbM7qE1KFxEbe2j+k2cwu3auSn3FCiu1Tg99iv6D9ZnTMbG2ZCkDSS6/pHg9J7K auCiwhkW1tvAkU0ESPdegy9rcqYylgs3/G9YcSAxCv6fCdvr3vDqr420Le1/y5eAHJDu OLeFBpMcd/OMeeBBQhIEfVpFrkeSLINRGCRMCn+dsCYAzTj1Q/JxO8SeQcwQSJQthkRB T6RQ== X-Gm-Message-State: AOJu0YwCzLiswmy/lO6dQD4ccajYhzAehUNDQQnNy1I3GK8rMcjtoznA +oUWObWrODeYTP+L+hK8zVR+enBGtRFim1mERexLcg== X-Google-Smtp-Source: AGHT+IHtdHcu22OXJW0BnwIl3atGO/YUpQ1StdjF2DyHryrdnz0tyPcM8CzVy4uiBhz0frM5HjLh5Q== X-Received: by 2002:a17:902:d0ca:b0:1bb:30c5:835a with SMTP id n10-20020a170902d0ca00b001bb30c5835amr2594319pln.7.1697742630502; Thu, 19 Oct 2023 12:10:30 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id h12-20020a170902eecc00b001a9b29b6759sm52464plb.183.2023.10.19.12.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:10:29 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH v4 05/28] pdump: make API's stable Date: Thu, 19 Oct 2023 12:09:53 -0700 Message-Id: <20231019191016.156430-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231019191016.156430-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231019191016.156430-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 23.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -}; -- 2.39.2