From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 946EC431EB; Tue, 24 Oct 2023 04:33:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F379440E8A; Tue, 24 Oct 2023 04:30:35 +0200 (CEST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id 7DB9D42E23 for ; Tue, 24 Oct 2023 04:30:32 +0200 (CEST) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6cd1918afb2so2516511a34.0 for ; Mon, 23 Oct 2023 19:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698114632; x=1698719432; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vqX9y6OhUsNSzTeNHrEsvaNt71eXPSm8//JooCU2r50=; b=PvVobfDiOHraM4QqCcS2X9Dl5Ey4MUZYqnbeHIlDOBAiJ8J6tSUqjuAvIg/gFdDWP7 PL0AbBTrtYiTuqsh01ZCSZivSELAWF3nsrci+4PXWhec+Cg2hUEjcxiqJQ+TMN3uwNJF p4d1hwccMvNdfXLNMDZIsCFJS4LHtrKb+yCb2tAWbmj7WiQ9vFXSAXEkzGr26tmbXOAL STC/fY/TAt+zNvi4GBqUzCexYOLSqvTJTE9nziSAGdMqCzgCdyw+Ah1wzEsr37G099iT 6Nii6TF4eHFyJ1pkfiPu6QzNpV+RTPNXXUH5Iibn7jnGpuX5HodMVOlj6uaOuKwGbVl8 Zb6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698114632; x=1698719432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vqX9y6OhUsNSzTeNHrEsvaNt71eXPSm8//JooCU2r50=; b=iiVS2QOf3MB1quGYl5nmspIhkWHqr2H6P3dWwkcDbrR+NGJ4MvFcfuWtjZEc9wg+wg DuK35yR3z9hJu2Pya7TayMD42U4dE1XiTX8HIgxRoieygiLZUaE1gPjs8SRL9RgKxdTF /NkY6ZSDXthwpxXixX0vTVrtMABXw6KRHTtc8W55RJU2LRAaSIa9JoAILRzKDBhFKBSk a8+9kXwrV/8scclfKx1ukPFCMkZ+SHDrP+m+XNharWwflvIIi/KaqiqLPSv0VuXGvHXD rPMmdMYOXg546RKefmeeOEI8QIPSCeC8mXrbPCxUyX/pqIdgKnkJOSoc0cy1S2461ISq 1dZg== X-Gm-Message-State: AOJu0YxJKB2DD/LBA3QcWuFHBnQmx3W+CHMw6fLHiZsaqY39KiAs1bJQ eqH8Zh3Ha3GSSvL0Xpco65yJiQ== X-Google-Smtp-Source: AGHT+IGnrX5kFkB33S+4khVrFxg7QdP0AoVWQ2mQPiNmhhlPyg6vmsPTlVCx6j9qt9W9STChb9HbBg== X-Received: by 2002:a05:6870:4949:b0:1ea:8b10:247e with SMTP id fl9-20020a056870494900b001ea8b10247emr16183773oab.27.1698114631713; Mon, 23 Oct 2023 19:30:31 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id x26-20020aa79ada000000b006be5af77f06sm6770636pfp.2.2023.10.23.19.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:30:31 -0700 (PDT) Date: Mon, 23 Oct 2023 19:30:29 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, Bruce Richardson , Cristian Dumitrescu Subject: Re: [PATCH v5 14/26] meter: remove experimental warning from comments Message-ID: <20231023193029.3a2d6777@hermes.local> In-Reply-To: References: <20230808173527.186042-1-stephen@networkplumber.org> <20231020205759.195126-1-stephen@networkplumber.org> <20231020205759.195126-15-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 23 Oct 2023 09:29:52 +0200 David Marchand wrote: > On Fri, Oct 20, 2023 at 11:00=E2=80=AFPM Stephen Hemminger > wrote: > > > > The API's for rte_meter_trtcm were never properly flagged > > as experimental; missing __rte_experimental but there was > > an experimental comment in the docbook comment. > > Remove the comment. =20 >=20 > While I don't object to this removal, I mentionned in previous mail > that this commitlog is wrong. > Those API were properly flagged as experimental. >=20 > I'll update the commitlog myself... Look at rte_meter in main branch. For example: /** * @warning * @b EXPERIMENTAL: this API may change without prior notice * * trTCM RFC 4115 profile configuration * * @param p * Pointer to pre-allocated trTCM profile data structure * @param params * trTCM profile parameters * @return * 0 upon success, error code otherwise */ int rte_meter_trtcm_rfc4115_profile_config( struct rte_meter_trtcm_rfc4115_profile *p, struct rte_meter_trtcm_rfc4115_params *params); The function is documented as experimental but the function was not marked experimental in version.map or with __rte_experimental attribute. Will reword the commit message to clarify.