From: Alexander Kozyrev <akozyrev@nvidia.com>
To: <dev@dpdk.org>
Cc: <orika@nvidia.com>, <matan@nvidia.com>, <michaelba@nvidia.com>,
<valex@nvidia.com>, <suanmingm@nvidia.com>,
<viacheslavo@nvidia.com>, <erezsh@nvidia.com>
Subject: [PATCH v4 2/4] net/mlx5/hws: add support for fragmented ptype match
Date: Wed, 25 Oct 2023 23:51:16 +0300 [thread overview]
Message-ID: <20231025205118.1605321-3-akozyrev@nvidia.com> (raw)
In-Reply-To: <20231025205118.1605321-1-akozyrev@nvidia.com>
Expand packet type matching with support of the
Fragmented IP (Internet Protocol) packet type.
Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 54 ++++++++++++++++++++++-----
drivers/net/mlx5/hws/mlx5dr_definer.h | 2 +
2 files changed, 46 insertions(+), 10 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index 8d846984e7..0e1035c6bd 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -357,6 +357,19 @@ mlx5dr_definer_ptype_tunnel_set(struct mlx5dr_definer_fc *fc,
DR_SET(tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask);
}
+static void
+mlx5dr_definer_ptype_frag_set(struct mlx5dr_definer_fc *fc,
+ const void *item_spec,
+ uint8_t *tag)
+{
+ bool inner = (fc->fname == MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I);
+ const struct rte_flow_item_ptype *v = item_spec;
+ uint32_t packet_type = v->packet_type &
+ (inner ? RTE_PTYPE_INNER_L4_FRAG : RTE_PTYPE_L4_FRAG);
+
+ DR_SET(tag, !!packet_type, fc->byte_off, fc->bit_off, fc->bit_mask);
+}
+
static void
mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc,
const void *item_spec,
@@ -1840,19 +1853,40 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd,
}
if (m->packet_type & RTE_PTYPE_L4_MASK) {
- fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, false)];
- fc->item_idx = item_idx;
- fc->tag_set = &mlx5dr_definer_ptype_l4_set;
- fc->tag_mask_set = &mlx5dr_definer_ones_set;
- DR_CALC_SET(fc, eth_l2, l4_type, false);
+ /*
+ * Fragmented IP (Internet Protocol) packet type.
+ * Cannot be combined with Layer 4 Types (TCP/UDP).
+ * The exact value must be specified in the mask.
+ */
+ if (m->packet_type == RTE_PTYPE_L4_FRAG) {
+ fc = &cd->fc[DR_CALC_FNAME(PTYPE_FRAG, false)];
+ fc->item_idx = item_idx;
+ fc->tag_set = &mlx5dr_definer_ptype_frag_set;
+ fc->tag_mask_set = &mlx5dr_definer_ones_set;
+ DR_CALC_SET(fc, eth_l2, ip_fragmented, false);
+ } else {
+ fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, false)];
+ fc->item_idx = item_idx;
+ fc->tag_set = &mlx5dr_definer_ptype_l4_set;
+ fc->tag_mask_set = &mlx5dr_definer_ones_set;
+ DR_CALC_SET(fc, eth_l2, l4_type, false);
+ }
}
if (m->packet_type & RTE_PTYPE_INNER_L4_MASK) {
- fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, true)];
- fc->item_idx = item_idx;
- fc->tag_set = &mlx5dr_definer_ptype_l4_set;
- fc->tag_mask_set = &mlx5dr_definer_ones_set;
- DR_CALC_SET(fc, eth_l2, l4_type, true);
+ if (m->packet_type == RTE_PTYPE_INNER_L4_FRAG) {
+ fc = &cd->fc[DR_CALC_FNAME(PTYPE_FRAG, true)];
+ fc->item_idx = item_idx;
+ fc->tag_set = &mlx5dr_definer_ptype_frag_set;
+ fc->tag_mask_set = &mlx5dr_definer_ones_set;
+ DR_CALC_SET(fc, eth_l2, ip_fragmented, true);
+ } else {
+ fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, true)];
+ fc->item_idx = item_idx;
+ fc->tag_set = &mlx5dr_definer_ptype_l4_set;
+ fc->tag_mask_set = &mlx5dr_definer_ones_set;
+ DR_CALC_SET(fc, eth_l2, l4_type, true);
+ }
}
if (m->packet_type & RTE_PTYPE_TUNNEL_MASK) {
diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.h b/drivers/net/mlx5/hws/mlx5dr_definer.h
index ea07f55d52..791154a7dc 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.h
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.h
@@ -148,6 +148,8 @@ enum mlx5dr_definer_fname {
MLX5DR_DEFINER_FNAME_PTYPE_L4_O,
MLX5DR_DEFINER_FNAME_PTYPE_L4_I,
MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL,
+ MLX5DR_DEFINER_FNAME_PTYPE_FRAG_O,
+ MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I,
MLX5DR_DEFINER_FNAME_MAX,
};
--
2.18.2
next prev parent reply other threads:[~2023-10-25 20:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 15:54 [PATCH] mbuf: add ESP packet type Alexander Kozyrev
2023-08-10 16:14 ` Morten Brørup
2023-08-25 23:26 ` Alexander Kozyrev
2023-08-25 23:34 ` [PATCH v2] " Alexander Kozyrev
2023-08-26 8:28 ` Morten Brørup
2023-08-28 18:22 ` [PATCH v3] " Alexander Kozyrev
2023-08-31 10:29 ` Ori Kam
2023-09-20 10:00 ` Nithin Dabilpuram
2023-10-18 11:06 ` Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 0/7] ptype matching support in mlx5 Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 1/7] ethdev: fix ESP packet type description Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 2/7] net/mlx5: add support for ptype match in hardware steering Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 3/7] net/mlx5/hws: add support for fragmented ptype match Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 4/7] doc: add PMD ptype item limitations Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 5/7] doc: add packet type matching item to release notes Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 6/7] net/mlx5/hws: remove csum check from L3 ok check Alexander Kozyrev
2023-10-24 17:51 ` [PATCH v3 7/7] net/mlx5/hws: fix integrity bits level Alexander Kozyrev
2023-10-25 20:51 ` [PATCH v4 0/4] ptype matching support in mlx5 Alexander Kozyrev
2023-10-25 20:51 ` [PATCH v4 1/4] net/mlx5: add support for ptype match in hardware steering Alexander Kozyrev
2023-10-29 13:10 ` Ori Kam
2023-10-25 20:51 ` Alexander Kozyrev [this message]
2023-10-29 13:12 ` [PATCH v4 2/4] net/mlx5/hws: add support for fragmented ptype match Ori Kam
2023-10-25 20:51 ` [PATCH v4 3/4] doc: add PMD ptype item limitations Alexander Kozyrev
2023-10-29 13:13 ` Ori Kam
2023-10-25 20:51 ` [PATCH v4 4/4] doc: add packet type matching item to release notes Alexander Kozyrev
2023-10-29 13:14 ` Ori Kam
2023-10-29 17:27 ` [PATCH v4 0/4] ptype matching support in mlx5 Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025205118.1605321-3-akozyrev@nvidia.com \
--to=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=erezsh@nvidia.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=valex@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).