From: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
To: <david.hunt@intel.com>, <anatoly.burakov@intel.com>,
<david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <john.mcnamara@intel.com>, <thomas@monjalon.net>,
<ferruh.yigit@amd.com>, <karen.kelly@intel.com>
Subject: [PATCH] examples/l3fwd-power: fix to configure the uncore env
Date: Thu, 26 Oct 2023 08:19:59 -0700 [thread overview]
Message-ID: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> (raw)
Updated the l3fwd-power app to configure the uncore env before invoking
any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
too late because other APIs already called.
Bugzilla ID: 1304
Fixes: ac1edcb6621a ("power: refactor uncore power management API")
Cc: karen.kelly@intel.com
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
examples/l3fwd-power/main.c | 6 ++++++
lib/power/rte_power_uncore.c | 7 +++++++
lib/power/rte_power_uncore.h | 9 +++++----
3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 5fbc16bb2a..9c0dcd343b 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1561,6 +1561,12 @@ parse_uncore_options(enum uncore_choice choice, const char *argument)
{
unsigned int die, pkg, max_pkg, max_die;
int ret = 0;
+ ret = rte_power_set_uncore_env(RTE_UNCORE_PM_ENV_AUTO_DETECT);
+ if (ret < 0) {
+ RTE_LOG(INFO, L3FWD_POWER, "Failed to set uncore env\n");
+ return ret;
+ }
+
max_pkg = rte_power_uncore_get_num_pkgs();
if (max_pkg == 0)
return -1;
diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c
index 78a823d34c..d87328bedf 100644
--- a/lib/power/rte_power_uncore.c
+++ b/lib/power/rte_power_uncore.c
@@ -105,6 +105,13 @@ rte_power_set_uncore_env(enum rte_uncore_power_mgmt_env env)
return -1;
}
+ if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT)
+ /* Currently only intel_uncore is supported. This will be
+ * extended with auto-detection support for multiple uncore
+ * implementations.
+ */
+ env = RTE_UNCORE_PM_ENV_INTEL_UNCORE;
+
ret = 0;
if (env == RTE_UNCORE_PM_ENV_INTEL_UNCORE) {
rte_power_get_uncore_freq = power_get_intel_uncore_freq;
diff --git a/lib/power/rte_power_uncore.h b/lib/power/rte_power_uncore.h
index 295017b7f4..ede50a5f87 100644
--- a/lib/power/rte_power_uncore.h
+++ b/lib/power/rte_power_uncore.h
@@ -21,15 +21,16 @@ extern "C" {
/* Uncore Power Management Environment */
enum rte_uncore_power_mgmt_env {
RTE_UNCORE_PM_ENV_NOT_SET,
+ RTE_UNCORE_PM_ENV_AUTO_DETECT,
RTE_UNCORE_PM_ENV_INTEL_UNCORE,
RTE_UNCORE_PM_ENV_AMD_HSMP
};
/**
- * Set the default uncore power management implementation. If this is not called prior
- * to rte_power_uncore_init(), then auto-detect of the environment will take place.
- * It is thread safe. New env can be set only in uninitialized state
- * (thus rte_power_unset_uncore_env must be called if different env was already set).
+ * Set the default uncore power management implementation. This has to be called
+ * prior to calling any other rte_power_uncore_*() API.
+ * It is thread safe. New env can be set only in uninitialized state.
+ * rte_power_unset_uncore_env must be called if different env was already set).
*
* @param env
* env. The environment in which to initialise Uncore Power Management for.
--
2.34.1
next reply other threads:[~2023-10-26 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:19 Sivaprasad Tummala [this message]
2023-10-27 12:36 ` Kelly, Karen
2023-10-27 12:37 ` Hunt, David
2023-11-27 21:19 ` Thomas Monjalon
2023-11-23 1:58 ` Thomas Monjalon
2023-11-23 10:26 ` Ferruh Yigit
2023-11-27 16:54 ` Bruce Richardson
2023-11-27 21:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026151959.1458112-1-sivaprasad.tummala@amd.com \
--to=sivaprasad.tummala@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=john.mcnamara@intel.com \
--cc=karen.kelly@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).