* [PATCH] net/af_xdp: avoid error log for virtual interfaces
@ 2023-10-27 14:32 David Marchand
2023-10-27 20:37 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2023-10-27 14:32 UTC (permalink / raw)
To: dev; +Cc: Ciara Loftus, Qi Zhang, Ferruh Yigit, Frank Du
For virtual interfaces, like a veth or a tap used in OVS unit tests,
plugging a af_xdp port on them results in an error level message:
dpdk|ERR|EAL: eal_parse_sysfs_value(): cannot open sysfs value
/sys/class/net/ovs-tap1/device/numa_node
netdev_dpdk|INFO|Device 'net_af_xdptap1,iface=ovs-tap1' attached to DPDK
Avoid this error by checking if the sysfs file exists, like what is done
in DPDK bus drivers using eal_parse_sysfs_value().
Fixes: 3d28387cbc48 ("net/af_xdp: parse NUMA node ID from sysfs")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 0cc51223ba..353c8688ec 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -2399,7 +2399,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
snprintf(numa_path, sizeof(numa_path), "/sys/class/net/%s/device/numa_node",
if_name);
- if (eal_parse_sysfs_value(numa_path, &numa) != 0)
+ if (access(numa_path, R_OK) != 0 || eal_parse_sysfs_value(numa_path, &numa) != 0)
dev->device.numa_node = rte_socket_id();
else
dev->device.numa_node = numa;
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/af_xdp: avoid error log for virtual interfaces
2023-10-27 14:32 [PATCH] net/af_xdp: avoid error log for virtual interfaces David Marchand
@ 2023-10-27 20:37 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-10-27 20:37 UTC (permalink / raw)
To: David Marchand, dev; +Cc: Ciara Loftus, Qi Zhang, Frank Du
On 10/27/2023 3:32 PM, David Marchand wrote:
> For virtual interfaces, like a veth or a tap used in OVS unit tests,
> plugging a af_xdp port on them results in an error level message:
>
> dpdk|ERR|EAL: eal_parse_sysfs_value(): cannot open sysfs value
> /sys/class/net/ovs-tap1/device/numa_node
> netdev_dpdk|INFO|Device 'net_af_xdptap1,iface=ovs-tap1' attached to DPDK
>
> Avoid this error by checking if the sysfs file exists, like what is done
> in DPDK bus drivers using eal_parse_sysfs_value().
>
> Fixes: 3d28387cbc48 ("net/af_xdp: parse NUMA node ID from sysfs")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-27 14:32 [PATCH] net/af_xdp: avoid error log for virtual interfaces David Marchand
2023-10-27 20:37 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).