From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C71EF43248; Tue, 31 Oct 2023 01:10:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F627400EF; Tue, 31 Oct 2023 01:10:32 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 891F9400D7 for <dev@dpdk.org>; Tue, 31 Oct 2023 01:10:31 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2801d7f46f9so2338786a91.3 for <dev@dpdk.org>; Mon, 30 Oct 2023 17:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698711030; x=1699315830; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=J8ziGS19qZx9241ueyh9k0QB+yC5iWtIyur066qPbUE=; b=eHjM+lF0+Myc+JtMKlVB+owBEPL1STx2nfFNSRpY3iYp/aUDSpmwoUIp364eamUmSu +jM8quO8WeRRz081RXpnQUw0pJ9TsfIu2U0qHz27Zwcdkf05Ogcflpd7tJUEF+b+uTik AOnd1T2Gqfj4cR56c8ho6cTGyVMrhZYjMq28HiUJLpy7hZ+bycASR3j2gLWz5UoyZbiq +XxVTaZ0zJUVRi+sE/2iv8zrTY/KeoJQ2w4wmNOzBai5e6K+zlnfOjWD48awIwTt8FOM TyxufWu8CMllzYPeu85Qac9MJTnqF3Dm+R+l4D7yugccfs11nN3Jrx0BO3YghnXMBKM6 Tz2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698711030; x=1699315830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J8ziGS19qZx9241ueyh9k0QB+yC5iWtIyur066qPbUE=; b=StSQwPDR7FhOFVRozGER6VRJGp5MU39wSAfVWKnKvP1v6YDIvGJ7lhuZ6Bbov4CUOm PDhKdE2h0kzlsRiR71tP1UvmLuDDIxAYu7GwBQPeySHAlruMJBvcYL12UEmMYvJQIPRG rEiFm4bN4fFtzxhXOMKNQDEkSMwCQTZtYJeQDJwl3skKdjuuqEF8PQ0Rb5bHIcF4rB9S T7MTQf+6woNRIQ/oDrBzOdBJR3Gecc97x3Ec/OBeh15OkYjwXZFVoNt79ZGfQbBSAK/Y zCWPY004xdv59ampfOTtpMHkTfrihbv4VtjanP8ZUZifK2AEaH0xv2E11+rCOdBmZfWh F3Fg== X-Gm-Message-State: AOJu0YznAYNwCu4wt7CKWxMRGXzX3vpo17Zmi1B/rjs3xF/vqofv4qnB sUXsrCbMZ5+u6KIrmAo0RhItgA== X-Google-Smtp-Source: AGHT+IEdTvK+xvnnOsw7fOL2AbB4P0izfxIacWb5CQbRsD8zwZH8uDNpVOAR02M05/OWNpNrQjkI5w== X-Received: by 2002:a17:90b:3592:b0:27c:ed8e:1840 with SMTP id mm18-20020a17090b359200b0027ced8e1840mr7827154pjb.10.1698711030428; Mon, 30 Oct 2023 17:10:30 -0700 (PDT) Received: from fedora ([38.142.2.14]) by smtp.gmail.com with ESMTPSA id ns6-20020a17090b250600b0028012be0764sm52996pjb.20.2023.10.30.17.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 17:10:30 -0700 (PDT) Date: Mon, 30 Oct 2023 17:10:25 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Abdullah Sevincer <abdullah.sevincer@intel.com> Cc: dev@dpdk.org, jerinj@marvell.com, mike.ximing.chen@intel.com Subject: Re: [PATCH v1] event/dlb2: add support for disabling PASID Message-ID: <20231030171025.4c7f2bd2@fedora> In-Reply-To: <20230607210050.107944-1-abdullah.sevincer@intel.com> References: <20230607210050.107944-1-abdullah.sevincer@intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, 7 Jun 2023 16:00:50 -0500 Abdullah Sevincer <abdullah.sevincer@intel.com> wrote: > From: Abdullah Sevincer <abdullah.sevincer@intel.com> > To: dev@dpdk.org > Cc: jerinj@marvell.com, mike.ximing.chen@intel.com, Abdullah Sevincer <abdullah.sevincer@intel.com> > Subject: [PATCH v1] event/dlb2: add support for disabling PASID > Date: Wed, 7 Jun 2023 16:00:50 -0500 > X-Mailer: git-send-email 2.25.1 > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > In DLB hardware, enabling PASID puts DLB in SIOV mode. This > breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly > PASID needs to be disabled for kernel 6.2. > > In this commit this issue is addressed and PASID is disabled > by writing a zero to PASID control register. > > Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com> It is not clear if this is kernels 6.2 or later, or just that version. Also, distribution kernel versions don't reflect upstream so if you are complaining about RHEL etc. The code is version independent (good). It would be good to supply more commit information (ideally upstream commit id) in this patch commit log. Also 6.2 kernel is end-of-life (May 2023) so users should be using older or later supported kernel version.